OCPBUGS-87493: Updating ose-baremetal-installer-container image to be consistent with ART for 5.0#10602
Conversation
ffdd361 to
ce46cde
Compare
|
Created by ART pipeline job run https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/aos-cd-builds/job/build%252Fsync-ci-images/216 |
|
Note
|
| Layer / File(s) | Summary |
|---|---|
CI build root image and baremetal builder stage versions .ci-operator.yaml, images/baremetal/Dockerfile.ci |
CI operator build_root_image.tag and baremetal Dockerfile build stages (etcd, hyperkube, builder) and final runtime base image updated from OpenShift 4.22 with Go 1.25 to OpenShift 5.0 with Go 1.26. |
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Stable And Deterministic Test Names | ✅ Passed | PR modifies CI config (.ci-operator.yaml) and Dockerfile, not test code. Repository uses standard Go testing.T, not Ginkgo. No Ginkgo test names in non-vendored code. |
| Test Structure And Quality | ✅ Passed | PR contains no Ginkgo test code. Changes are limited to CI configuration and Dockerfile, not test code requiring quality assessment. |
| Microshift Test Compatibility | ✅ Passed | No new Ginkgo e2e tests are added in this PR. Changes are limited to CI configuration (.ci-operator.yaml) and Dockerfile image tag updates for build stages. |
| Single Node Openshift (Sno) Test Compatibility | ✅ Passed | PR modifies only CI configuration (.ci-operator.yaml, images/baremetal/Dockerfile.ci) with no new Ginkgo e2e tests. SNO compatibility check does not apply. |
| Topology-Aware Scheduling Compatibility | ✅ Passed | PR only modifies CI build configuration (.ci-operator.yaml) and Dockerfile.ci base images; no deployment manifests, operator code, controllers, or scheduling constraints are added or modified. |
| Ote Binary Stdout Contract | ✅ Passed | PR only modifies CI config files (.ci-operator.yaml, Dockerfile.ci), not application code. OTE Stdout Contract applies to binary code (main, init, etc.), not build infrastructure. |
| Ipv6 And Disconnected Network Test Compatibility | ✅ Passed | PR contains no new Ginkgo e2e tests. Changes are limited to CI configuration (.ci-operator.yaml) and Dockerfile updates (images/baremetal/Dockerfile.ci). The custom check does not apply. |
| No-Weak-Crypto | ✅ Passed | PR updates build config/Docker base images (OpenShift 4.22→5.0, Go 1.25→1.26). No weak cryptographic algorithms, custom crypto implementations, or insecure secret comparisons are introduced. |
| Container-Privileges | ✅ Passed | PR modifies only CI config and Dockerfile. No K8s manifests with privileged settings, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation present. Dockerfile runs as non-root (USER 1000:1000). |
| No-Sensitive-Data-In-Logs | ✅ Passed | No logging statements expose sensitive data (passwords, tokens, API keys, PII, session IDs, or credentials) in the PR changes; modifications are image tag updates only. |
| Title check | ✅ Passed | The title accurately describes the main change: updating container images from OpenShift 4.22 to 5.0 for ART consistency, matching the actual file modifications. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Comment @coderabbitai help to get the list of available commands and usage tips.
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87493, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87493, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@images/baremetal/Dockerfile.ci`:
- Around line 5-8: The Dockerfile uses unapproved CI registry images in the FROM
stages; update the base images for the stages named "etcd", "kas", and "builder"
(and the other stage referenced at line 20) to approved UBI minimal or
distroless images from catalog.redhat.com (or add a documented exception if a CI
image is required), by replacing the registry.ci.openshift.org image references
with the corresponding catalog.redhat.com UBI/distroless equivalents and
ensuring any required tag/variant (golang/runtime) matches the original
functionality.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: bb7d0da3-26de-4aca-bc15-a2e98acab8f3
📒 Files selected for processing (2)
.ci-operator.yamlimages/baremetal/Dockerfile.ci
| FROM registry.ci.openshift.org/ocp/5.0:etcd AS etcd | ||
| FROM registry.ci.openshift.org/ocp/5.0:hyperkube AS kas | ||
|
|
||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.25-openshift-4.22 AS builder | ||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.26-openshift-5.0 AS builder |
There was a problem hiding this comment.
Use approved Red Hat base images for all FROM stages.
Lines 5, 6, 8, and 20 still use registry.ci.openshift.org/... images instead of approved UBI/distroless images from catalog.redhat.com, which violates the container security baseline for Dockerfiles in this repo. Please switch these stages to approved catalog images (or document an explicit exception if this CI image must diverge).
As per coding guidelines, "Base image: UBI minimal or distroless from catalog.redhat.com".
Also applies to: 20-20
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@images/baremetal/Dockerfile.ci` around lines 5 - 8, The Dockerfile uses
unapproved CI registry images in the FROM stages; update the base images for the
stages named "etcd", "kas", and "builder" (and the other stage referenced at
line 20) to approved UBI minimal or distroless images from catalog.redhat.com
(or add a documented exception if a CI image is required), by replacing the
registry.ci.openshift.org image references with the corresponding
catalog.redhat.com UBI/distroless equivalents and ensuring any required
tag/variant (golang/runtime) matches the original functionality.
Source: Coding guidelines
|
@openshift-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
ART wants to connect issue OCPBUGS-87746 to this PR, but found it is currently hooked up to ['OCPBUGS-87493']. Please consult with #forum-ocp-art if it is not clear what there is to do. |
Updating ose-baremetal-installer-container image to be consistent with ART for 5.0
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.
The configuration in the following ART component metadata is driving this alignment request:
ose-baremetal-installer.yml.
Detail:
This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.
Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.
PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.
Roles & Responsibilities:
tests OR that necessary metadata changes are reported to the ART team
in
#forum-ocp-arton Slack. If necessary, the changes required by this pull request can beintroduced with a separate PR opened by the component team. Once the repository is aligned,
this PR will be closed automatically.
verify-depsis complaining. In that case, please opena new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
any required labels to ensure the PR merges once tests are passing. In cases where ART config is
canonical, downstream builds are already being built with these changes, and merging this PR
only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
a grace period for the component team to align their CI with ART's configuration before it becomes
canonical in product builds.
ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:
Change behavior of future PRs:
set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
To do so, open a PR to set the
auto_labelattribute in the image configuration. ExampleUPSTREAM: <carry>:. An example.If you have any questions about this pull request, please reach out in the
#forum-ocp-artSlack channel.Summary by CodeRabbit