Skip to content

_鈿狅笍 Potential issue_ | _馃煚 Major_#1722

Description

@kannon92

鈿狅笍 Potential issue | 馃煚 Major

Remove trailing whitespace from the image pull spec.

Line 8 ends with a space inside the JSON string, so the stored image reference is not exact and may fail in strict parsers/consumers. Please trim the value (and ideally normalize other image entries in this file the same way).

Proposed fix
-    "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-must-gather-main@sha256:89656a2c023a2e94d3b5faa8f41fee92f8fb9ab6a31cc820292067273721738b "
+    "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-must-gather-main@sha256:89656a2c023a2e94d3b5faa8f41fee92f8fb9ab6a31cc820292067273721738b"

As per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."

馃摑 Committable suggestion

鈥硷笍 IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-must-gather-main@sha256:89656a2c023a2e94d3b5faa8f41fee92f8fb9ab6a31cc820292067273721738b"
馃 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@related_images.developer.json` at line 8, The JSON entry for the "image" key
contains a trailing space in the pull spec
("quay.io/...@sha256:89656a2c023a2e94d3b5faa8f41fee92f8fb9ab6a31cc820292067273721738b
") which can break strict parsers; trim the trailing whitespace from that string
and scan the file for other "image" values to normalize/remove any
leading/trailing whitespace so all image pull specs are exact.

Originally posted by @coderabbitai[bot] in #1717 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions