Remove Lokistack RetentionPolicy from ClusterLogging instance (CLI Steps)

- In the Installing log storage [1] section in Installing Logging and the Loki Operator using the CLI [2], step No. 13: Create a LokiStack CR: LokiStack RetentionPolicy is mentioned.

[1] https://docs.openshift.com/container-platform/4.16/observability/logging/log_storage/installing-log-storage.html
[2] https://docs.openshift.com/container-platform/4.16/observability/logging/log_storage/installing-log-storage.html#logging-loki-cli-install_installing-log-storage

- Lokistack RetentionPolicy should not be part of ClusterLogging Instance configuration.

- Here is the current configuration:

~~~
apiVersion: logging.openshift.io/v1
kind: ClusterLogging
metadata:
  name: instance 
  namespace: openshift-logging 
spec:
  collection:
    type: vector
  logStore:
    lokistack:
      name: logging-loki
    retentionPolicy:
      application:
        maxAge: 7d
      audit:
        maxAge: 7d
      infra:
        maxAge: 7d
    type: lokistack
  visualization:
    type: ocp-console
    ocpConsole:
      logsLimit: 15
  managementState: Managed
~~~

- Lokistack RetentionPolicy needs to be mentioned in the LokiStack CR.

- Please check Documentation [3] and KCS ([4] for reference.
[3] https://docs.openshift.com/container-platform/4.16/observability/logging/logging-6.1/log6x-loki-6.1.html#logging-loki-retention_log6x-loki-6.1
[4] https://access.redhat.com/solutions/7053212

- Hence, we need to remove the retentionPolicy section from the ClusterLogging Instance CR.

- Here is the corrected configuration looks:
~~~
apiVersion: logging.openshift.io/v1
kind: ClusterLogging
metadata:
  name: instance 
  namespace: openshift-logging 
spec:
  collection:
    type: vector
  logStore:
    lokistack:
      name: logging-loki
    type: lokistack
  visualization:
    type: ocp-console
    ocpConsole:
      logsLimit: 15
  managementState: Managed 
~~~

Author: prithvipatil97

modules/logging-loki-cli-install.adoc

@@ -202,13 +202,6 @@ spec:
   logStore:
     lokistack:
       name: logging-loki
-    retentionPolicy:
-      application:
-        maxAge: 7d
-      audit:
-        maxAge: 7d
-      infra:
-        maxAge: 7d
     type: lokistack
   visualization:
     type: ocp-console