From 40d40c4191a86d76834c4fa56a88fc901535e1f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20R=C3=ADos?= Date: Wed, 2 Jun 2021 19:35:43 -0400 Subject: [PATCH 1/3] add another_trace method, in order to trace other functions or methods --- django_opentracing/tracing.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/django_opentracing/tracing.py b/django_opentracing/tracing.py index ded55d7..c6311ee 100644 --- a/django_opentracing/tracing.py +++ b/django_opentracing/tracing.py @@ -72,6 +72,18 @@ def wrapper(request, *args, **kwargs): return wrapper return decorator + def another_trace(self, name, is_method=False): + def decorator(func): + def wrapper(*args, **kwargs): + # check if `func' is a method or not + if is_method: + name = type(args[0])).__name__ + '.' + name + with self.tracer.start_active_span(name): + return func(*args, **kwargs) + + return wrapper + return decorator + def _apply_tracing(self, request, view_func, attributes): ''' Helper function to avoid rewriting for middleware and decorator. From f34bbb78cbf89a0af5af6f656378d3910fefca3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20R=C3=ADos?= Date: Wed, 2 Jun 2021 19:51:14 -0400 Subject: [PATCH 2/3] fix typo --- django_opentracing/tracing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/django_opentracing/tracing.py b/django_opentracing/tracing.py index c6311ee..457baa1 100644 --- a/django_opentracing/tracing.py +++ b/django_opentracing/tracing.py @@ -77,7 +77,7 @@ def decorator(func): def wrapper(*args, **kwargs): # check if `func' is a method or not if is_method: - name = type(args[0])).__name__ + '.' + name + name = type(args[0]).__name__ + '.' + name with self.tracer.start_active_span(name): return func(*args, **kwargs) From 82e49eb2b7202823a6966d4187b4d03929782071 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20R=C3=ADos?= Date: Wed, 2 Jun 2021 20:28:46 -0400 Subject: [PATCH 3/3] fix variable use --- django_opentracing/tracing.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/django_opentracing/tracing.py b/django_opentracing/tracing.py index 457baa1..9ad0891 100644 --- a/django_opentracing/tracing.py +++ b/django_opentracing/tracing.py @@ -77,9 +77,13 @@ def decorator(func): def wrapper(*args, **kwargs): # check if `func' is a method or not if is_method: - name = type(args[0]).__name__ + '.' + name - with self.tracer.start_active_span(name): - return func(*args, **kwargs) + fname = type(args[0]).__name__ + '.' + name + else: + fname = name + + with self.tracer.start_active_span(fname): + r = func(*args, **kwargs) + return r return wrapper return decorator