Skip to content

[fix] Trigger changelog bot for backward incompatible changes#73

Open
nemesifier wants to merge 1 commit into
masterfrom
changelog-bot-change-bang
Open

[fix] Trigger changelog bot for backward incompatible changes#73
nemesifier wants to merge 1 commit into
masterfrom
changelog-bot-change-bang

Conversation

@nemesifier

Copy link
Copy Markdown
Member

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

No existing issue.

Description of Changes

This PR updates the changelog bot trigger workflow to match PR titles starting with [change!].

This allows backward incompatible PRs to run the reusable changelog workflow after maintainer approval, the same as [feature], [fix], and [change] PRs.

Screenshot

Not applicable.

Update the changelog bot trigger so PR titles marked with [change!] run the reusable changelog workflow.
@kilo-code-bot

kilo-code-bot Bot commented May 26, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • .github/workflows/bot-changelog-trigger.yml - Simple regex update to support [change!] PR titles for backward incompatible changes

Review Notes:

The regex change from ^\[(feature|fix|change)\] to ^\[(feature|fix|change!?)\] correctly implements the stated goal. The !? pattern makes the exclamation mark optional, so both [change] and [change!] PR titles will now trigger the changelog bot. This is a minimal and appropriate fix.


Reviewed by kimi-k2.5 · 211,489 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant