fix(backend, tests): too many db connections in integration tests

Since the neo4j driver upgrade, we must ensure the neo4j driver is
properly closed and that a closed driver is not re-used.
We disabled singletons during DI to get that behavior.

A side effect is that during some integration tests that leverage local
workers, some tasks/flows depend on the injected database instance,
which would trigger new driver instances with new db connections.
Those instances would not get cleaned since it's not using a singleton
nor used within a context manager that would close the underlying db
driver.

Fix this by introducing a new class level fixture for the db instance
and use it within the injected dependency.

Signed-off-by: Fatih Acar <fatih@opsmill.com>

Author: fatih-acar

backend/tests/helpers/test_app.py

@@ -120,11 +120,16 @@ async def register_core_schema(
         await default_branch.save(db=db)
         return schema_branch
 
+    @pytest.fixture(scope="class")
+    async def class_db(self) -> InfrahubDatabase:
+        return await build_database(singleton=False)
+
     @pytest.fixture(scope="class")
     async def test_client(
         self,
         dependency_provider: Provider,
         db: InfrahubDatabase,
+        class_db: InfrahubDatabase,
         initialize_registry: None,
         redis: dict[int, int] | None,
         nats: dict[int, int] | None,
@@ -135,7 +140,7 @@ async def test_client(
         # NOTE 2: FastAPI does not have an asynchronous TestClient, thus we rely on httpx.AsyncClient which does not trigger
         # lifespan events (see https://fastapi.tiangolo.com/advanced/async-tests/#in-detail).
         async def _db(singleton: bool = True) -> InfrahubDatabase:
-            return await build_database(singleton=False)
+            return class_db
 
         with dependency_provider.scope(build_database, _db):
             async with lifespan(app):

backend/tests/integration/git/test_git_repository.py

@@ -1,7 +1,9 @@
 from pathlib import Path
+from typing import AsyncGenerator
 
 import pytest
 import yaml
+from fast_depends import dependency_provider
 from infrahub_sdk import Config, InfrahubClient
 from infrahub_sdk.exceptions import NodeNotFoundError
 from infrahub_sdk.protocols import CoreCheckDefinition, CoreGraphQLQuery, CoreTransformJinja2, CoreTransformPython
@@ -15,9 +17,10 @@
 from infrahub.core.utils import count_relationships, delete_all_nodes
 from infrahub.database import InfrahubDatabase
 from infrahub.git import InfrahubRepository
-from infrahub.server import app, app_initialization
+from infrahub.server import app, lifespan
 from infrahub.services.adapters.workflow.local import WorkflowLocalExecution
 from infrahub.utils import get_models_dir
+from infrahub.workers.dependencies import build_database
 from infrahub.workflows.initialization import setup_task_manager
 from tests.helpers.file_repo import FileRepo
 from tests.helpers.test_app import TestInfrahubApp
@@ -60,14 +63,23 @@ async def base_dataset(self, db: InfrahubDatabase, redis, nats) -> None:
         await load_infrastructure_schema(db=db)
         await initialization(db=db)
 
+    @pytest.fixture(scope="class")
+    async def class_db(self) -> InfrahubDatabase:
+        return await build_database(singleton=False)
+
     @pytest.fixture(scope="class")
     async def test_client(
         self,
         base_dataset,
         workflow_local,
-    ) -> InfrahubTestClient:
-        await app_initialization(app)
-        return InfrahubTestClient(app=app)
+        class_db,
+    ) -> AsyncGenerator[InfrahubTestClient, None]:
+        async def _db(singleton: bool = True) -> InfrahubDatabase:
+            return class_db
+
+        with dependency_provider.scope(build_database, _db):
+            async with lifespan(app):
+                yield InfrahubTestClient(app=app)
 
     @pytest.fixture
     async def client(self, test_client: InfrahubTestClient, integration_helper) -> InfrahubClient: