fix: Agent plugin config dynamic values

Signed-off-by: Devon Crouse <devon.crouse@oracle.com>

Author: devoncrouse

modules/workers/instance.tf

@@ -52,8 +52,8 @@ resource "oci_core_instance" "workers" {
     dynamic "plugins_config" {
       for_each = each.value.agent_config.plugins_config
       content {
-        name          = each.key
-        desired_state = each.value
+        name          = plugins_config.key
+        desired_state = plugins_config.value
       }
     }
   }

modules/workers/instanceconfig.tf

@@ -20,8 +20,8 @@ resource "oci_core_instance_configuration" "workers" {
         dynamic "plugins_config" {
           for_each = each.value.agent_config.plugins_config
           content {
-            name          = each.key
-            desired_state = each.value
+            name          = plugins_config.key
+            desired_state = plugins_config.value
           }
         }
       }

modules/workers/locals.tf

@@ -91,6 +91,8 @@ locals {
         }
       ]
 
+      agent_config = coalesce(var.agent_config, pool.agent_config, local.worker_pool_defaults.agent_config)
+
       # Translate configured + available AD numbers e.g. 2 into tenancy/compartment-specific names
       availability_domains = compact([for ad_number in tolist(setintersection(pool.placement_ads, var.ad_numbers)) :
         lookup(var.ad_numbers_to_names, ad_number, null)

modules/workers/variables.tf

@@ -304,7 +304,6 @@ variable "platform_config" {
 }
 
 variable "agent_config" {
-  default     = null
   description = "Default agent_config for self-managed worker pools created with mode: 'instance', 'instance-pool', or 'cluster-network'. See <a href=https://docs.oracle.com/en-us/iaas/api/#/en/iaas/20160918/datatypes/InstanceAgentConfig for more information."
   type = object({
     are_all_plugins_disabled = bool,