Skip to content

Commit 3c55a6b

Browse files
authored
Fix for Database Alias (#179)
* Fix for Database Alias in State
1 parent aa1a439 commit 3c55a6b

File tree

6 files changed

+15
-17
lines changed

6 files changed

+15
-17
lines changed

src/client/content/config/settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ def spring_ai_obaas(src_dir, file_name, provider, ll_model):
208208
ctx_prompt=f"{ctx_prompt}",
209209
ll_model=state["user_settings"]["ll_model"] | state["ll_model_enabled"][ll_model],
210210
vector_search=state["user_settings"]["vector_search"],
211-
database_config=state["database_config"][state["user_settings"]["vector_search"]["database"]],
211+
database_config=state["database_config"][state["user_settings"]["database"]["alias"]],
212212
)
213213

214214
if file_name.endswith(".yaml"):
@@ -219,7 +219,7 @@ def spring_ai_obaas(src_dir, file_name, provider, ll_model):
219219
ctx_prompt=ctx_prompt,
220220
ll_model=state["user_settings"]["ll_model"] | state["ll_model_enabled"][ll_model],
221221
vector_search=state["user_settings"]["vector_search"],
222-
database_config=state["database_config"][state["user_settings"]["vector_search"]["database"]],
222+
database_config=state["database_config"][state["user_settings"]["database"]["alias"]],
223223
)
224224

225225
yaml_data = yaml.safe_load(formatted_content)

src/client/content/testbed.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def create_gauge(value):
8787
st.dataframe(ll_settings_reversed, hide_index=True)
8888
if report["settings"]["vector_search"]["enabled"]:
8989
st.subheader("Vector Search Settings")
90-
st.markdown(f"""**Database**: {report["settings"]["vector_search"]["database"]};
90+
st.markdown(f"""**Database**: {report["settings"]["database"]["alias"]};
9191
**Vector Store**: {report["settings"]["vector_search"]["vector_store"]}
9292
""")
9393
embed_settings = pd.DataFrame(report["settings"]["vector_search"], index=[0])

src/client/content/tools/split_embed.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ def main() -> None:
291291
# Populate Vector Store
292292
######################################
293293
st.header("Populate Vector Store", divider="red")
294-
existing_vs = state["database_config"][state["user_settings"]["vector_search"]["database"]]["vector_stores"]
294+
existing_vs = state["database_config"][state["user_settings"]["database"]["alias"]]["vector_stores"]
295295
# Mandatory Alias
296296
embed_alias_size, _ = st.columns([0.5, 0.5])
297297
embed_alias_invalid = False

src/client/utils/st_common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ def vector_search_sidebar() -> None:
404404
st.sidebar.subheader("Vector Store", divider="red")
405405
# Create a DataFrame of all database vector storage tables
406406
vs_df = pd.DataFrame(
407-
state.database_config[state.user_settings["vector_search"]["database"]].get("vector_stores")
407+
state["database_config"][state["user_settings"]["database"]["alias"]].get("vector_stores")
408408
)
409409

410410
def vs_reset() -> None:

src/server/utils/testbed.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -323,24 +323,22 @@ def clean(orig_html):
323323
# Main
324324
binds = {"eid": eid}
325325
sql = """
326-
SELECT eid, to_char(evaluated), correctness, settings, rag_report
326+
SELECT eid, to_char(evaluated) as evaluated, correctness, settings, rag_report
327327
FROM oai_evaluations WHERE eid=:eid
328328
ORDER BY evaluated
329329
"""
330330
results = databases.execute_sql(db_conn, sql, binds)
331-
pickled_report = results[0][4].read()
332-
333-
report = pickle.loads(pickled_report)
331+
report = pickle.loads(results[0]["RAG_REPORT"])
334332
full_report = report.to_pandas()
335333
html_report = report.to_html()
336334
by_topic = report.correctness_by_topic()
337335
failures = report.failures
338336

339337
evaluation_results = {
340-
"eid": results[0][0].hex(),
341-
"evaluated": results[0][1],
342-
"correctness": results[0][2],
343-
"settings": results[0][3],
338+
"eid": results[0]["EID"].hex(),
339+
"evaluated": results[0]["EVALUATED"],
340+
"correctness": results[0]["CORRECTNESS"],
341+
"settings": results[0]["SETTINGS"],
344342
"report": full_report.to_dict(),
345343
"correct_by_topic": by_topic.to_dict(),
346344
"failures": failures.to_dict(),

tests/client/content/tools/test_split_embed.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ def mock_get(endpoint=None, **kwargs):
220220
at.session_state.user_settings = {
221221
"client": "test_client",
222222
"oci": {"auth_profile": "DEFAULT"},
223-
"vector_search": {"database": "DEFAULT"},
223+
"database": {"alias": "DEFAULT"},
224224
}
225225

226226
at.session_state.embed_model_enabled = {
@@ -281,7 +281,7 @@ def mock_get(endpoint=None, **kwargs):
281281
at.session_state.user_settings = {
282282
"client": "test_client",
283283
"oci": {"auth_profile": "DEFAULT"},
284-
"vector_search": {"database": "DEFAULT"},
284+
"database": {"alias": "DEFAULT"},
285285
}
286286

287287
at.session_state.embed_model_enabled = {
@@ -342,7 +342,7 @@ def mock_get(endpoint=None, **kwargs):
342342
at.session_state.user_settings = {
343343
"client": "test_client",
344344
"oci": {"auth_profile": "DEFAULT"},
345-
"vector_search": {"database": "DEFAULT"},
345+
"database": {"alias": "DEFAULT"},
346346
}
347347

348348
at.session_state.embed_model_enabled = {
@@ -412,7 +412,7 @@ def mock_get(endpoint=None, **kwargs):
412412
at.session_state.user_settings = {
413413
"client": "test_client",
414414
"oci": {"auth_profile": "DEFAULT"},
415-
"vector_search": {"database": "DEFAULT"},
415+
"database": {"alias": "DEFAULT"},
416416
}
417417
at.session_state.embed_model_enabled = {
418418
"test-model": {"url": "http://test.url", "max_chunk_size": 1000, "enabled": True}

0 commit comments

Comments
 (0)