Skip to content

Commit c0974f4

Browse files
committed
Use the sdk and boot the metrics package
1 parent 5550112 commit c0974f4

File tree

8 files changed

+22
-586
lines changed

8 files changed

+22
-586
lines changed

Gopkg.lock

Lines changed: 7 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Gopkg.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
[[constraint]]
1414
name = "github.com/oracle/oci-go-sdk"
15-
version = "2.7.0"
15+
version = "4.1.0"
1616

1717
[[constraint]]
1818
name = "github.com/pkg/errors"

datasource.go

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ import (
66
"log"
77
"time"
88

9-
"gitlab-odx.oracledx.com/cloudnative/oci-grafana-plugin/metrics"
10-
119
"golang.org/x/net/context"
1210

1311
"github.com/davecgh/go-spew/spew"
@@ -17,6 +15,7 @@ import (
1715
"github.com/oracle/oci-go-sdk/common"
1816
"github.com/oracle/oci-go-sdk/common/auth"
1917
"github.com/oracle/oci-go-sdk/identity"
18+
"github.com/oracle/oci-go-sdk/monitoring"
2019
"github.com/pkg/errors"
2120
)
2221

@@ -26,7 +25,7 @@ var cacheRefreshTime = time.Minute
2625
//OCIDatasource - pulls in data from telemtry/various oci apis
2726
type OCIDatasource struct {
2827
plugin.NetRPCUnsupportedPlugin
29-
metricsClient metrics.TelemetryClient
28+
metricsClient monitoring.MonitoringClient
3029
identityClient identity.IdentityClient
3130
config common.ConfigurationProvider
3231
logger hclog.Logger
@@ -84,7 +83,7 @@ func (o *OCIDatasource) Query(ctx context.Context, tsdbReq *datasource.Datasourc
8483
if err != nil {
8584
return nil, errors.Wrap(err, "broken environment")
8685
}
87-
metricsClient, err := metrics.NewTelemetryClientWithConfigurationProvider(configProvider)
86+
metricsClient, err := monitoring.NewMonitoringClientWithConfigurationProvider(configProvider)
8887
if err != nil {
8988
return nil, errors.New(fmt.Sprint("error with client", spew.Sdump(configProvider), err.Error()))
9089
}
@@ -118,7 +117,7 @@ func (o *OCIDatasource) testResponse(ctx context.Context, tsdbReq *datasource.Da
118117
var ts GrafanaCommonRequest
119118
json.Unmarshal([]byte(tsdbReq.Queries[0].ModelJson), &ts)
120119

121-
listMetrics := metrics.ListMetricsRequest{
120+
listMetrics := monitoring.ListMetricsRequest{
122121
CompartmentId: common.String(ts.TenancyOCID),
123122
}
124123
reg := common.StringToRegion(ts.Region)
@@ -142,7 +141,7 @@ func (o *OCIDatasource) dimensionResponse(ctx context.Context, tsdbReq *datasour
142141
for _, query := range tsdbReq.Queries {
143142
var ts GrafanaSearchRequest
144143
json.Unmarshal([]byte(query.ModelJson), &ts)
145-
reqDetails := metrics.ListMetricsDetails{}
144+
reqDetails := monitoring.ListMetricsDetails{}
146145
reqDetails.Namespace = common.String(ts.Namespace)
147146
reqDetails.Name = common.String(ts.Metric)
148147
items, err := o.searchHelper(ctx, ts.Region, ts.Compartment, reqDetails)
@@ -185,7 +184,7 @@ func (o *OCIDatasource) namespaceResponse(ctx context.Context, tsdbReq *datasour
185184
var ts GrafanaSearchRequest
186185
json.Unmarshal([]byte(query.ModelJson), &ts)
187186

188-
reqDetails := metrics.ListMetricsDetails{}
187+
reqDetails := monitoring.ListMetricsDetails{}
189188
reqDetails.GroupBy = []string{"namespace"}
190189
items, err := o.searchHelper(ctx, ts.Region, ts.Compartment, reqDetails)
191190
if err != nil {
@@ -237,7 +236,7 @@ func (o *OCIDatasource) searchResponse(ctx context.Context, tsdbReq *datasource.
237236
for _, query := range tsdbReq.Queries {
238237
var ts GrafanaSearchRequest
239238
json.Unmarshal([]byte(query.ModelJson), &ts)
240-
reqDetails := metrics.ListMetricsDetails{
239+
reqDetails := monitoring.ListMetricsDetails{
241240
Namespace: common.String(ts.Namespace),
242241
}
243242
items, err := o.searchHelper(ctx, ts.Region, ts.Compartment, reqDetails)
@@ -273,13 +272,13 @@ func (o *OCIDatasource) searchResponse(ctx context.Context, tsdbReq *datasource.
273272

274273
}
275274

276-
func (o *OCIDatasource) searchHelper(ctx context.Context, region, compartment string, metricDetails metrics.ListMetricsDetails) ([]metrics.Metric, error) {
277-
var items []metrics.Metric
275+
func (o *OCIDatasource) searchHelper(ctx context.Context, region, compartment string, metricDetails monitoring.ListMetricsDetails) ([]monitoring.Metric, error) {
276+
var items []monitoring.Metric
278277
var page *string
279278
for {
280279
reg := common.StringToRegion(region)
281280
o.metricsClient.SetRegion(string(reg))
282-
res, err := o.metricsClient.ListMetrics(ctx, metrics.ListMetricsRequest{
281+
res, err := o.metricsClient.ListMetrics(ctx, monitoring.ListMetricsRequest{
283282
CompartmentId: common.String(compartment),
284283
ListMetricsDetails: metricDetails,
285284
Page: page,
@@ -370,7 +369,7 @@ func (o *OCIDatasource) getCompartments(ctx context.Context, rootCompartment str
370369
}
371370

372371
type responseAndQuery struct {
373-
ociRes metrics.SummarizeMetricsDataResponse
372+
ociRes monitoring.SummarizeMetricsDataResponse
374373
query *datasource.Query
375374
err error
376375
}
@@ -387,7 +386,7 @@ func (o *OCIDatasource) queryResponse(ctx context.Context, tsdbReq *datasource.D
387386
start = start.Truncate(time.Millisecond)
388387
end = end.Truncate(time.Millisecond)
389388

390-
req := metrics.SummarizeMetricsDataDetails{
389+
req := monitoring.SummarizeMetricsDataDetails{
391390
Query: common.String(ts.Query),
392391
Namespace: common.String(ts.Namespace),
393392
StartTime: &common.SDKTime{start},
@@ -397,7 +396,7 @@ func (o *OCIDatasource) queryResponse(ctx context.Context, tsdbReq *datasource.D
397396
reg := common.StringToRegion(ts.Region)
398397
o.metricsClient.SetRegion(string(reg))
399398

400-
request := metrics.SummarizeMetricsDataRequest{
399+
request := monitoring.SummarizeMetricsDataRequest{
401400
CompartmentId: common.String(ts.Compartment),
402401
SummarizeMetricsDataDetails: req,
403402
}

dist/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ In order to simplify the installation process, we created detailed guides for yo
2020
* Install Grafana and the Oracle Cloud Infrastructure Data Source for Grafana on a MacOS host using [this document](https://github.com/oracle/oci-grafana-plugin/blob/master/docs/Local%20Installation%20MacOS%20-%20Oracle%20Cloud%20Infrastructure%20Data%20Source%20for%20Grafana.md).
2121
* Install Grafana and the Oracle Cloud Infrastructure Data Source for Grafana on a virtual machine in Oracle Cloud Infrastructure using [this document](https://github.com/oracle/oci-grafana-plugin/blob/master/docs/OCI%20Virtual%20Machine%20Installation%20-%20Oracle%20Cloud%20Infrastructure%20Data%20Source%20for%20Grafana.md).
2222
* Install Grafana and the Oracle Cloud Infrastructure Data Source for Grafana on a virtual machine in Oracle Cloud Infrastructure using Terraform using [this document](https://github.com/oracle/oci-grafana-plugin/blob/master/docs/Terraform-Based%20Installation%20-%20Oracle%20Cloud%20Infrastructure%20Data%20Source%20for%20Grafana.md).
23+
* Install Grafana and the Oracle Cloud Infrastructure Data Source for Grafana on Kubernetes in Oracle Cloud Infrastructure using [this document](https://github.com/oracle/oci-grafana-plugin/blob/master/docs/Oracle%20Kubernetes%20Engine%20Installation%20-%20Oracle%20Cloud%20Infrastructure%20Data%20Source%20for%20Grafana.md)
2324

2425
Once you have the data source installed, configure your datasource with your tenancy OCID, default region, and where you're running the plugin (Oracle Cloud or elsewhere).
2526

metrics/client.go

Lines changed: 0 additions & 141 deletions
This file was deleted.

metrics/client_test.go

Lines changed: 0 additions & 72 deletions
This file was deleted.

0 commit comments

Comments
 (0)