Merge pull request #270 from Rendanic/prlinter

github Actions & Linter

Author: Rendanic

.ansible-lint

@@ -2,12 +2,13 @@
 
 use_default_rules: true
 
-# skip_list:
-
 exclude_paths:
   - .github
   - dbhome-conversion
   - docker
   - plugins/modules
-  - playbooks
+  - playbooks/desupported
   - changelogs
+
+extra_vars:
+  hostgroup: all

.github/workflows/ansible-lint.yml

@@ -4,7 +4,6 @@ name: Ansible Lint
 on:
   pull_request:
     branches:
-      - oc
       - master
   push:
     branches:
@@ -24,6 +23,6 @@ jobs:
         uses: ansible-community/ansible-lint-action@v6.5.2
         with:
           targets: |
+            inventory/*
+            playbooks/*
             roles/*
-            
-          args: ""

.github/workflows/changelog-lint.yml

@@ -3,9 +3,7 @@ name: Test antsibull-changelog lint
 on:
   pull_request:
     branches:
-      - oc
       - master
-      - collection
   push:
     branches:
       - 'pr*'

changelogs/fragments/270-ansible-lint.yml

@@ -0,0 +1,7 @@
+---
+minor_changes:
+  - "ansible-lint: linting and github actions for playbooks and inventory (#270)"
+  - "github actions: antsibull-changelog removed obsolete branches (#270)"
+bugfixes:
+  - "requirements.yml: removed ansible-oracle due to loop in ansible-lint (#270)"
+  - "github actions: ansible-lint: removed args due to deprecation warning (#270)"

playbooks/os.yml

@@ -17,5 +17,5 @@
 
   post_tasks:
     - name: Restart autofs
-      service: name=autofs enabled=yes state=restarted
+      ansible.builtin.service: name=autofs enabled=yes state=restarted
       tags: autofs

playbooks/os_update_reboot.yml

@@ -15,22 +15,22 @@
     - name: yum update yum packages 1st
       ansible.builtin.package:
         # noqa package-latest
-        name: "yum*"
+        name: yum*
         state: latest
       register: yumyumstate
 
     - ansible.builtin.debug: msg="{{ yumyumstate.results }}"
-      # noqa unnamed-task
+    # noqa unnamed-task
 
     - name: Kernel Update with later Reboot
       ansible.builtin.package:
         # noqa package-latest
-        name: "kernel-uek"
+        name: kernel-uek
         state: latest
       register: kernelstate
 
     - ansible.builtin.debug: msg="{{ kernelstate.results }}"
-      # noqa unnamed-task
+    # noqa unnamed-task
 
     - name: yum update
       ansible.builtin.package:
@@ -40,7 +40,7 @@
       register: updatestate
 
     - ansible.builtin.debug: msg="{{ kernelstate.results }}"
-      # noqa unnamed-task
+    # noqa unnamed-task
 
     - name: reboot due to Kernel Update
       # noqa no-handler

playbooks/os_vagrant.yml

@@ -7,16 +7,16 @@
   any_errors_fatal: true
   tasks:
     - name: set new hostname
-      hostname:
+      ansible.builtin.hostname:
         name: "{{ inventory_hostname }}"
 
     - name: Remove /etc/hosts
-      file:
+      ansible.builtin.file:
         path: /etc/hosts
         state: absent
 
     - name: Update /etc/hosts
-      blockinfile:
+      ansible.builtin.blockinfile:
         path: /etc/hosts
         mode: 0644
         create: true

requirements.yml

@@ -2,5 +2,3 @@
 collections:
   - name: devsec.hardening
     version: 8.2.0
-  - name: opitzconsulting.ansible_oracle
-    version: 3.0.0