add nolog attribute to password fields

Author: bartowl

changelogs/fragments/375_nolog_modules.yml

@@ -0,0 +1,10 @@
+---
+security_fixes:
+  - "oracle_awr: added no_log attribute to password fields (oravirt#375)"
+  - "oracle_facts: added no_log attribute to password fields (oravirt#375)"
+  - "oracle_job: added no_log attribute to password fields (oravirt#375)"
+  - "oracle_jobclass: added no_log attribute to password fields (oravirt#375)"
+  - "oracle_jobschedule: added no_log attribute to password fields (oravirt#375)"
+  - "oracle_jobwindow: added no_log attribute to password fields (oravirt#375)"
+  - "oracle_ldapuser: added no_log attribute to password fields (oravirt#375)"
+  - "oracle_rsrc_consgroup: added no_log attribute to password fields (oravirt#375)"

plugins/modules/oracle_awr

@@ -112,7 +112,7 @@ def main():
             port          = dict(default=1521, type='int'),
             service_name  = dict(required=True),
             user          = dict(required=False),
-            password      = dict(required=False),
+            password      = dict(required=False, no_log=True),
             mode          = dict(default='normal', choices=["normal","sysdba"]),
             snapshot_interval_min = dict(default=60, type='int', aliases=['interval']),
             snapshot_retention_days = dict(default=8, type='int', aliases=['retention'])

plugins/modules/oracle_facts

@@ -101,7 +101,7 @@ def main():
             port          = dict(default=1521, type='int'),
             service_name  = dict(required=True),
             user          = dict(required=False),
-            password      = dict(required=False),
+            password      = dict(required=False, no_log=True),
             mode          = dict(default='normal', choices=["normal","sysdba"])
         ),
         supports_check_mode=True

plugins/modules/oracle_job

@@ -366,7 +366,7 @@ def main():
             port          = dict(default=1521, type='int'),
             service_name  = dict(required=True),
             user          = dict(required=False),
-            password      = dict(required=False),
+            password      = dict(required=False, no_log=True),
             mode          = dict(default='normal', choices=["normal","sysdba"]),
             state         = dict(default="present", choices=["present", "absent"]),
             enabled       = dict(default=True, type='bool'),

plugins/modules/oracle_jobclass

@@ -132,7 +132,7 @@ def main():
             port          = dict(default=1521, type='int'),
             service_name  = dict(required=True),
             user          = dict(required=False),
-            password      = dict(required=False),
+            password      = dict(required=False, no_log=True),
             mode          = dict(default='normal', choices=["normal","sysdba"]),
             state         = dict(default="present", choices=["present", "absent"]),
             name          = dict(required=True),

plugins/modules/oracle_jobschedule

@@ -127,7 +127,7 @@ def main():
             port          = dict(default=1521, type='int'),
             service_name  = dict(required=True),
             user          = dict(required=False),
-            password      = dict(required=False),
+            password      = dict(required=False, no_log=True),
             mode          = dict(default='normal', choices=["normal","sysdba"]),
             state         = dict(default="present", choices=["present", "absent"]),
             name          = dict(required=True),

plugins/modules/oracle_jobwindow

@@ -146,7 +146,7 @@ def main():
             port          = dict(default=1521, type='int'),
             service_name  = dict(required=True),
             user          = dict(required=False),
-            password      = dict(required=False),
+            password      = dict(required=False, no_log=True),
             mode          = dict(default='normal', choices=["normal","sysdba"]),
             state         = dict(default="enabled", choices=["absent","enabled","disabled"]),
             name          = dict(required=True, aliases=["window_name"]),

plugins/modules/oracle_ldapuser

@@ -220,17 +220,17 @@ def main():
             port          = dict(default=1521, type='int'),
             service_name  = dict(required=True),
             user          = dict(required=False),
-            password      = dict(required=False),
+            password      = dict(required=False, no_log=True),
             mode          = dict(default='normal', choices=["normal","sysdba"]),
             user_default_tablespace = dict(default='USERS'),
             user_quota_on_default_tbs_mb = dict(default=None, type='int'), # None is unlimited
             user_temp_tablespace = dict(default='TEMP'),
             user_profile  = dict(default='LDAP_USER'),
-            user_default_password = dict(default=None), # None means EXTERNAL
+            user_default_password = dict(default=None, no_log=True), # None means EXTERNAL
             user_grants   = dict(default=['create session'], type='list'),
             ldap_connect  = dict(required=True),
             ldap_binddn   = dict(required=True),
-            ldap_bindpassword = dict(required=True),
+            ldap_bindpassword = dict(required=True, no_log=True),
             ldap_user_basedn  = dict(required=True),
             ldap_user_subtree = dict(default=True, type='bool'),
             ldap_user_filter  = dict(default='(objectClass=user)'),

plugins/modules/oracle_rsrc_consgroup

@@ -267,7 +267,7 @@ def main():
             port          = dict(default=1521, type='int'),
             service_name  = dict(required=True),
             user          = dict(required=False),
-            password      = dict(required=False),
+            password      = dict(required=False, no_log=True),
             mode          = dict(default='normal', choices=["normal","sysdba"]),
             state         = dict(default="present", choices=["present", "absent"]),
             name          = dict(required=True),