oradb_manage_-roles: check state from oracledb_facts during execution

Author: Rendanic

changelogs/fragments/oradb_facts2.yml

@@ -0,0 +1,12 @@
+---
+minor_changes:
+  - "oradb_manage_grants: check state from oracledb_facts during execution (oravirt#417)"
+  - "oradb_manage_parameters: check state from oracledb_facts during execution (oravirt#417)"
+  - "oradb_manage_pdb: check state from oracledb_facts during execution (oravirt#417)"
+  - "oradb_manage_profiles: check state from oracledb_facts during execution (oravirt#417)"
+  - "oradb_manage_redo: check state from oracledb_facts during execution (oravirt#417)"
+  - "oradb_manage_roles: check state from oracledb_facts during execution (oravirt#417)"
+  - "oradb_manage_services: check state from oracledb_facts during execution (oravirt#417)"
+  - "oradb_manage_statspack: check state from oracledb_facts during execution (oravirt#417)"
+  - "oradb_manage_tablespace: check state from oracledb_facts during execution (oravirt#417)"
+  - "oradb_manage_users: check state from oracledb_facts during execution (oravirt#417)"

roles/oradb_manage_grants/tasks/main.yml

@@ -23,17 +23,20 @@
   when:
     - oracle_databases is defined
     - odb.0.state == 'present'
+    - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
     - (odb.1.grants is defined or odb.1.object_privs is defined)
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
   become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: odb
     label: >-
+      db_name: {{ odb.0.oracle_db_name | default('') }}
       service: {{ _db_service_name }}:{{ _listener_port_cdb }}
       role: {{ odb.1.name | default('') }}
       grants: {{ odb.1.grants | default('') }}
       state: {{ odb.1.state | default('') }}
+      db_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
   tags:
     - users
     - grants
@@ -62,6 +65,7 @@
     - oracle_pdbs is defined
     - opdb.0 is defined
     - opdb.0.state == 'present'
+    - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
     - (opdb.1.grants is defined or opdb.1.object_privs is defined)
     - >-
       oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)
@@ -72,11 +76,13 @@
   loop_control:
     loop_var: opdb
     label: >-
+      cdb: {{ opdb.0.cdb | default('') }}
       port: {{ _listener_port_pdb }},
       pdb: {{ opdb.0.pdb_name }},
       role: {{ opdb.1.name | default('none') }},
       grants: {{ opdb.1.grants | default(omit) }},
       state: {{ opdb.1.state }}
+      cdb_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
   tags:
     - users
     - grants2
@@ -106,17 +112,20 @@
   when:
     - oracle_databases is defined
     - odb.0.state == 'present'
+    - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
     - (odb.1.grants is defined or odb.1.object_privs is defined)
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
   become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: odb
     label: >-
+      db_name: {{ odb.0.oracle_db_name | default('') }}
       service: {{ _db_service_name }}:{{ _listener_port_cdb }}
       schema: {{ odb.1.schema | default('') }}
       grants: {{ odb.1.grants | default('') }}
       state: {{ odb.1.state | default('') }}"
+      db_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
   tags:
     - users
     - grants
@@ -145,6 +154,7 @@
     - oracle_pdbs is defined
     - opdb.0 is defined
     - opdb.0.state == 'present'
+    - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
     - (opdb.1.grants is defined or opdb.1.object_privs is defined)
     - >-
       oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)
@@ -155,11 +165,13 @@
   loop_control:
     loop_var: opdb
     label: >-
+      cdb: {{ opdb.0.cdb | default('') }}
       port: {{ _listener_port_pdb }},
       pdb: {{ opdb.0.pdb_name }},
       schema: {{ opdb.1.schema | default('none') }},
       grants: {{ opdb.1.grants | default(omit) }},
       state: {{ opdb.1.state }}
+      cdb_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
   tags:
     - users
     - grants4

roles/oradb_manage_parameters/tasks/main.yml

@@ -23,18 +23,21 @@
   when:
     - oracle_databases is defined
     - odb.0.state == 'present'
+    - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
     - odb.1 is defined
   become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: odb
     label: >-
+      db_name: {{ odb.0.oracle_db_name | default('') }}
       port: {{ _listener_port_cdb }}
       service: {{ _db_service_name }}
       name: {{ odb.1.name }}
       value: {{ odb.1.value }}
       scope: {{ odb.1.scope | default ('both') }}
       state:{{ odb.1.state }}
+      db_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
   register: param_change_cdb
   tags:
     - initparams
@@ -63,6 +66,7 @@
   when:
     - oracle_pdbs is defined
     - opdb.0.state == 'present'
+    - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
     - opdb.1 is defined
     - >-
       oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)
@@ -72,12 +76,14 @@
   loop_control:
     loop_var: opdb
     label: >-
+      cdb: {{ opdb.0.cdb | default('') }}
       port: {{ _listener_port_pdb }}
       service: {{ opdb.0.pdb_name }}
       name: {{ opdb.1.name }}
       value: {{ opdb.1.value }}
       scope: {{ opdb.1.scope | default ('both') }}
       state:{{ opdb.1.state }}"
+      cdb_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
   register: param_change_pdb
   tags:
     - initparams
@@ -99,12 +105,14 @@
     - ""  # dummy to force odb.0 instead of item.
   when:
     - odb.0.restart_spparameter_changed | default(true)
+    - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
     - restart_spparameter_changed
   loop_control:
     loop_var: odb
     label: >-
-      dbname: {{ odb.0.oracle_db_name | d('') }}
-      - {{ param_change_reboot.msg | default('restart_spparameter_changed is false') }}"
+      db_name: {{ odb.0.oracle_db_name | d('') }}
+      db_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
+      parameter: {{ param_change_reboot.msg | default('restart_spparameter_changed is false') }}"
   become: true
   become_user: "{{ oracle_user }}"
   register: param_change_reboot

roles/oradb_manage_pdb/tasks/main.yml

@@ -36,6 +36,7 @@
           CDB: {{ odb[1].cdb | default('') }},
           PDB: {{ odb[1].pdb_name | default('') }},
           state: {{ odb[1].state | default('') }}
+          db_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
         loop_var: odb
       when:
         - oracle_databases is defined
@@ -45,3 +46,4 @@
         - odb[0].state|upper == 'PRESENT'
         - odb[1].cdb == odb[0].oracle_db_name
         - odb[0].is_container
+        - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'

roles/oradb_manage_profiles/tasks/main.yml

@@ -30,13 +30,16 @@
       loop_control:
         loop_var: odb
         label: >-
+          db_name: {{ odb.0.oracle_db_name | default('') }}
           service: {{ _db_service_name }}:{{ _listener_port_cdb }}
           db_name: {{ odb.0.oracle_db_name }}
           Profile: {{ odb.1.name }}
           attributes: {{ odb.1.attributes }}
+          db_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
       when:
         - oracle_databases is defined
         - odb.0.state == 'present'
+        - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
         - odb.1 is defined
       run_once: "{{ _oraswgi_meta_configure_cluster }}"
       become: true
@@ -83,10 +86,12 @@
           PDB: {{ opdb.0.pdb_name }}
           Profile: {{ opdb.1.name }}
           attributes: {{ opdb.1.attributes }}
+          cdb_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
       when:
         - oracle_pdbs is defined
         - opdb.0 is defined
         - opdb.0.state == 'present'
+        - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
         - opdb.1 is defined
         - >-
           oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)

roles/oradb_manage_redo/tasks/main.yml

@@ -27,11 +27,14 @@
         - odb.redolog_size is defined
         - odb.redolog_groups is defined
         - odb.state == 'present'
+        - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
       become_user: "{{ oracle_user }}"
       become: true
       loop_control:
         loop_var: odb
         label: >-
+          db_name: {{ odb.oracle_db_name | default('') }}
           service: {{ _db_service_name }}:{{ _listener_port_cdb }}
-          groups: {{ odb.redolog_groups | default('') }}
-          size: {{ odb.redolog_size | default('') }}
+          groups: {{ odb.redolog_groups }}
+          size: {{ odb.redolog_size }}
+          db_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}

roles/oradb_manage_roles/tasks/main.yml

@@ -19,14 +19,17 @@
   when:
     - oracle_databases is defined
     - odb.0.state == 'present'
+    - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
     - odb.1 is defined
   loop_control:
     loop_var: odb
     label: >-
+      db_name: {{ odb.0.oracle_db_name | default('') }}
       port {{ _listener_port_cdb }}
       service {{ _db_service_name }}
       role {{ odb.1.name }}
       state {{ odb.1.state }}
+      db_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
   become: true
   become_user: "{{ oracle_user }}"
@@ -52,17 +55,20 @@
     - oracle_pdbs is defined
     - opdb.0 is defined
     - opdb.0.state == 'present'
+    - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
     - opdb.1 is defined
     - >-
       oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)
       | map(attribute='state') | list | first == 'present'
   loop_control:
     loop_var: opdb
     label: >-
+      cdb: {{ opdb.0.cdb | default('') }}
       port: {{ _listener_port_pdb }},
       service: {{ _db_service_pdb }},
       role: {{ opdb.1.name }},
       state: {{ opdb.1.state }}
+      cdb_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
   become: true
   become_user: "{{ oracle_user }}"

roles/oradb_manage_services/tasks/main.yml

@@ -27,9 +27,11 @@
     label: >-
       database_name {{ odb.0.oracle_db_name | default('') }}
       name {{ odb.1.name | default('') }}
+      db_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
   when:
     - oracle_databases is defined
     - odb.0.state == 'present'
+    - oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
     - odb.1 is defined
     - (odb.1.state == 'present' or odb.1.state == 'started')
   become: true