oradb_manage_db: improved listener reload/start + molecule tags

Author: Rendanic

roles/oradb_manage_db/README.md

@@ -67,16 +67,16 @@ oracle_gi_cluster_type: STANDARD
 
 **_create_cdb,dotprofile_db_**
 
-**_create_db,dbca,customdbcatemplate,dotprofile_db,listener2_**
+**_create_db_**
 
-**_create_db,dbcatemplate_**
+**_create_db,dbca,customdbcatemplate,dotprofile_db,listener2_**
 
 **_create_db,dotprofile_db_**
 
-**_create_db,manage_db,dbca_**
-
 **_customdbcatemplate_**
 
+**_dbca_**
+
 **_dbcatemplate_**
 
 **_listener_**
@@ -85,6 +85,8 @@ oracle_gi_cluster_type: STANDARD
 
 **_listener_install_**
 
+**_manage_db_**
+
 **_molecule-idempotence-notest_**
 
 **_odb_assert_**

roles/oradb_manage_db/tasks/listener_details.yml

@@ -1,5 +1,6 @@
 ---
-- ansible.builtin.debug:  # noqa name[missing]
+- name: ORACLE_BASE_HOME
+  ansible.builtin.debug:
     msg: "ORACLE_BASE_HOME {{ _oradb_manage_db_listener_home_config }}"
   tags: listener2
 
@@ -19,20 +20,23 @@
 
 # Don't try to stop the listener at this point
 # => Restart of role will fail at create/manage database due to TNS-12514
-- name: listener | Start Listener - ignore errors for running Listener
-  ansible.builtin.shell: "export PATH=${ORACLE_HOME}/bin:${PATH}; lsnrctl start {{ lsnrinst.listener_name }} /dev/null; exit 0"
-  # noqa no-changed-when
-  environment: "{{ oracle_env_lsnrctl }}"
-  become_user: "{{ oracle_user }}"
-  tags:
-    - listener2
-    - molecule-idempotence-notest
+- name: listener | Start/Reload Listener  # noqa no-changed-when
+  ansible.builtin.shell: |
+    #!/usr/bin/env bash
+    set -eu
+    set -o pipefail
+    LSNRCTL="${ORACLE_HOME}/bin/lsnrctl"
 
-- name: listener | Reload Listener
-  ansible.builtin.shell: "export PATH=${ORACLE_HOME}/bin:${PATH}; lsnrctl reload {{ lsnrinst.listener_name }}"
-  # noqa no-changed-when
+    if "${LSNRCTL}" status {{ lsnrinst.listener_name }} 2>/dev/null ; then
+      # Reload running listener
+      "${LSNRCTL}" reload {{ lsnrinst.listener_name }} > /dev/null
+    else
+      # Start listener
+      "${LSNRCTL}" start {{ lsnrinst.listener_name }} > /dev/null
+    fi
   environment: "{{ oracle_env_lsnrctl }}"
   become_user: "{{ oracle_user }}"
+  become: true
   tags:
-    - listener2
     - molecule-idempotence-notest
+    - listener2

roles/oradb_manage_db/tasks/manage-db.yml

@@ -80,14 +80,16 @@
     dbh: "{{ odb }}"
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
   when: odb.state == 'present'
-  tags: create_db,dbcatemplate
+  tags:
+    - create_db
+    - dbcatemplate
+    - molecule-idempotence-notest
 
 # show debug task for environments with display_skipped_hosts = false
 - name: manage_db | Start create/manage database
   ansible.builtin.debug:
     msg: "Executing ansible_oracle.oracle_db. This takes some time..."
   when: odb.state == 'present'
-  tags: molecule-idempotence-notest
 
 - name: manage_db | create/manage database
   opitzconsulting.ansible_oracle.oracle_db:
@@ -109,7 +111,11 @@
   become_user: "{{ oracle_user }}"
   when: odb.state == 'present'
   register: dbca_create
-  tags: create_db,manage_db,dbca
+  tags:
+    - molecule-idempotence-notest
+    - create_db
+    - manage_db
+    - dbca
 
 - name: manage_db | Customize oratab for autostart
   ansible.builtin.lineinfile: