oradb_manage_db: more asserts + molecule

Author: Rendanic

roles/oradb_manage_db/README.md

@@ -79,14 +79,16 @@ oracle_gi_cluster_type: STANDARD
 
 **_dbcatemplate_**
 
-**_dbh_assert_**
-
 **_listener_**
 
 **_listener2_**
 
 **_listener_install_**
 
+**_molecule-idempotence-notest_**
+
+**_odb_assert_**
+
 **_psout_**
 
 **_remove_db,dbca_**

roles/oradb_manage_db/tasks/assert.yml

@@ -4,14 +4,33 @@
   ansible.builtin.assert:
     quiet: true
     that:
-      - dbh.oracle_db_name is defined
-      - dbh.home in db_homes_config
-      - dbh.storage_type is defined
-      - db_version != ""
-      - dbh.oracle_db_type is defined
+      - odb.oracle_db_name is defined
+      - odb.home in db_homes_config
+      - odb.state is defined
+      - odb.storage_type is defined
+      - odb.oracle_db_type is defined
   with_items: "{{ oracle_databases }}"
   register: assert1
   loop_control:
-    loop_var: dbh
-    label: "{{ dbh.oracle_db_name | default('') }}"
-  tags: dbh_assert
+    loop_var: odb
+    label: "{{ odb.oracle_db_name | default('') }}"
+  tags: odb_assert
+
+# a configured listener_namein oracle_databases
+# needs a configured listener in inventory!
+- name: assert oracle_databases listener configuration
+  ansible.builtin.assert:
+    quiet: true
+    fail_msg: "Missing element with listener_name in listener_installed!"
+    that:
+      - listener_installed | default([])
+          | selectattr('listener_name', 'match', odb.listener_name)
+          | list | length == 1
+  with_items: "{{ oracle_databases | selectattr('listener_name', 'defined') }}"
+  register: assert2
+  loop_control:
+    loop_var: odb
+    label: >-
+      oracle_db_name: {{ odb.oracle_db_name | default('') }}
+      listener_name: {{ odb.listener_name | default('') }}
+  tags: odb_assert

roles/oradb_manage_db/tasks/listener_details.yml

@@ -24,11 +24,15 @@
   # noqa no-changed-when
   environment: "{{ oracle_env_lsnrctl }}"
   become_user: "{{ oracle_user }}"
-  tags: listener2
+  tags:
+    - listener2
+    - molecule-idempotence-notest
 
 - name: listener | Reload Listener
   ansible.builtin.shell: "export PATH=${ORACLE_HOME}/bin:${PATH}; lsnrctl reload {{ lsnrinst.listener_name }}"
   # noqa no-changed-when
   environment: "{{ oracle_env_lsnrctl }}"
   become_user: "{{ oracle_user }}"
-  tags: listener2
+  tags:
+    - listener2
+    - molecule-idempotence-notest

roles/oradb_manage_db/tasks/manage-db.yml

@@ -87,6 +87,7 @@
   ansible.builtin.debug:
     msg: "Executing ansible_oracle.oracle_db. This takes some time..."
   when: odb.state == 'present'
+  tags: molecule-idempotence-notest
 
 - name: manage_db | create/manage database
   opitzconsulting.ansible_oracle.oracle_db:
@@ -104,6 +105,7 @@
     output: verbose
     state: "{{ odb.state }}"
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
+  become: true
   become_user: "{{ oracle_user }}"
   when: odb.state == 'present'
   register: dbca_create