oraswgi_install: ansible-lint

Author: Rendanic

roles/oraswgi_install/defaults/main.yml

@@ -69,7 +69,7 @@ oracle_grid_responsefile: "grid-{{ oracle_cluster_name }}.rsp"   # Name of respo
 default_gipass: "{% if oracle_password is defined %}{{ oracle_password }}{% else %}Oracle123{% endif %}"
 
 # The check for the old passwords are there for backwards compatibility and only temporary, will be removed
-sysasmpassword: "{% if oracle_password is defined %}{{ oracle_password }}{% else %}Oracle123{% endif%}"
+sysasmpassword: "{% if oracle_password is defined %}{{ oracle_password }}{% else %}Oracle123{% endif %}"
 
 # The check for the old passwords are there for backwards compatibility and only temporary, will be removed
 asmmonitorpassword: "{% if oracle_password is defined %}{{ oracle_password }}{% else %}Oracle123{% endif %}"
@@ -89,8 +89,8 @@ oracle_ic_net: 3.3.3.{{ ansible_all_ipv4_addresses[0].split(".")[-1] }}
 oracle_asm_init_dg: crs
 device_persistence: asmlib
 oracle_asm_disk_string: ORCL:*
-cvuqdisk_rpm: "{%- if oracle_install_version_gi > '12.1.0.2' -%}cvuqdisk-1.0.10-1.rpm
-               {%- else -%}cvuqdisk-1.0.9-1.rpm
+cvuqdisk_rpm: "{%- if oracle_install_version_gi > '12.1.0.2' -%}cvuqdisk-1.0.10-1.rpm\
+               {%- else -%}cvuqdisk-1.0.9-1.rpm\
                {%- endif -%}"
 
 oracle_cluster_name: "{{ hostgroup }}"      # Name of the cluster when setting up Clustered Grid Infrastructure
@@ -117,11 +117,11 @@ opatcharchive: "{{ oracle_stage_install }}/{{ oracle_install_version_gi }}/
                 {%- for opatchfile in oracle_opatch_patch if opatchfile['version']==oracle_install_version_gi -%}{{ opatchfile['filename'] }}
                 {%- endfor -%}"
 
-oracle_gi_image: "{%- if oracle_sw_copy %}{{ oracle_stage }}
-                {%- else %}{{ oracle_stage_remote }}
-                {%- endif %}
-                {%- if oracle_install_image_gi is defined %}/{{ oracle_install_image_gi }}
-                {%- else %}//{{ item.filename }}
+oracle_gi_image: "{%- if oracle_sw_copy %}{{ oracle_stage }}\
+                {%- else %}{{ oracle_stage_remote }}\
+                {%- endif %}\
+                {%- if oracle_install_image_gi is defined %}/{{ oracle_install_image_gi }}\
+                {%- else %}//{{ item.filename }}\
                 {%- endif %}"
 
 oracle_sw_image_gi:                                              # Files containing the installation media for Grid Infrastructure

roles/oraswgi_install/tasks/11.2.0.3.yml

@@ -11,7 +11,7 @@
   become_user: "{{ grid_install_user }}"
   tags:
     - oragridswunpack
-  when: oracle_home_gi not in checkgiinstall.stdout and oracle_install_version_gi  == item.version and oracle_sw_copy and oracle_sw_unpack
+  when: oracle_home_gi not in checkgiinstall.stdout and oracle_install_version_gi == item.version and oracle_sw_copy and oracle_sw_unpack
 
 - name: install_home_gi | Extract files to stage-area (GI) (from remote location)
   ansible.builtin.unarchive:
@@ -97,7 +97,7 @@
   ansible.builtin.shell: "sleep {{ item.0 * 60 }}; {{ oracle_home_gi }}/root.sh"
   # noqa command-instead-of-shell
   become: true
-  with_indexed_items: "{{ groups[hostgroup]  }}"
+  with_indexed_items: "{{ groups[hostgroup] }}"
   tags:
     - runroot
   # when: oracle_home_gi not in checkgiinstall.stdout  and inventory_hostname == item.1
@@ -121,7 +121,7 @@
   run_once: "{{ configure_cluster }}"
   tags:
     - responsefileconfigtool
-  when: run_configtoolallcommand  and oracle_home_gi not in checkgiinstall.stdout
+  when: run_configtoolallcommand and oracle_home_gi not in checkgiinstall.stdout
 
 - name: install_home_gi | Run configToolAllCommands
   ansible.builtin.shell: "{{ oracle_home_gi }}/cfgtoollogs/configToolAllCommands RESPONSE_FILE={{ oracle_rsp_stage }}/configtoolallcommands.rsp"

roles/oraswgi_install/tasks/11.2.0.4.yml

@@ -11,7 +11,7 @@
   become_user: "{{ grid_install_user }}"
   tags:
     - oragridswunpack
-  when: oracle_home_gi not in checkgiinstall.stdout and oracle_install_version_gi  == item.version and oracle_sw_copy and oracle_sw_unpack
+  when: oracle_home_gi not in checkgiinstall.stdout and oracle_install_version_gi == item.version and oracle_sw_copy and oracle_sw_unpack
 
 - name: install_home_gi | Extract files to stage-area (GI) (from remote location)
   ansible.builtin.unarchive:
@@ -119,7 +119,7 @@
   run_once: "{{ configure_cluster }}"
   tags:
     - responsefileconfigtool
-  when: run_configtoolallcommand  and oracle_home_gi not in checkgiinstall.stdout
+  when: run_configtoolallcommand and oracle_home_gi not in checkgiinstall.stdout
 
 - name: install_home_gi | Run configToolAllCommands
   ansible.builtin.shell: "{{ oracle_home_gi }}/cfgtoollogs/configToolAllCommands RESPONSE_FILE={{ oracle_rsp_stage }}/configtoolallcommands.rsp"

roles/oraswgi_install/tasks/12.1.0.1.yml

@@ -16,7 +16,7 @@
   become_user: "{{ grid_install_user }}"
   tags:
     - oragridswunpack
-  when: oracle_home_gi not in checkgiinstall.stdout and  oracle_install_version_gi == item.version and not oracle_sw_copy and oracle_sw_unpack
+  when: oracle_home_gi not in checkgiinstall.stdout and oracle_install_version_gi == item.version and not oracle_sw_copy and oracle_sw_unpack
 
 - name: install_home_gi | Install cvuqdisk rpm
   # noqa ignore-errors
@@ -111,7 +111,7 @@
   tags:
     - responsefileconfigtool
   run_once: "{{ configure_cluster }}"
-  when: run_configtoolallcommand  and oracle_home_gi not in checkgiinstall.stdout
+  when: run_configtoolallcommand and oracle_home_gi not in checkgiinstall.stdout
 
 - name: install_home_gi | Run configToolAllCommands
   ansible.builtin.shell: "{{ oracle_home_gi }}/cfgtoollogs/configToolAllCommands RESPONSE_FILE={{ oracle_rsp_stage }}/configtoolallcommands.rsp"

roles/oraswgi_install/tasks/12.1.0.2.yml

@@ -121,7 +121,7 @@
   run_once: "{{ configure_cluster }}"
   tags:
     - responsefileconfigtool
-  when: run_configtoolallcommand  and oracle_home_gi not in checkgiinstall.stdout
+  when: run_configtoolallcommand and oracle_home_gi not in checkgiinstall.stdout
 
 - name: install_home_gi | Run configToolAllCommands
   ansible.builtin.shell: "{{ oracle_home_gi }}/cfgtoollogs/configToolAllCommands RESPONSE_FILE={{ oracle_rsp_stage }}/configtoolallcommands.rsp"

roles/oraswgi_install/tasks/18.3.0.0.yml

@@ -103,7 +103,7 @@
     - oragridinstall
   when: oracle_home_gi not in checkgiinstall.stdout  # and oracle_sw_unpack
   register: giinstall
-  failed_when: giinstall.rc not in [0,6]
+  failed_when: giinstall.rc = not in [0, 6]
 
 - ansible.builtin.debug: var=giinstall.stdout_lines
   # noqa unnamed-task

roles/oraswgi_install/tasks/19.3.0.0.yml

@@ -1,13 +1,18 @@
 ---
-- block:
+- name: install_home_gi
+  tags:
+    - oragridswunpack
+  when:
+    - oracle_home_gi not in checkgiinstall.stdout
+  block:
     - ansible.builtin.debug: msg="install_home_gi | Start Extract files to ORACLE_HOME (gi)"  # noqa unnamed-task
       run_once: "{{ configure_cluster }}"
 
     - name: install_home_gi | Extract files to ORACLE_HOME (gi)
       ansible.builtin.unarchive: src={{ oracle_gi_image }}  dest={{ oracle_home_gi }} copy=no
       with_items: "{{ oracle_sw_image_gi }}"
       loop_control:
-        label: "{{ oracle_gi_image | default ('') }}"
+        label: "{{ oracle_gi_image | default('') }}"
       args:
         creates: "{{ oracle_home_gi }}/root.sh"
       become: true
@@ -16,11 +21,6 @@
       when:
         - oracle_install_version_gi == item.version
 
-  tags:
-    - oragridswunpack
-  when:
-    - oracle_home_gi not in checkgiinstall.stdout
-
 # Check for an existing GRID_HOME before reinstallation of OPatch
 - name: install_home_gi | Check for file GridSetup.sh
   no_log: true
@@ -42,7 +42,12 @@
   when: configure_cluster
   tags: cvuqdisk
 
-- block:  # noqa unnamed-task when: configure_cluster
+- name: When configure_cluster
+  when:
+    - configure_cluster
+    - hostvars[cluster_master]['statcvuqdisk']['stat']['exists']
+  tags: cvuqdisk
+  block:
 
     # synchronize didn't work on all environments...
     # => fetch to ansible controller
@@ -59,7 +64,7 @@
 
     - name: install_home_gi | copy cvuqdisk to cluster nodes
       ansible.builtin.copy:
-        src: "/tmp/{{ cluster_master  }}/{{ oracle_home_gi }}/cv/rpm/{{ cvuqdisk_rpm }}"
+        src: "/tmp/{{ cluster_master }}/{{ oracle_home_gi }}/cv/rpm/{{ cvuqdisk_rpm }}"
         dest: "{{ oracle_rsp_stage }}/{{ cvuqdisk_rpm }}"
         mode: 0644
       tags: cvuqdisk
@@ -71,11 +76,6 @@
         disable_gpg_check: true
       tags: cvuqdisk
 
-  when:
-    - configure_cluster
-    - hostvars[cluster_master]['statcvuqdisk']['stat']['exists']
-  tags: cvuqdisk
-
 - name: install_home_gi | Setup response file for install (GI)
   ansible.builtin.template:
     src=grid-install.rsp.{{ oracle_install_version_gi }}.j2
@@ -93,7 +93,9 @@
   when:
     - item.diskgroup == oracle_asm_init_dg
 
-- block:  # when: oracle_home_gi not in checkgiinstall.stdout
+- name: ""
+  when: oracle_home_gi not in checkgiinstall.stdout
+  block:  # when: oracle_home_gi not in checkgiinstall.stdout
 
     - include_tasks: runcluvfy.yml
       when:
@@ -119,20 +121,21 @@
       tags:
         - oragridinstall
       register: giinstall
-      failed_when: giinstall.rc not in [0,6]
+      failed_when: giinstall.rc = not in [0, 6]
 
     - ansible.builtin.debug: var=giinstall.stdout_lines  # noqa unnamed-task
       run_once: "{{ configure_cluster }}"
       when: giinstall.stdout_lines is defined
 
-  when: oracle_home_gi not in checkgiinstall.stdout
-
 - name: install_home_gi | include role oraswgi_manage_patches
   ansible.builtin.include_role:
     name: oraswgi_manage_patches
   when: patch_before_rootsh and apply_patches_gi
 
-- block:  # when: oracle_home_gi not in checkgiinstall.stdout
+- name: ""
+  when:
+    - oracle_home_gi not in checkgiinstall.stdout
+  block:  # when: oracle_home_gi not in checkgiinstall.stdout
     - name: install_home_gi | Run oraInstroot script after installation
       ansible.builtin.command: "{{ oracle_inventory_loc }}/orainstRoot.sh"
       # noqa no-changed-when
@@ -191,6 +194,3 @@
         - run_configtoolallcommand
       ignore_errors: true
       register: configtool
-
-  when:
-    - oracle_home_gi not in checkgiinstall.stdout

roles/oraswgi_install/tasks/21.3.0.0.yml

@@ -1,13 +1,18 @@
 ---
-- block:
+- name: install_home_gi
+  tags:
+    - oragridswunpack
+  when:
+    - oracle_home_gi not in checkgiinstall.stdout
+  block:
     - ansible.builtin.debug: msg="install_home_gi | Start Extract files to ORACLE_HOME (gi)"  # noqa unnamed-task
       run_once: "{{ configure_cluster }}"
 
     - name: install_home_gi | Extract files to ORACLE_HOME (gi)
       ansible.builtin.unarchive: src={{ oracle_gi_image }}  dest={{ oracle_home_gi }} copy=no
       with_items: "{{ oracle_sw_image_gi }}"
       loop_control:
-        label: "{{ oracle_gi_image | default ('') }}"
+        label: "{{ oracle_gi_image | default('') }}"
       args:
         creates: "{{ oracle_home_gi }}/root.sh"
       become: true
@@ -16,11 +21,6 @@
       when:
         - oracle_install_version_gi == item.version
 
-  tags:
-    - oragridswunpack
-  when:
-    - oracle_home_gi not in checkgiinstall.stdout
-
 # Check for an existing GRID_HOME before reinstallation of OPatch
 - name: install_home_gi | Check for file GridSetup.sh
   no_log: true
@@ -42,7 +42,12 @@
   when: configure_cluster
   tags: cvuqdisk
 
-- block:  # noqa unnamed-task when: configure_cluster
+- name: install_home_gi
+  when:
+    - configure_cluster
+    - hostvars[cluster_master]['statcvuqdisk']['stat']['exists']
+  tags: cvuqdisk
+  block:
 
     # synchronize didn't work on all environments...
     # => fetch to ansible controller
@@ -59,7 +64,7 @@
 
     - name: install_home_gi | copy cvuqdisk to cluster nodes
       ansible.builtin.copy:
-        src: "/tmp/{{ cluster_master  }}/{{ oracle_home_gi }}/cv/rpm/{{ cvuqdisk_rpm }}"
+        src: "/tmp/{{ cluster_master }}/{{ oracle_home_gi }}/cv/rpm/{{ cvuqdisk_rpm }}"
         dest: "{{ oracle_rsp_stage }}/{{ cvuqdisk_rpm }}"
         mode: 0644
       tags: cvuqdisk
@@ -71,11 +76,6 @@
         disable_gpg_check: true
       tags: cvuqdisk
 
-  when:
-    - configure_cluster
-    - hostvars[cluster_master]['statcvuqdisk']['stat']['exists']
-  tags: cvuqdisk
-
 - name: install_home_gi | Setup response file for install (GI)
   ansible.builtin.template:
     src=grid-install.rsp.{{ oracle_install_version_gi }}.j2
@@ -93,7 +93,9 @@
   when:
     - item.diskgroup == oracle_asm_init_dg
 
-- block:  # when: oracle_home_gi not in checkgiinstall.stdout
+- name: ""
+  when: oracle_home_gi not in checkgiinstall.stdout
+  block:  # when: oracle_home_gi not in checkgiinstall.stdout
 
     - include_tasks: runcluvfy.yml
       when:
@@ -119,20 +121,21 @@
       tags:
         - oragridinstall
       register: giinstall
-      failed_when: giinstall.rc not in [0,6]
+      failed_when: giinstall.rc not in [0, 6]
 
     - ansible.builtin.debug: var=giinstall.stdout_lines  # noqa unnamed-task
       run_once: "{{ configure_cluster }}"
       when: giinstall.stdout_lines is defined
 
-  when: oracle_home_gi not in checkgiinstall.stdout
-
 - name: install_home_gi | include role oraswgi_manage_patches
   ansible.builtin.include_role:
     name: oraswgi_manage_patches
   when: patch_before_rootsh and apply_patches_gi
 
-- block:  # when: oracle_home_gi not in checkgiinstall.stdout
+- name: ""
+  when:
+    - oracle_home_gi not in checkgiinstall.stdout
+  block:  # when: oracle_home_gi not in checkgiinstall.stdout
     - name: install_home_gi | Run oraInstroot script after installation
       ansible.builtin.command: "{{ oracle_inventory_loc }}/orainstRoot.sh"
       # noqa no-changed-when
@@ -191,6 +194,3 @@
         - run_configtoolallcommand
       ignore_errors: true
       register: configtool
-
-  when:
-    - oracle_home_gi not in checkgiinstall.stdout

roles/oraswgi_install/tasks/curl.yml

@@ -9,4 +9,4 @@
     creates: "{{ oracle_stage }}/{{ item.filename }}"
   tags:
     - oragridsw
-  when: oracle_home_gi not in checkgiinstall.stdout and not is_sw_source_local and oracle_install_version_gi  == item.version and oracle_sw_copy
+  when: oracle_home_gi not in checkgiinstall.stdout and not is_sw_source_local and oracle_install_version_gi == item.version and oracle_sw_copy

roles/oraswgi_install/tasks/get_url.yml

@@ -10,4 +10,4 @@
   become_user: "{{ grid_install_user }}"
   tags:
     - oragridsw
-  when: oracle_home_gi not in checkgiinstall.stdout and oracle_install_version_gi  == item.version and not is_sw_source_local and oracle_sw_copy
+  when: oracle_home_gi not in checkgiinstall.stdout and oracle_install_version_gi == item.version and not is_sw_source_local and oracle_sw_copy