oraswdb_manage_patches: ansible-lint

Author: Rendanic

roles/oraswdb_manage_patches/defaults/main.yml

@@ -20,12 +20,12 @@ nfs_server_sw_path: /path/to/orasw
 
 oracle_stage: /u01/stage
 oracle_stage_remote: "{{ oracle_stage }}"
-oracle_stage_install: "{% if not oracle_sw_copy and not oracle_sw_unpack%}{{ oracle_stage_remote }}{% else %}{{ oracle_stage }}{% endif %}"
+oracle_stage_install: "{% if not oracle_sw_copy and not oracle_sw_unpack %}{{ oracle_stage_remote }}{% else %}{{ oracle_stage }}{% endif %}"
 oracle_base: /u01/app/oracle
 oracle_rsp_stage: "{{ oracle_stage }}/rsp"
 oracle_patch_stage: "{{ oracle_stage }}/patches"
 oracle_patch_stage_remote: "{{ oracle_stage_remote }}/patches"
-oracle_patch_install: "{% if not oracle_sw_copy and not oracle_sw_unpack%}{{ oracle_patch_stage_remote }}{% else %}{{ oracle_patch_stage }}{% endif %}"
+oracle_patch_install: "{% if not oracle_sw_copy and not oracle_sw_unpack %}{{ oracle_patch_stage_remote }}{% else %}{{ oracle_patch_stage }}{% endif %}"
 oracle_inventory_loc: /u01/app/oraInventory
 ocm_response_file: "{{ oracle_patch_stage }}/{{ db_version }}/ocm.rsp"
 

roles/oraswdb_manage_patches/tasks/db-home-patch.yml

@@ -1,9 +1,9 @@
 ---
 - ansible.builtin.set_fact:  # noqa unnamed-task
-    oracle_home_db: "{%- if db_homes_config[dbh.home]['oracle_home'] is defined  -%}
-                        {{ db_homes_config[dbh.home]['oracle_home'] }}
-                    {%- else -%}
-                          {{ oracle_base }}/{{ db_homes_config[dbh.home]['version'] }}/{{ db_homes_config[dbh.home]['home'] }}
+    oracle_home_db: "{%- if db_homes_config[dbh.home]['oracle_home'] is defined -%}\
+                        {{ db_homes_config[dbh.home]['oracle_home'] }}\
+                    {%- else -%}\
+                          {{ oracle_base }}/{{ db_homes_config[dbh.home]['version'] }}/{{ db_homes_config[dbh.home]['home'] }}\
                     {%- endif -%}"
 
 - ansible.builtin.debug: msg="Managing patches for {{ oracle_home_db }}"
@@ -42,18 +42,18 @@
     - ocmconfig
 
 - name: db_opatch | Remove unwanted patches from DB
-  oracle_opatch:
-    oracle_home={{ oracle_home_db }}
-    patch_base={{ oracle_patch_install }}/{{ db_version }}/{{ item.path | default (item.patchid) }}/
-    patch_id={{ item.patchid }}
-    patch_version={{ item.patchversion | default(omit) }}
-    exclude_upi={{ item.excludeUPI | default(omit) }}
-    opatchauto=False
-    conflict_check=True
-    stop_processes={{ item.stop_processes | default(False) }}
-    ocm_response_file={{ ocm_response_file | default(omit) }}
-    output=verbose
-    state={{ item.state }}
+  opitzconsulting.ansible_oracle.oracle_opatch:
+    oracle_home: "{{ oracle_home_db }}"
+    patch_base: "{{ oracle_patch_install }}/{{ db_version }}/{{ item.path | default(item.patchid) }}/"
+    patch_id: "{{ item.patchid }}"
+    patch_version: "{{ item.patchversion | default(omit) }}"
+    exclude_upi: "{{ item.excludeUPI | default(omit) }}"
+    opatchauto: false
+    conflict_check: true
+    stop_processes: "{{ item.stop_processes | default(False) }}"
+    ocm_response_file: "{{ ocm_response_file | default(omit) }}"
+    output: verbose
+    state: "{{ item.state }}"
   with_items:
     - "{{ db_homes_config[dbh.home]['opatch'] }}"
   become: true
@@ -67,7 +67,7 @@
   register: psuapplym
 
 - name: db_opatch | Manage opatchauto patches for DB (non-gi)
-  oracle_opatch:
+  opitzconsulting.ansible_oracle.oracle_opatch:
     oracle_home={{ oracle_home_db }}
     patch_base={{ oracle_patch_install }}/{{ db_version }}/{{ item.0.path | default (item.0.patchid) }}/{{ item.1 }}
     patch_id={{ item.1 }}
@@ -91,16 +91,16 @@
   register: psuapplym
 
 - name: db_opatch | Manage opatchauto patches for DB (gi)
-  oracle_opatch:
-    oracle_home={{ oracle_home_db }}
-    patch_base={{ oracle_patch_install }}/{{ db_version }}/{{ item.path | default (item.patchid) }}/
-    patch_id={{ item.patchid }}
-    patch_version={{ item.patchversion | default(omit) }}
-    opatchauto=True
-    conflict_check=True
-    ocm_response_file={{ ocm_response_file | default(omit) }}
-    output=verbose
-    state={{ item.state }}
+  opitzconsulting.ansible_oracle.oracle_opatch:
+    oracle_home: "{{ oracle_home_db }}"
+    patch_base: "{{ oracle_patch_install }}/{{ db_version }}/{{ item.path | default(item.patchid) }}/"
+    patch_id: "{{ item.patchid }}"
+    patch_version: "{{ item.patchversion | default(omit) }}"
+    opatchauto: true
+    conflict_check: true
+    ocm_response_file: "{{ ocm_response_file | default(omit) }}"
+    output: verbose
+    state: "{{ item.state }}"
   with_items:
     - "{{ db_homes_config[dbh.home]['opatchauto'] }}"
   # run_once: "{{ configure_cluster}}"
@@ -111,18 +111,18 @@
   register: psuapplym
 
 - name: db_opatch | Manage patches for DB
-  oracle_opatch:
-    oracle_home={{ oracle_home_db }}
-    patch_base={{ oracle_patch_install }}/{{ db_version }}/{{ item.path | default (item.patchid) }}/
-    patch_id={{ item.patchid }}
-    patch_version={{ item.patchversion | default(omit) }}
-    exclude_upi={{ item.excludeUPI | default(omit) }}
-    opatchauto=False
-    conflict_check=True
-    stop_processes={{ item.stop_processes | default(False) }}
-    ocm_response_file={{ ocm_response_file | default(omit) }}
-    output=verbose
-    state={{ item.state }}
+  opitzconsulting.ansible_oracle.oracle_opatch:
+    oracle_home: "{{ oracle_home_db }}"
+    patch_base: "{{ oracle_patch_install }}/{{ db_version }}/{{ item.path | default(item.patchid) }}/"
+    patch_id: "{{ item.patchid }}"
+    patch_version: "{{ item.patchversion | default(omit) }}"
+    exclude_upi: "{{ item.excludeUPI | default(omit) }}"
+    opatchauto: false
+    conflict_check: true
+    stop_processes: "{{ item.stop_processes | default(False) }}"
+    ocm_response_file: "{{ ocm_response_file | default(omit) }}"
+    output: verbose
+    state: "{{ item.state }}"
   with_items:
     - "{{ db_homes_config[dbh.home]['opatch'] }}"
   # run_once: "{{ configure_cluster }}"

roles/oraswdb_manage_patches/tasks/main.yml

@@ -21,7 +21,9 @@
     - "{{ db_homes_installed }}"
   tags:
     - directories
-  when: apply_patches_db and item.apply_patches |default (false)
+  when:
+    - apply_patches_db
+    - item.apply_patches | default(false)
 
 - ansible.builtin.include_tasks: db-home-patch.yml
   with_items:

roles/oraswdb_manage_patches/tasks/opatch-upgrade.yml

@@ -1,6 +1,6 @@
 ---
 - name: db_opatch | Check current opatch version
-  oracle_opatch:
+  opitzconsulting.ansible_oracle.oracle_opatch:
     oracle_home={{ oracle_home_db }}
     state=opatchversion
   register: current_opatch_version
@@ -49,7 +49,7 @@
     - oragridpatchunpack
 
 - name: db_opatch | Check current opatch version
-  oracle_opatch:
+  opitzconsulting.ansible_oracle.oracle_opatch:
     oracle_home={{ oracle_home_db }}
     state=opatchversion
   register: current_opatch_version

roles/oraswdb_manage_patches/tasks/unpack-files.yml

@@ -1,10 +1,10 @@
 ---
 - name: db_opatch | Extract opatchauto patch files to patch base
   ansible.builtin.unarchive:
-    src={{ oracle_stage }}/{{ item[0].filename }}
-    dest={{ oracle_patch_stage }}/{{ db_version }}
-    creates={{ oracle_patch_stage }}/{{ db_version }}/{{ item[0].creates | default (omit) }}
-    copy=no
+    src: "{{ oracle_stage }}/{{ item[0].filename }}"
+    dest: "{{ oracle_patch_stage }}/{{ db_version }}"
+    creates: "{{ oracle_patch_stage }}/{{ db_version }}/{{ item[0].creates | default(omit) }}"
+    copy: false
   become: true
   become_user: "{{ oracle_user }}"
   with_nested:
@@ -21,10 +21,10 @@
 
 - name: db_opatch | Extract opatchauto patch files to patch base (from remote location)
   ansible.builtin.unarchive:
-    src={{ oracle_stage_remote }}/{{ item[0].filename }}
-    dest={{ oracle_patch_stage }}/{{ db_version }}
-    creates={{ oracle_patch_stage }}/{{ db_version }}/{{ item[0].creates | default (omit) }}
-    copy=no
+    src: "{{ oracle_stage_remote }}/{{ item[0].filename }}"
+    dest: "{{ oracle_patch_stage }}/{{ db_version }}"
+    creates: "{{ oracle_patch_stage }}/{{ db_version }}/{{ item[0].creates | default(omit) }}"
+    copy: false
   become: true
   become_user: "{{ oracle_user }}"
   with_nested:
@@ -43,15 +43,15 @@
 
 - name: db_opatch | Extract one-off patch files to patch base
   ansible.builtin.unarchive:
-    src={{ oracle_stage }}/{{ item[0].filename }}
-    dest={{ oracle_patch_stage }}/{{ db_version }}
-    creates={{ oracle_patch_stage }}/{{ db_version }}/{{ item[0].creates | default (omit) }}
-    copy=no
+    src: "{{ oracle_stage }}/{{ item[0].filename }}"
+    dest: "{{ oracle_patch_stage }}/{{ db_version }}"
+    creates: "{{ oracle_patch_stage }}/{{ db_version }}/{{ item[0].creates | default(omit) }}"
+    copy: false
   become: true
   become_user: "{{ oracle_user }}"
   with_nested:
     - "{{ oracle_sw_patches }}"
-    - "{{  db_homes_config[dbh.home]['opatch'] }}"
+    - "{{ db_homes_config[dbh.home]['opatch'] }}"
   when:
     - apply_patches_db
     - item[1].patchid == item[0].patchid
@@ -64,10 +64,10 @@
 
 - name: db_opatch | Extract one-off patch files to patch base (from remote location)
   ansible.builtin.unarchive:
-    src={{ oracle_stage_remote }}/{{ item[0].filename }}
-    dest={{ oracle_patch_stage }}/{{ db_version }}
-    creates={{ oracle_patch_stage }}/{{ db_version }}/{{ item[0].creates | default (omit) }}
-    copy=no
+    src: "{{ oracle_stage_remote }}/{{ item[0].filename }}"
+    dest: "{{ oracle_patch_stage }}/{{ db_version }}"
+    creates: "{{ oracle_patch_stage }}/{{ db_version }}/{{ item[0].creates | default(omit) }}"
+    copy: false
   become: true
   become_user: "{{ oracle_user }}"
   with_nested: