oradb-rman: Bugfixes and support for new home structure

Author: Rendanic

roles/oradb-rman/defaults/main.yml

@@ -17,8 +17,6 @@
 
   rman_cron_mkjob: False
 
-  oracle_home_db: "{% if item.0 is defined %}{% if item.0.oracle_home is defined %}{{ item.0.oracle_home}}{% else %}{{ oracle_base }}/{{ item.0.oracle_version_db }}/{{ item.0.home }}{% endif %}{% else %}{% if item.oracle_home is defined %}{{ item.oracle_home }}{% else %}{{ oracle_base }}/{{ item.oracle_version_db }}/{{ item.home }}{% endif %}{% endif %}"
-
   rman_retention_policy_default: "RECOVERY WINDOW OF 14 DAYS"
   rman_channel_disk_default: "'/u10/rmanbackup/%d/%d_%T_%U'"
   rman_controlfile_autobackup_disk_default: "'/u10/rmanbackup/%d/%d_%F'"

roles/oradb-rman/meta/main.yml

@@ -0,0 +1,2 @@
+dependencies:
+  - { role: orasw-meta }

roles/oradb-rman/tasks/main.yml

@@ -1,16 +1,5 @@
 ---
 
-  - name: Check for valid  configuration of oracle_databases
-    no_log: true
-    assert:
-      that:
-        - item.1 is defined
-    with_subelements:
-       - "{{oracle_databases}}"
-       - rman_jobs
-    tags:
-      - assert
-
   - name: Default Destinations for RMAN
     no_log: true
     assert:
@@ -23,17 +12,17 @@
   # autofs is configured in a special way to mount the shares with needed parameters
   - name: configure autofs for RMAN
     lineinfile: dest=/etc/auto.master regexp="^{{rmanautofsmount}} " line="{{rmanautofsmount}} /etc/auto.net --timeout=60 rw,hard,rsize=32768,wsize=32768,proto=tcp,nfsvers=3"
-    when: "rmanautofs|bool == true"
+    when: rmanautofs
     tags: autofs
 
   - name: Create Mountpoint
     file: dest={{rmanautofsmount}} state=directory
-    when: "rmanautofs|bool == true"
+    when: rmanautofs
     tags: autofs
 
   - name: Restart autofs
     service: name=autofs enabled=yes state=restarted
-    when: "rmanautofs|bool == true"
+    when: rmanautofs
     tags: autofs
 
   - name: Create bin-Directory for rman_backup
@@ -49,7 +38,16 @@
 
   # dummy with_together for item.0.db_name in default/main.yml 
   - name: Create Directory for rman-scripts
-    file: path={{oracle_admin_db}}/rman state=directory mode=0755 owner={{oracle_user}}
+    file: path={{rman_script_dir}} state=directory mode=0755 owner={{oracle_user}}
+    with_together:
+       - "{{oracle_databases}}"
+       - ""
+    tags:
+      - rmancopy
+
+  # dummy with_together for item.0.db_name in default/main.yml
+  - name: Create Directory for rman-logfiles
+    file: path={{rman_log_dir}} state=directory mode=0755 owner={{oracle_user}}
     with_together:
        - "{{oracle_databases}}"
        - ""
@@ -61,39 +59,105 @@
     tags:
       - rmancopy
 
+  # rman_script_dir: {{oracle_admin_db}}/rman/
   - name: copy RMAN scipts
-    template: dest={{oracle_admin_db}}/rman/{{item.1.name}}.rman src={{item.1.name}}.rman.j2 backup=yes mode=644 owner={{oracle_user}}
+    template: dest={{rman_script_dir}}/{{item.1.name}}.rman src={{item.1.name}}.rman.j2 backup=yes mode=644 owner={{oracle_user}}
     with_subelements:
        - "{{oracle_databases}}"
        - rman_jobs
+       - skip_missing: yes
     tags:
       - rmancopy
 
+  - name: Create directory for TNS_ADMIN
+    file: dest={{rman_tns_admin}} state=directory owner={{oracle_user}}
+    with_items:
+       - "{{oracle_databases}}"
+    when: item.rman_tnsalias is defined
+    tags:
+      - tns
+
+  - name: copy sqlnet.ora for wallet
+    template: src=sqlnet.ora.j2 dest={{rman_tns_admin}}/sqlnet.ora owner={{oracle_user}} mode=644
+    with_items:
+       - "{{oracle_databases}}"
+    when: item.rman_tnsalias is defined
+    tags:
+      - tns
+
+  - name: copy tnsnames.ora for catalog
+    template: src=tnsnames.ora.j2 dest={{rman_tns_admin}}/tnsnames.ora owner={{oracle_user}} mode=644 backup=True
+    with_items:
+       - "{{oracle_databases}}"
+    when: item.rman_tnsalias is defined
+    tags:
+      - tns
+
+  - name: Wallet create
+    shell: "test -d {{rman_wallet_loc}} || echo -e '{{rman_wallet_password}}\n{{rman_wallet_password}}' | {{oracle_home_db}}/bin/mkstore -create -nologo -wrl {{rman_wallet_loc}}"
+    become: yes
+    become_user: "{{ oracle_user }}"
+    with_items:
+       - "{{oracle_databases}}"
+    when: item.rman_tnsalias is defined
+    tags:
+      - wallet
+
+  # no_log => secure password against logfiles
+  # ignore errors during createCredential when entry is existing
+  - name: Wallet createCredential
+    shell: "echo -e '{{rman_wallet_password}}' | {{oracle_home_db}}/bin/mkstore -wrl {{rman_wallet_loc}} -nologo -createCredential {{item.rman_tnsalias}} {{item.rman_user}} {{item.rman_password}}; exit 0"
+    become: yes
+    become_user: "{{ oracle_user }}"
+    no_log: true
+    with_items:
+       - "{{oracle_databases}}"
+    when: item.rman_tnsalias is defined and item.rman_user is defined and item.rman_password is defined
+    tags:
+      - wallet
+
   # the following task is usefull for configuration of rman-parameters during setup of RMAN
   # It's also possible to execute the 1st Level0-Backup after setup, but be aware to configure the RMAN before starting a backup
   # The execution isn't done in async mode!
   # The task is only execute once on master_node when GI is installed!
+  # no catalog connection, because setting initial parameters with catalog takes much more time
   - name: Execute RMAN-Script at playbook
-    shell: "{{oracle_base}}/bin/rman_backup.sh -a {{item.1.name}} -s {{item.0.oracle_db_name}} -r {{oracle_admin_db}}/rman -l {{oracle_admin_db}}/rman | tee -a {{rman_cron_logdir}}/rman_{{item.1.name}}.log"
+    shell: "{{oracle_base}}/bin/rman_backup.sh -a {{item.1.name}} -s {{item.0.oracle_db_name}} -r {{rman_script_dir}} -l {{rman_log_dir}} | tee -a {{rman_cron_logdir}}/rman_{{item.1.name}}.log"
     environment:
       - PATH: /bin:/usr/bin
     become: yes
     become_user: "{{ oracle_user }}"
-    when: "'parameter' in item.1.name"
     register: rmanexecimmediate
     with_subelements:
        - "{{oracle_databases}}"
        - rman_jobs
-    when: item.1.immediate | default(false) == true and ((oracle_install_option_gi | default('SI') == 'CRS_CONFIG' and master_node) or oracle_install_option_gi != 'CRS_CONFIG')
+       - skip_missing: yes
+    when: master_node and item.1.immediate is defined and item.1.immediate
     tags:
       - rmanexecute
 
-  - debug: msg={{item.results[0].stdout_lines}}
+#  - debug: msg={{item.results[0].stdout_lines | default("")}}
+  - debug: msg={{item.results.stdout_lines | default("")}}
     with_items:
       - "{{rmanexecimmediate}}"
+    when: rmanexecimmediate is defined
     tags:
       - rmanexecute
 
+  - name: Add Environment variables to /ec/cron.d
+    cron: 
+      cron_file: "{{rman_cronfile}}"
+      user: "{{oracle_user}}"
+      env: yes
+      name: "{{ item.name }}"
+      value: "{{ item.value }}"
+    with_items:
+      - { name: RMANLOGDIR    , value: '{{ rman_log_dir }}' }
+      - { name: RMANSCRIPTDIR , value: '{{ rman_script_dir }}' }
+      - { name: RMANTNS_ADMIN , value: '{{ rman_tns_admin }}' }
+    tags:
+      - rmancron
+
   - name: Create crontab entries for RMAN Backup
     cron: 
       name: rman_backup_{{item.0.oracle_db_name}}_{{item.1.name}}
@@ -104,10 +168,11 @@
       weekday: "{{item.1.weekday}}"
       hour: "{{item.1.hour}}"
       minute: "{{item.1.minute}}"
-      job: "{{oracle_base}}/bin/rman_backup.sh -a {{item.1.name}} -s {{item.0.oracle_db_name}} -r {{oracle_admin_db}}/rman -l {{oracle_admin_db}}/rman {{rman_service_param}} >> {{rman_cron_logdir}}/rman_{{item.1.name}}.log 2>&1"
+      job: "{{ check_mk_mkjob }}{{oracle_base}}/bin/rman_backup.sh -a {{item.1.name}} -s {{item.0.oracle_db_name}} {{rman_service_param}} {{rman_catalog_param}} {{rmanbackuplogdir}} {{rmanbackupscriptdir}}>> {{rman_cron_logdir}}/rman_{{item.0.oracle_db_name}}_{{item.1.name}}.log 2>&1"
     with_subelements:
        - "{{oracle_databases}}"
        - rman_jobs
+       - skip_missing: yes
     when: 
       - item.1 is defined 
       - item.1.disabled is defined
@@ -116,6 +181,11 @@
       - item.1.hour is defined
       - item.1.minute is defined
       - item.1.name is defined
-      - item.0.oracle_install_option_gi | default('SI') != ('CRS_CONFIG')
     tags:
       - rmancron
+
+  - name: Create directory for mk-job
+    file: dest=/var/lib/check_mk_agent/job/{{oracle_user}} state=directory owner={{oracle_user}}
+    when: rman_cron_mkjob
+    tags: rmancron
+