Do not permanently change the values of the 'val' array by escaping each element inside it

jouke · jouke · commit 34df39d4f390 · 2016-04-13T14:18:48.000+02:00
diff --git a/lib/sqlite3db.js b/lib/sqlite3db.js
@@ -317,10 +317,11 @@ SQLiteDB.prototype.toDatabase = function (prop, val) {
       return this.toDatabase(prop, val[0]) + ' AND ' + this.toDatabase(prop, val[1]);
     }
     if (operator === 'inq' || operator === 'nin') {
+      var newVal = [];
       for (var i = 0; i < val.length; i++) {
-        val[i] = escape(val[i]);
+        newVal[i] = escape(val[i]);
       }
-      return val.join(',');
+      return newVal.join(',');
     }
     return this.toDatabase(prop, val);
   }

Original file line number	Diff line number	Diff line change
`@@ -317,10 +317,11 @@ SQLiteDB.prototype.toDatabase = function (prop, val) {`
`317`	`317`	`return this.toDatabase(prop, val[0]) + ' AND ' + this.toDatabase(prop, val[1]);`
`318`	`318`	`}`
`319`	`319`	`if (operator === 'inq' \|\| operator === 'nin') {`
	`320`	`+ var newVal = [];`
`320`	`321`	`for (var i = 0; i < val.length; i++) {`
`321`		`- val[i] = escape(val[i]);`
	`322`	`+ newVal[i] = escape(val[i]);`
`322`	`323`	`}`
`323`		`- return val.join(',');`
	`324`	`+ return newVal.join(',');`
`324`	`325`	`}`
`325`	`326`	`return this.toDatabase(prop, val);`
`326`	`327`	`}`