Merge pull request #8 from jouke/master

SQLiteDB.prototype.toDatabase no longer changes object contents when val is an array

Author: tushar-chauhan

lib/migration.js

@@ -30,7 +30,7 @@ function mixinMigration(SQLiteDB) {
     }
 
     var sql = null;
-    sql = 'PRAGMA table_info(' + this.table(model) +')';
+    sql = 'PRAGMA table_info(' + this.tableEscaped(model) +')';
     var params = [];
     params.status = true;
     this.executeSQL(sql, params, decoratedCallback);

lib/sqlite3db.js

@@ -317,10 +317,11 @@ SQLiteDB.prototype.toDatabase = function (prop, val) {
       return this.toDatabase(prop, val[0]) + ' AND ' + this.toDatabase(prop, val[1]);
     }
     if (operator === 'inq' || operator === 'nin') {
+      var newVal = [];
       for (var i = 0; i < val.length; i++) {
-        val[i] = escape(val[i]);
+        newVal[i] = escape(val[i]);
       }
-      return val.join(',');
+      return newVal.join(',');
     }
     return this.toDatabase(prop, val);
   }

test/user_model.test.js

@@ -47,10 +47,29 @@ describe("SQLite Model creation test", function(){
           expect(u.name).to.be.equal("John");
         else if(u.id == 2) {
           expect(u.name).to.be.equal("Doe");
-          done();
+          testArrayContents(done)
+          // done();
         }
       });
     }
+
+    function testArrayContents(cb) {
+      var namesSomething = [{name: 'John', some: 'object'}, {name: 'Doe', some: 'other object'}];
+      var names = [];
+      namesSomething.forEach(function(n) {
+        names.push(n.name);
+      });
+
+      User.find({
+        where: {
+          name: {inq: names}
+        }
+      }, function(err, foundUsers) {
+        expect(names[0]).to.be.equal('John');
+        expect(names[1]).to.be.equal('Doe');
+        cb();
+      });
+    }
   });
 
   it('should run auto-migration when model changes', function (done) {