Accessors should return string references, not copies

joto · joto · commit 470092dfe452 · 2025-07-07T09:50:20.000+02:00
diff --git a/src/expire-output.hpp b/src/expire-output.hpp
@@ -29,16 +29,16 @@ class expire_output_t
 public:
     expire_output_t() = default;
 
-    std::string filename() const noexcept { return m_filename; }
+    std::string const &filename() const noexcept { return m_filename; }
 
     void set_filename(std::string filename)
     {
         m_filename = std::move(filename);
     }
 
-    std::string schema() const noexcept { return m_schema; }
+    std::string const &schema() const noexcept { return m_schema; }
 
-    std::string table() const noexcept { return m_table; }
+    std::string const &table() const noexcept { return m_table; }
 
     void set_schema_and_table(std::string schema, std::string table)
     {

Original file line number	Diff line number	Diff line change
`@@ -29,16 +29,16 @@ class expire_output_t`
`29`	`29`	`public:`
`30`	`30`	`expire_output_t() = default;`
`31`	`31`
`32`		`- std::string filename() const noexcept { return m_filename; }`
	`32`	`+ std::string const &filename() const noexcept { return m_filename; }`
`33`	`33`
`34`	`34`	`void set_filename(std::string filename)`
`35`	`35`	`{`
`36`	`36`	`m_filename = std::move(filename);`
`37`	`37`	`}`
`38`	`38`
`39`		`- std::string schema() const noexcept { return m_schema; }`
	`39`	`+ std::string const &schema() const noexcept { return m_schema; }`
`40`	`40`
`41`		`- std::string table() const noexcept { return m_table; }`
	`41`	`+ std::string const &table() const noexcept { return m_table; }`
`42`	`42`
`43`	`43`	`void set_schema_and_table(std::string schema, std::string table)`
`44`	`44`	`{`