clang-tidy cleanup: remove redundant member inits

Author: joto

src/input.cpp

@@ -122,9 +122,9 @@ class data_source_t
     using iterator = osmium::memory::Buffer::t_iterator<osmium::OSMObject>;
 
     std::unique_ptr<osmium::io::Reader> m_reader;
-    osmium::memory::Buffer m_buffer{};
-    iterator m_it{};
-    iterator m_end{};
+    osmium::memory::Buffer m_buffer;
+    iterator m_it;
+    iterator m_end;
     type_id m_last = {osmium::item_type::node, 0};
 
 }; // class data_source_t

src/input.hpp

@@ -35,8 +35,8 @@ struct type_id
 
 struct file_info
 {
-    osmium::io::Header header{};
-    osmium::Timestamp last_timestamp{};
+    osmium::io::Header header;
+    osmium::Timestamp last_timestamp;
 };
 
 /**

src/options.hpp

@@ -53,30 +53,30 @@ struct options_t
     bool prefix_is_set = false;
 
     /// Pg Tablespace to store indexes on main tables (no default TABLESPACE)
-    std::string tblsmain_index{};
+    std::string tblsmain_index;
 
     /// Pg Tablespace to store indexes on slim tables (no default TABLESPACE)
-    std::string tblsslim_index{};
+    std::string tblsslim_index;
 
     /// Pg Tablespace to store main tables (no default TABLESPACE)
-    std::string tblsmain_data{};
+    std::string tblsmain_data;
 
     /// Pg Tablespace to store slim tables (no default TABLESPACE)
-    std::string tblsslim_data{};
+    std::string tblsslim_data;
 
     /// Default Pg schema.
     std::string dbschema{"public"};
 
     /// Pg schema to store middle tables in.
-    std::string middle_dbschema{};
+    std::string middle_dbschema;
 
     /// Pg schema to store output tables in.
-    std::string output_dbschema{};
+    std::string output_dbschema;
 
-    std::string style{}; ///< style file to use
+    std::string style; ///< style file to use
 
     /// Name of the flat node file used. Empty if flat node file is not enabled.
-    std::string flat_node_file{};
+    std::string flat_node_file;
 
     std::string tag_transform_script;
 

src/output-flex.hpp

@@ -298,19 +298,19 @@ class output_flex_t : public output_t
 
     osmium::memory::Buffer m_area_buffer;
 
-    prepared_lua_function_t m_process_node{};
-    prepared_lua_function_t m_process_way{};
-    prepared_lua_function_t m_process_relation{};
+    prepared_lua_function_t m_process_node;
+    prepared_lua_function_t m_process_way;
+    prepared_lua_function_t m_process_relation;
 
-    prepared_lua_function_t m_process_untagged_node{};
-    prepared_lua_function_t m_process_untagged_way{};
-    prepared_lua_function_t m_process_untagged_relation{};
+    prepared_lua_function_t m_process_untagged_node;
+    prepared_lua_function_t m_process_untagged_way;
+    prepared_lua_function_t m_process_untagged_relation;
 
-    prepared_lua_function_t m_select_relation_members{};
+    prepared_lua_function_t m_select_relation_members;
 
-    prepared_lua_function_t m_after_nodes{};
-    prepared_lua_function_t m_after_ways{};
-    prepared_lua_function_t m_after_relations{};
+    prepared_lua_function_t m_after_nodes;
+    prepared_lua_function_t m_after_ways;
+    prepared_lua_function_t m_after_relations;
 
     calling_context m_calling_context = calling_context::main;
 

src/thread-pool.hpp

@@ -60,7 +60,7 @@ class task_result_t
     std::chrono::microseconds runtime() const noexcept { return m_result; }
 
 private:
-    std::future<std::chrono::microseconds> m_future{};
+    std::future<std::chrono::microseconds> m_future;
     std::chrono::microseconds m_result{};
 }; // class task_result_t