Use east const consistently

Author: joto

src/geom-area-assembler.cpp

@@ -13,7 +13,7 @@
 
 namespace geom {
 
-const osmium::area::AssemblerConfig area_config;
+osmium::area::AssemblerConfig const area_config;
 
 area_assembler_t::area_assembler_t(osmium::memory::Buffer *buffer)
 : osmium::area::detail::BasicAssembler(area_config), m_buffer(buffer)
@@ -36,7 +36,7 @@ bool area_assembler_t::make_area()
     return true;
 }
 
-bool area_assembler_t::operator()(const osmium::Way &way)
+bool area_assembler_t::operator()(osmium::Way const &way)
 {
     segment_list().extract_segments_from_way(nullptr, stats().duplicate_nodes,
                                              way);
@@ -46,10 +46,10 @@ bool area_assembler_t::operator()(const osmium::Way &way)
 // Currently the relation is not needed for assembling the area, because
 // the roles on the members are ignored. In the future we might want to use
 // the roles, so we leave the function signature as it is.
-bool area_assembler_t::operator()(const osmium::Relation & /*relation*/,
-                                  const osmium::memory::Buffer &ways_buffer)
+bool area_assembler_t::operator()(osmium::Relation const & /*relation*/,
+                                  osmium::memory::Buffer const &ways_buffer)
 {
-    for (const auto &way : ways_buffer.select<osmium::Way>()) {
+    for (auto const &way : ways_buffer.select<osmium::Way>()) {
         segment_list().extract_segments_from_way(nullptr,
                                                  stats().duplicate_nodes, way);
     }

src/geom-area-assembler.hpp

@@ -35,7 +35,7 @@ class area_assembler_t : public osmium::area::detail::BasicAssembler
      * @returns false if there was some kind of error building the
      *          area, true otherwise.
      */
-    bool operator()(const osmium::Way &way);
+    bool operator()(osmium::Way const &way);
 
     /**
      * Assemble an area from the given relation and its member ways
@@ -44,8 +44,8 @@ class area_assembler_t : public osmium::area::detail::BasicAssembler
      * @returns false if there was some kind of error building the
      *          area, true otherwise.
      */
-    bool operator()(const osmium::Relation &relation,
-                    const osmium::memory::Buffer &ways_buffer);
+    bool operator()(osmium::Relation const &relation,
+                    osmium::memory::Buffer const &ways_buffer);
 
     /**
      * Access the area that was built last.

src/geom-pole-of-inaccessibility.cpp

@@ -147,7 +147,7 @@ Cell make_centroid_cell(polygon_t const &polygon, double stretch)
 
 } // anonymous namespace
 
-point_t pole_of_inaccessibility(const polygon_t &polygon, double precision,
+point_t pole_of_inaccessibility(polygon_t const &polygon, double precision,
                                 double stretch)
 {
     assert(stretch > 0);

src/geom-pole-of-inaccessibility.hpp

@@ -28,7 +28,7 @@ namespace geom {
  *
  * \pre \code stretch > 0 \endcode
  */
-point_t pole_of_inaccessibility(const polygon_t &polygon, double precision,
+point_t pole_of_inaccessibility(polygon_t const &polygon, double precision,
                                 double stretch = 1.0);
 
 void pole_of_inaccessibility(geometry_t *output, geometry_t const &input,

src/idlist.cpp

@@ -25,7 +25,7 @@ osmid_t idlist_t::pop_id()
 void idlist_t::sort_unique()
 {
     std::sort(m_list.begin(), m_list.end());
-    const auto last = std::unique(m_list.begin(), m_list.end());
+    auto const last = std::unique(m_list.begin(), m_list.end());
     m_list.erase(last, m_list.end());
 }
 

src/middle-pgsql.cpp

@@ -47,8 +47,8 @@
 
 namespace {
 
-void send_id_list(pg_conn_t const &db_connection,
-                         std::string const &table, idlist_t const &ids)
+void send_id_list(pg_conn_t const &db_connection, std::string const &table,
+                  idlist_t const &ids)
 {
     std::string data;
     for (auto const id : ids) {
@@ -171,7 +171,7 @@ class member_list_json_builder
     }
 
     static bool number_float(nlohmann::json::number_float_t /*val*/,
-                             const nlohmann::json::string_t & /*s*/)
+                             nlohmann::json::string_t const & /*s*/)
     {
         return true;
     }
@@ -228,8 +228,8 @@ class member_list_json_builder
     static bool end_array() { return true; }
 
     static bool parse_error(std::size_t /*position*/,
-                            const std::string & /*last_token*/,
-                            const nlohmann::json::exception &ex)
+                            std::string const & /*last_token*/,
+                            nlohmann::json::exception const &ex)
     {
         throw ex;
     }

src/osm2pgsql.cpp

@@ -188,7 +188,7 @@ void check_and_update_flat_node_file(properties_t *properties,
                      flat_node_file_from_import);
         }
     } else {
-        const auto absolute_path =
+        auto const absolute_path =
             std::filesystem::absolute(
                 std::filesystem::path{options->flat_node_file})
                 .string();
@@ -279,7 +279,7 @@ void check_and_update_style_file(properties_t *properties, options_t *options)
         throw std::runtime_error{"Style file from import is empty!?"};
     }
 
-    const auto absolute_path =
+    auto const absolute_path =
         std::filesystem::absolute(std::filesystem::path{options->style})
             .string();