Install Doesn't Work

[ninjabong]

Step 5 needs work, or the requirements.yml at least needs some work, namely it should be:

# Ansible Galaxy Requirements
osxc.common-env
osxc.homebrew
osxc.packages
osxc.repository

no --- on the first line, - src: removed, the last line as osxc.repository thus making it a text file.

The issue here is per ansible's own docs YAML files aren't even supported until Ansible 1.8 where pip is installing 1.7.1 still (at least in my local testing yosemite VM and a hosted CentOS7 VM).

The other issue relates to what looks like you wanting to support any user on a machine and thus using /etc/ansible/roles which needs sudo. I'm using roles_path: ./roles in ansible.cfg instead of system-wide (and not supporting multiple users) so it's easier to get a better handle on all the new stuff you have going on. This could be better explicated in the README.md:

"If you're installing system-wide sudo ansible-galaxy install -r requirements.yml otherwise edit ansible.cfg and uncomment #roles_path:./roles before running ansible-galaxy install -requirements.yml"

So... yeah, basically things are messy, and still a work in progress obviously, but I don't want to just push my fixes since I'm just making guesses about how you want this new galaxy powered osxc to work. 8)

[ninjabong]

OK so I went and updated my VM's ansible manually to 1.8 using:

git clone https://github.com/ansible/ansible.git ~/src/ansible
cd ~/src/ansible
make && sudo make install

and now ansible-galaxy install -r requirements.yml works, once the last line is changed to osxc.repository and ansible.cfg has roles_path=./roles appended (again, I'm just trying to get it working for a single user before system-wide, so no sudo yet).

Next issue after that is the playbook roles are called without osxc. so ansible is failing to locate the roles unless I change install.yml - roles: packages to - roles: osxc.packages but then I get the following : ERROR: expected a role name in dictionary: {'src': 'osxc.common-env}

edit this is due to the version of osxc.homebrew on galaxy not matching the github version, specifically in osxc.homebrew/meta/main.yml under dependencies is where the -src: osxc.common-env lies instead of just - osxc.common

Additioanlly line 18 of common-env/tasks/main.yml should probably have ,.profile'` appended to the end of the dictionary for completeness, however it would still fail on my clean testing system where none of those existed.

[rricard]

Ok, let's do a PR then ! I did all of that in a hurry and I shouldn't have deprecated the other repos. But the thing is, the roles themselves are working very well and are CI-tested.

[ninjabong]

Yeah I understand - you just wanted to push forward with the new setup, and it is a good change!

The galaxy version of osxc.homebrew being out of sync with the github version I'm not sure how to fix, how does galaxy know about the github tag/versioning? Do you have to do something manually on galaxy to update or is it supposedly to be automatic?

Also is it correct that the roles should be named osxc.foo as that is how they come down from galaxy named as opposed to how they're named on github, without the osxc.? (So I know to make sure they're updated in my PR)

The CI-tested stuff is also really nice, but like people it's not perfect. Right now it doesn't catch some small things like the pip install ansible version (again I'm getting 1.7.1 not 1.8 by default breaking the requirements YAML) and OS X not having any .bash_profile/.bash_login/.zshrc/.zshenv/.profile created by default. My guess on that is part of the homebrew install in travis's 10.9.2 VMs puts one there since it's not actually there on a freshly installed "clean" system.

I'll take a crack at making common-env a little more like the legacy version that will also ensure at minimum .profile exists. From then on subsequent runs in a new shell should detect a new .bash_profile or .zshrc as a user actually uses their new machine.

Cask packages are unfortunately still gonna wind up in ~/Applications instead of /Applications because ~/.common_env will have not been sourced for the current shell during the initial run when it's installing casks into ~/Apps by default. Perhaps we should be using something like environment: HOMEBREW_CASK_OPTS=--appdir={{ cask_appdir }} with cask_appdir: /Applications in defaults/main.yml instead?

[ninjabong]

I PR'd to each repo:
common-env
packages
starter

[ninjabong]

bump