fix(linter/plugins): fix TS types for RuleTester (#16546)

Fix TS types for `RuleTester`. Merging the `RuleTester` class and namespace was working OK within the repo, but not in the built bundle. Fix that by defining the namespace in same file as the class.

Author: overlookmotel

apps/oxlint/src-js/index.ts

@@ -60,25 +60,3 @@ export type {
   Visitor,
   VisitorWithHooks,
 } from "./plugins/types.ts";
-
-// Rule tester types.
-// Export as namespace to avoid lengthy type names.
-import type {
-  Config as _Config,
-  DescribeFn as _DescribeFn,
-  ItFn as _ItFn,
-  ValidTestCase as _ValidTestCase,
-  InvalidTestCase as _InvalidTestCase,
-  TestCases as _TestCases,
-  Error as _Error,
-} from "./package/rule_tester.ts";
-
-export namespace RuleTester {
-  export type Config = _Config;
-  export type DescribeFn = _DescribeFn;
-  export type ItFn = _ItFn;
-  export type ValidTestCase = _ValidTestCase;
-  export type InvalidTestCase = _InvalidTestCase;
-  export type TestCases = _TestCases;
-  export type Error = _Error;
-}

apps/oxlint/src-js/package/rule_tester.ts

@@ -35,8 +35,8 @@ const { hasOwn } = Object,
 // `describe` and `it` functions
 // ------------------------------------------------------------------------------
 
-export type DescribeFn = (text: string, fn: () => void) => void;
-export type ItFn = ((text: string, fn: () => void) => void) & { only?: ItFn };
+type DescribeFn = (text: string, fn: () => void) => void;
+type ItFn = ((text: string, fn: () => void) => void) & { only?: ItFn };
 
 /**
  * Default `describe` function, if `describe` doesn't exist as a global.
@@ -111,7 +111,7 @@ function getItOnly(): ItFn {
 /**
  * Configuration for `RuleTester`.
  */
-export interface Config {
+interface Config {
   /**
    * ESLint compatibility mode.
    * If `true`, column offsets in diagnostics are incremented by 1, to match ESLint's behavior.
@@ -154,12 +154,12 @@ interface TestCase {
 /**
  * Test case for valid code.
  */
-export interface ValidTestCase extends TestCase {}
+interface ValidTestCase extends TestCase {}
 
 /**
  * Test case for invalid code.
  */
-export interface InvalidTestCase extends TestCase {
+interface InvalidTestCase extends TestCase {
   output?: string | null;
   errors: number | ErrorEntry[];
 }
@@ -169,7 +169,7 @@ type ErrorEntry = Error | string | RegExp;
 /**
  * Expected error.
  */
-export type Error = RequireAtLeastOne<ErrorBase, "message" | "messageId">;
+type Error = RequireAtLeastOne<ErrorBase, "message" | "messageId">;
 
 interface ErrorBase {
   message?: string | RegExp;
@@ -184,7 +184,7 @@ interface ErrorBase {
 /**
  * Test cases for a rule.
  */
-export interface TestCases {
+interface TestCases {
   valid: (ValidTestCase | string)[];
   invalid: InvalidTestCase[];
 }
@@ -990,3 +990,22 @@ function isSerializablePrimitiveOrPlainObject(value: unknown): boolean {
     (typeof value === "object" && (value.constructor === Object || isArray(value)))
   );
 }
+
+// Add types to `RuleTester` namespace
+type _Config = Config;
+type _DescribeFn = DescribeFn;
+type _ItFn = ItFn;
+type _ValidTestCase = ValidTestCase;
+type _InvalidTestCase = InvalidTestCase;
+type _TestCases = TestCases;
+type _Error = Error;
+
+export namespace RuleTester {
+  export type Config = _Config;
+  export type DescribeFn = _DescribeFn;
+  export type ItFn = _ItFn;
+  export type ValidTestCase = _ValidTestCase;
+  export type InvalidTestCase = _InvalidTestCase;
+  export type TestCases = _TestCases;
+  export type Error = _Error;
+}