Skip to content

Commit 6c5a37f

Browse files
committed
one more wording tweak
1 parent 6ccc658 commit 6c5a37f

File tree

1 file changed

+3
-8
lines changed
  • lib/propolis/src/hw/nvme

1 file changed

+3
-8
lines changed

lib/propolis/src/hw/nvme/mod.rs

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,7 @@ mod requests;
3232
use bits::*;
3333
use queue::{CompQueue, QueueId, SubQueue};
3434

35-
/// Static for generating unique NVMe device identifiers within a process.
36-
///
37-
/// Numbering across NVMe devices means that the combination of NVMe
38-
/// `device_id` and queue ID identify either an NVMe submission or completion
39-
/// queue across a VM.
40-
///
41-
/// Guests typically will configure submission queue N to complete into
42-
/// completion queue N, but this is not a mandated device configuration.
35+
/// Static for generating unique NVMe device identifiers across a VM.
4336
static NEXT_DEVICE_ID: AtomicU32 = AtomicU32::new(0);
4437

4538
type DeviceId = u32;
@@ -184,6 +177,8 @@ const MAX_NUM_IO_QUEUES: usize = MAX_NUM_QUEUES - 1;
184177
struct NvmeCtrl {
185178
/// A distinguishing identifier for this NVMe controller across the VM.
186179
/// Useful mostly to distinguish queues and commands as seen in probes.
180+
/// `device_id` is held constant across NVMe resets, but not persisted
181+
/// across export and import.
187182
device_id: DeviceId,
188183

189184
/// Internal NVMe Controller state

0 commit comments

Comments
 (0)