Wait() causes main thread to block

[shoerob]

When calling any of the public connect() methods from an Activity, these all route to the core connect() method that spawns a SocketThread.

Code like this executes a few times while the connection is being established. If you call connect() from the main thread, and plan on doing subsequent UI updates, this can be problematic.

        synchronized (mSocketThread) {
            try {
                mSocketThread.wait();
            } catch (InterruptedException e) {
            }
        }

This causes the main thread to block for long periods in certain situations, such as a connection taking a long time to establish. This is not ideal in situations where the UI needs to show a status of the connection. With a little refactoring, I think these waits can probably be removed to fix this.

[palmerc]

I agree. Do you have a patch for this?

On 18. nov. 2014, at 00.08, Robert Shoemate notifications@github.com wrote:

When calling any of the public connect() methods from an Activity, these all route to the core connect() method that spawns a SocketThread.

Code like this executes a few times while the connection is being established. If you call connect() from the main thread, and plan on doing subsequent UI updates, this can be problematic.

    synchronized (mSocketThread) {
        try {
            mSocketThread.wait();
        } catch (InterruptedException e) {
        }
    }

This causes the main thread to block for long periods in certain situations, such as a connection taking a long time to establish. This is not ideal in situations where the UI needs to show a status of the connection. With a little refactoring, I think these waits can probably be removed to fix this.

—
Reply to this email directly or view it on GitHub #14.

[shoerob]

Not yet - I just discovered it, and am still looking into a good way to fix it.