From 1213caedc8ed17c8f95a2ed66960573930f54c65 Mon Sep 17 00:00:00 2001
From: nnhhoang <hoangnnh67@gmail.com>
Date: Thu, 26 Mar 2026 11:46:10 +0700
Subject: [PATCH 1/2] fix: allow deleting walls and slabs via floating action
 menu

Walls and slabs were excluded from ALLOWED_TYPES in FloatingActionMenu,
so no delete UI appeared when selecting them. Added wall/slab to the
allowed types and show only the delete button (no move/duplicate) since
they are structural elements.

Usage: switch to select mode (V), click a wall or slab, then use the
floating trash icon or press Delete/Backspace to remove it.

Closes #156
---
 .../editor/floating-action-menu.tsx           |  7 +--
 .../components/editor/node-action-menu.tsx    | 44 ++++++++++---------
 2 files changed, 28 insertions(+), 23 deletions(-)

diff --git a/packages/editor/src/components/editor/floating-action-menu.tsx b/packages/editor/src/components/editor/floating-action-menu.tsx
index a92d5956..cf727a6e 100644
--- a/packages/editor/src/components/editor/floating-action-menu.tsx
+++ b/packages/editor/src/components/editor/floating-action-menu.tsx
@@ -20,7 +20,8 @@ import { sfxEmitter } from '../../lib/sfx-bus'
 import useEditor from '../../store/use-editor'
 import { NodeActionMenu } from './node-action-menu'
 
-const ALLOWED_TYPES = ['item', 'door', 'window', 'roof', 'roof-segment']
+const ALLOWED_TYPES = ['item', 'door', 'window', 'roof', 'roof-segment', 'wall', 'slab']
+const DELETE_ONLY_TYPES = ['wall', 'slab']
 
 export function FloatingActionMenu() {
   const selectedIds = useViewer((s) => s.selection.selectedIds)
@@ -174,8 +175,8 @@ export function FloatingActionMenu() {
       >
         <NodeActionMenu
           onDelete={handleDelete}
-          onDuplicate={handleDuplicate}
-          onMove={handleMove}
+          onDuplicate={node && !DELETE_ONLY_TYPES.includes(node.type) ? handleDuplicate : undefined}
+          onMove={node && !DELETE_ONLY_TYPES.includes(node.type) ? handleMove : undefined}
           onPointerDown={(e) => e.stopPropagation()}
           onPointerUp={(e) => e.stopPropagation()}
         />
diff --git a/packages/editor/src/components/editor/node-action-menu.tsx b/packages/editor/src/components/editor/node-action-menu.tsx
index 94bab4cb..b383a997 100644
--- a/packages/editor/src/components/editor/node-action-menu.tsx
+++ b/packages/editor/src/components/editor/node-action-menu.tsx
@@ -5,8 +5,8 @@ import type { MouseEventHandler, PointerEventHandler } from 'react'
 
 type NodeActionMenuProps = {
   onDelete: MouseEventHandler<HTMLButtonElement>
-  onDuplicate: MouseEventHandler<HTMLButtonElement>
-  onMove: MouseEventHandler<HTMLButtonElement>
+  onDuplicate?: MouseEventHandler<HTMLButtonElement>
+  onMove?: MouseEventHandler<HTMLButtonElement>
   onPointerDown?: PointerEventHandler<HTMLDivElement>
   onPointerUp?: PointerEventHandler<HTMLDivElement>
   onPointerEnter?: PointerEventHandler<HTMLDivElement>
@@ -30,24 +30,28 @@ export function NodeActionMenu({
       onPointerLeave={onPointerLeave}
       onPointerUp={onPointerUp}
     >
-      <button
-        aria-label="Move"
-        className="tooltip-trigger rounded-md p-1.5 text-muted-foreground transition-colors hover:bg-accent hover:text-foreground"
-        onClick={onMove}
-        title="Move"
-        type="button"
-      >
-        <Move className="h-4 w-4" />
-      </button>
-      <button
-        aria-label="Duplicate"
-        className="tooltip-trigger rounded-md p-1.5 text-muted-foreground transition-colors hover:bg-accent hover:text-foreground"
-        onClick={onDuplicate}
-        title="Duplicate"
-        type="button"
-      >
-        <Copy className="h-4 w-4" />
-      </button>
+      {onMove && (
+        <button
+          aria-label="Move"
+          className="tooltip-trigger rounded-md p-1.5 text-muted-foreground transition-colors hover:bg-accent hover:text-foreground"
+          onClick={onMove}
+          title="Move"
+          type="button"
+        >
+          <Move className="h-4 w-4" />
+        </button>
+      )}
+      {onDuplicate && (
+        <button
+          aria-label="Duplicate"
+          className="tooltip-trigger rounded-md p-1.5 text-muted-foreground transition-colors hover:bg-accent hover:text-foreground"
+          onClick={onDuplicate}
+          title="Duplicate"
+          type="button"
+        >
+          <Copy className="h-4 w-4" />
+        </button>
+      )}
       <button
         aria-label="Delete"
         className="tooltip-trigger rounded-md p-1.5 text-muted-foreground transition-colors hover:bg-destructive/10 hover:text-destructive"

From ae54336a07406b800899ff19834674ce5a2a049f Mon Sep 17 00:00:00 2001
From: nnhhoang <hoangnnh67@gmail.com>
Date: Thu, 26 Mar 2026 15:44:33 +0700
Subject: [PATCH 2/2] fix: offset delete button higher on walls/slabs to avoid
 covering measurement labels

---
 .../editor/src/components/editor/floating-action-menu.tsx   | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/packages/editor/src/components/editor/floating-action-menu.tsx b/packages/editor/src/components/editor/floating-action-menu.tsx
index cf727a6e..ed566b79 100644
--- a/packages/editor/src/components/editor/floating-action-menu.tsx
+++ b/packages/editor/src/components/editor/floating-action-menu.tsx
@@ -47,8 +47,10 @@ export function FloatingActionMenu() {
       const box = new THREE.Box3().setFromObject(obj)
       if (!box.isEmpty()) {
         const center = box.getCenter(new THREE.Vector3())
-        // Position slightly above the object
-        groupRef.current.position.set(center.x, box.max.y + 0.3, center.z)
+        // Position above the object, with extra offset for walls/slabs to avoid covering measurement labels
+        const isDeleteOnly = node && DELETE_ONLY_TYPES.includes(node.type)
+        const yOffset = isDeleteOnly ? 0.8 : 0.3
+        groupRef.current.position.set(center.x, box.max.y + yOffset, center.z)
       }
     }
   })