From 17692a7c119b946dd55bdcc1b4f0f315c6d96f84 Mon Sep 17 00:00:00 2001
From: "omegent-app[bot]" <306514130+omegent-app[bot]@users.noreply.github.com>
Date: Thu, 6 Aug 2026 10:43:49 +0000
Subject: [PATCH] ci(fork): drop the edited trigger, it can clear a red PR

#359 added "edited" to the pull_request activity types so that retargeting a PR
would run CI, with a job-level guard skipping edits that did not move the base.
The guard is worse than not triggering at all.

A job skipped by an if condition still publishes a check run, GitHub counts a
skipped required check as satisfied, and the skipped run supersedes the real
one. Editing the title or body of a PR whose checks had failed therefore
replaces those failures with skipped runs and leaves it mergeable. Observed on
#364: after a body edit, all four required checks read "skipping" and
mergeStateStatus was CLEAN.

Keep ready_for_review, which is what actually fixed the case #359 was opened
for: #357 was marked ready after being retargeted, and nothing fired.

Retargeting without a push no longer triggers CI. That is rarer now that
overlays are gone and everything targets fork/dev, and it is recoverable --
close and reopen fires "reopened", which is watched. A gap that needs a
deliberate action to work around is better than a bypass that needs a title edit
to trigger.

Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
---
 .github/workflows/fork-ci.yml | 37 +++++++++++------------------------
 1 file changed, 11 insertions(+), 26 deletions(-)

diff --git a/.github/workflows/fork-ci.yml b/.github/workflows/fork-ci.yml
index a58781e4e07..986761c64ac 100644
--- a/.github/workflows/fork-ci.yml
+++ b/.github/workflows/fork-ci.yml
@@ -32,12 +32,17 @@ on:
   # integrationOverlays is empty: the overlays were drained into fork/dev at
   # cutover. Re-add bases here if one is ever registered again.
   pull_request:
-    # Explicit, because the default set (opened, synchronize, reopened) misses
-    # both ways a PR can become eligible without a new commit: being marked
-    # ready, and being retargeted onto a listed base. A PR retargeted from a
-    # branch this workflow does not watch would otherwise sit forever on
-    # required checks that can never report.
-    types: [opened, synchronize, reopened, ready_for_review, edited]
+    # Explicit, to add ready_for_review: a PR marked ready without a new commit
+    # would otherwise sit forever on required checks that can never report.
+    #
+    # "edited" is deliberately absent. It was added to cover retargeting, but it
+    # also fires for title and body edits, and a job-level guard that skips those
+    # is worse than not triggering: a skipped job still publishes a check run,
+    # GitHub counts a skipped required check as satisfied, and the skipped run
+    # supersedes the real one. Editing the title of a red PR would clear its
+    # failures. Retarget without a push is rarer and recoverable -- close and
+    # reopen fires "reopened", which is watched.
+    types: [opened, synchronize, reopened, ready_for_review]
     branches:
       - fork/base
       - fork/tim
@@ -64,11 +69,6 @@ concurrency:
 jobs:
   check:
     name: Check
-    # "edited" also fires for title and body edits, which must not spend a full
-    # CI run. github.event.changes.base is present only when the base changed.
-    if: >-
-      github.event_name != 'pull_request' || github.event.action != 'edited' ||
-      github.event.changes.base != null
     runs-on: ubuntu-24.04
     timeout-minutes: 10
     steps:
@@ -120,11 +120,6 @@ jobs:
 
   test:
     name: Test
-    # "edited" also fires for title and body edits, which must not spend a full
-    # CI run. github.event.changes.base is present only when the base changed.
-    if: >-
-      github.event_name != 'pull_request' || github.event.action != 'edited' ||
-      github.event.changes.base != null
     runs-on: ubuntu-24.04
     timeout-minutes: 10
     steps:
@@ -148,11 +143,6 @@ jobs:
 
   mobile_native_static_analysis:
     name: Mobile Native Static Analysis
-    # "edited" also fires for title and body edits, which must not spend a full
-    # CI run. github.event.changes.base is present only when the base changed.
-    if: >-
-      github.event_name != 'pull_request' || github.event.action != 'edited' ||
-      github.event.changes.base != null
     runs-on: macos-15
     timeout-minutes: 10
     steps:
@@ -191,11 +181,6 @@ jobs:
 
   release_smoke:
     name: Release Smoke
-    # "edited" also fires for title and body edits, which must not spend a full
-    # CI run. github.event.changes.base is present only when the base changed.
-    if: >-
-      github.event_name != 'pull_request' || github.event.action != 'edited' ||
-      github.event.changes.base != null
     runs-on: ubuntu-24.04
     timeout-minutes: 10
     steps: