refactor(parser): integrate theme registry for styled error rendering in ParseError

Author: dugshub

Makefile

@@ -1,7 +1,7 @@
 # CLI Patterns Makefile
 # Development and testing automation
 
-.PHONY: help install test test-unit test-integration test-coverage test-parser test-executor test-design test-fast test-components lint type-check format clean clean-docker all quality format-check ci-setup ci-native ci-docker verify-sync benchmark test-all ci-summary
+.PHONY: help install test test-unit test-integration test-coverage test-parser test-executor test-design test-fast test-components lint lint-fix type-check format clean clean-docker all quality format-check ci-setup ci-native ci-docker verify-sync benchmark test-all ci-summary
 
 # Default target
 help:
@@ -18,6 +18,7 @@ help:
 	@echo "make test-fast     - Run non-slow tests only"
 	@echo "make test-components - Run all component tests (parser, executor, design)"
 	@echo "make lint          - Run ruff linter"
+	@echo "make lint-fix      - Run ruff linter and auto-fix issues"
 	@echo "make type-check    - Run mypy type checking"
 	@echo "make format        - Format code with black"
 	@echo "make clean         - Remove build artifacts and cache"
@@ -79,6 +80,14 @@ lint:
 		ruff check src/ tests/; \
 	fi
 
+# Lint code and auto-fix issues
+lint-fix:
+	@if command -v uv > /dev/null 2>&1; then \
+		uv run ruff check src/ tests/ --fix; \
+	else \
+		ruff check src/ tests/ --fix; \
+	fi
+
 # Type check with mypy
 type-check:
 	@if command -v uv > /dev/null 2>&1; then \

src/cli_patterns/ui/parser/types.py

@@ -8,6 +8,7 @@
 from rich.console import Group, RenderableType
 from rich.text import Text
 
+from cli_patterns.ui.design.registry import theme_registry
 from cli_patterns.ui.design.tokens import HierarchyToken, StatusToken
 
 if TYPE_CHECKING:
@@ -92,6 +93,9 @@ def has_flag(self, flag: str) -> bool:
 class ParseError(Exception):
     """Exception raised during command parsing.
 
+    This class implements the Rich __rich__() protocol for automatic themed display
+    when printed to a Rich console. Use console.print(error) for best results.
+
     Attributes:
         message: Human-readable error message
         error_type: Type of parsing error
@@ -123,26 +127,29 @@ def __str__(self) -> str:
     def __rich__(self) -> RenderableType:
         """Rich rendering protocol implementation for automatic themed display.
 
+        Uses the global theme_registry to resolve design tokens to themed styles,
+        ensuring consistency with the application's design system.
+
         Returns:
             RenderableType (Group) containing styled error message and suggestions
         """
         # Map error_type to StatusToken
         status_token = self._get_status_token()
 
-        # Create styled error message
+        # Create styled error message using theme registry
         error_text = Text()
         error_text.append(
-            f"{self.error_type}: ", style=self._get_status_style(status_token)
+            f"{self.error_type}: ", style=theme_registry.resolve(status_token)
         )
         error_text.append(self.message)
 
         # Create suggestions list with hierarchy styling (limit to 3)
         renderables: list[RenderableType] = [error_text]
 
         if self.suggestions:
-            # Add "Did you mean:" prompt
+            # Add "Did you mean:" prompt using theme registry
             prompt_text = Text(
-                "\n\nDid you mean:", style=self._get_status_style(StatusToken.INFO)
+                "\n\nDid you mean:", style=theme_registry.resolve(StatusToken.INFO)
             )
             renderables.append(prompt_text)
 
@@ -151,7 +158,7 @@ def __rich__(self) -> RenderableType:
                 hierarchy = self._get_suggestion_hierarchy(idx)
                 suggestion_text = Text()
                 suggestion_text.append(
-                    f"\n  • {suggestion}", style=self._get_hierarchy_style(hierarchy)
+                    f"\n  • {suggestion}", style=theme_registry.resolve(hierarchy)
                 )
                 renderables.append(suggestion_text)
 
@@ -185,6 +192,9 @@ def _get_status_token(self) -> StatusToken:
     def _get_suggestion_hierarchy(self, index: int) -> HierarchyToken:
         """Get hierarchy token for suggestion based on ranking.
 
+        The first suggestion is PRIMARY (best match), second is SECONDARY (good match),
+        and third is TERTIARY (possible match).
+
         Args:
             index: Position in suggestions list (0-based)
 
@@ -198,50 +208,6 @@ def _get_suggestion_hierarchy(self, index: int) -> HierarchyToken:
         else:
             return HierarchyToken.TERTIARY  # Possible match
 
-    def _get_status_style(self, status: StatusToken) -> str:
-        """Get Rich style string for StatusToken.
-
-        Args:
-            status: StatusToken to convert to style
-
-        Returns:
-            Rich style string
-        """
-        if status == StatusToken.ERROR:
-            return "bold red"
-        elif status == StatusToken.WARNING:
-            return "bold yellow"
-        elif status == StatusToken.INFO:
-            return "blue"
-        elif status == StatusToken.SUCCESS:
-            return "bold green"
-        elif status == StatusToken.RUNNING:
-            return "cyan"
-        elif status == StatusToken.MUTED:
-            return "dim"
-        else:
-            return "default"
-
-    def _get_hierarchy_style(self, hierarchy: HierarchyToken) -> str:
-        """Get Rich style string for HierarchyToken.
-
-        Args:
-            hierarchy: HierarchyToken to convert to style
-
-        Returns:
-            Rich style string
-        """
-        if hierarchy == HierarchyToken.PRIMARY:
-            return "bold"
-        elif hierarchy == HierarchyToken.SECONDARY:
-            return "default"
-        elif hierarchy == HierarchyToken.TERTIARY:
-            return "dim"
-        elif hierarchy == HierarchyToken.QUATERNARY:
-            return "dim italic"
-        else:
-            return "default"
-
 
 @dataclass
 class Context:

tests/unit/ui/parser/test_types.py

@@ -722,35 +722,63 @@ def test_suggestion_hierarchy_third_is_tertiary(self) -> None:
         hierarchy = error._get_suggestion_hierarchy(2)
         assert hierarchy == HierarchyToken.TERTIARY
 
-    def test_status_style_error(self) -> None:
-        """Test ERROR status maps to correct style."""
-        error = ParseError("TEST", "Test", [])
-        style = error._get_status_style(StatusToken.ERROR)
-        assert "red" in style
-
-    def test_status_style_warning(self) -> None:
-        """Test WARNING status maps to correct style."""
-        error = ParseError("TEST", "Test", [])
-        style = error._get_status_style(StatusToken.WARNING)
-        assert "yellow" in style
-
-    def test_status_style_info(self) -> None:
-        """Test INFO status maps to correct style."""
-        error = ParseError("TEST", "Test", [])
-        style = error._get_status_style(StatusToken.INFO)
-        assert "blue" in style
-
-    def test_hierarchy_style_primary(self) -> None:
-        """Test PRIMARY hierarchy maps to bold style."""
-        error = ParseError("TEST", "Test", [])
-        style = error._get_hierarchy_style(HierarchyToken.PRIMARY)
-        assert "bold" in style
-
-    def test_hierarchy_style_tertiary(self) -> None:
-        """Test TERTIARY hierarchy maps to dim style."""
-        error = ParseError("TEST", "Test", [])
-        style = error._get_hierarchy_style(HierarchyToken.TERTIARY)
-        assert "dim" in style
+    def test_theme_registry_integration_status_tokens(self) -> None:
+        """Test that __rich__() uses theme_registry for StatusToken styling."""
+        from cli_patterns.ui.design.registry import theme_registry
+
+        error = ParseError(
+            error_type="SYNTAX_ERROR",
+            message="Test theme integration",
+            suggestions=[],
+        )
+
+        # Get the status token and verify it can be resolved
+        status = error._get_status_token()
+        style = theme_registry.resolve(status)
+
+        # Verify theme registry returns a valid style string
+        assert isinstance(style, str)
+        assert len(style) > 0
+
+    def test_theme_registry_integration_hierarchy_tokens(self) -> None:
+        """Test that __rich__() uses theme_registry for HierarchyToken styling."""
+        from cli_patterns.ui.design.registry import theme_registry
+
+        error = ParseError(
+            error_type="TEST",
+            message="Test hierarchy styling",
+            suggestions=["First", "Second", "Third"],
+        )
+
+        # Get hierarchy tokens and verify they can be resolved
+        for idx in range(3):
+            hierarchy = error._get_suggestion_hierarchy(idx)
+            style = theme_registry.resolve(hierarchy)
+
+            # Verify theme registry returns a valid style string
+            assert isinstance(style, str)
+            assert len(style) > 0
+
+    def test_theme_registry_integration_in_rich_output(self) -> None:
+        """Test that Rich rendering uses theme_registry resolved styles."""
+        error = ParseError(
+            error_type="THEME_TEST",
+            message="Testing theme registry integration",
+            suggestions=["Suggestion 1"],
+        )
+
+        # Render with Rich
+        result = error.__rich__()
+        assert isinstance(result, Group)
+
+        # Verify the error can be printed (theme resolution doesn't throw)
+        console = Console()
+        with console.capture() as capture:
+            console.print(error)
+        output = capture.get()
+
+        assert "THEME_TEST" in output
+        assert "Testing theme registry integration" in output
 
     def test_rich_rendering_with_console_print(self) -> None:
         """Test that ParseError can be directly printed to Rich console."""