Session Persistence Tracking Issue (0.24)

[arminsabouri]

Items that need to be addressed before the 0.24 release

• Replace Persister with SessionPersister for v2 Sender #789
• Name audit for 0.24 release #803
• expose fallback tx using receiver session history object #798
• Sender session history fallback #805
• Exclude closed session from get session ids method #806
• Refactor Receiver Replyable Error #793

Tech debt items

• Remove receiver UniFFI IntoUrl error variant
• All state transition methods must consume self #1050
• use sealed traits for State traits #747
• Remove to/from json methods from uniffi exported typestates #834
• Remove UniFFI uninit receiver new constructor
• De-dup pj_uri construction in receiver session history #804
• Monitoring Receiver Typestate #807

[benalleng]

The constructor is the comment just above.

This constructor isn't used anywhere right? We can just pull it out?

[arminsabouri]

The constructor is the comment just above.

This constructor isn't used anywhere right? We can just pull it out?

No it is used. https://github.com/payjoin/rust-payjoin/blob/master/payjoin-ffi/python/test/test_payjoin_unit_test.py#L53

create_session can't be used as a constructor because it doesnt return Self. This is probably fine as is (with the cunstructor). The other solution is to remove this type state from uniffi and introduce a slight asymmetry.

[arminsabouri]

All of the sub issues for this ticket are in the 1.0 milestone. Closing the tracking issue.