From 9094e0340a547d240c416626f94e08e3ceb12805 Mon Sep 17 00:00:00 2001 From: oyindamola oladapo Date: Tue, 3 Jun 2025 20:52:31 +0100 Subject: [PATCH 1/2] docs: update links to reference BIP-77 document added missed reference --- README.md | 2 +- payjoin-cli/README.md | 2 +- payjoin-directory/README.md | 2 +- payjoin-ffi/src/receive/mod.rs | 2 +- payjoin-ffi/src/receive/uni.rs | 2 +- payjoin/src/lib.rs | 2 +- payjoin/src/receive/v2/mod.rs | 2 +- payjoin/src/send/v2/mod.rs | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index ef8b41d3f..e0c1eee0c 100644 --- a/README.md +++ b/README.md @@ -24,7 +24,7 @@ ### `payjoin` -The Payjoin Dev Kit `payjoin` library implements both [BIP 78 Payjoin V1](https://github.com/bitcoin/bips/blob/master/bip-0078.mediawiki) and [BIP 77 Payjoin V2](https://github.com/bitcoin/bips/pull/1483). +The Payjoin Dev Kit `payjoin` library implements both [BIP 78 Payjoin V1](https://github.com/bitcoin/bips/blob/master/bip-0078.mediawiki) and [BIP 77 Payjoin V2](https://github.com/bitcoin/bips/blob/master/bip-0077.md). ### `payjoin-cli` diff --git a/payjoin-cli/README.md b/payjoin-cli/README.md index d453cb868..ab194f591 100644 --- a/payjoin-cli/README.md +++ b/payjoin-cli/README.md @@ -6,7 +6,7 @@ It enables sending and receiving [BIP 78 Payjoin (v1)](https://github.com/bitcoin/bips/blob/master/bip-0078.mediawiki) and [Draft -BIP 77 Async Payjoin (v2)](https://github.com/bitcoin/bips/pull/1483) +BIP 77 Async Payjoin (v2)](https://github.com/bitcoin/bips/blob/master/bip-0077.md) transactions via `bitcoind`. By default it supports Payjoin v2, which is backwards compatible with v1. Enable the `v1` feature to disable Payjoin v2 to send and receive using only v1. diff --git a/payjoin-directory/README.md b/payjoin-directory/README.md index bff577b30..d040cf653 100644 --- a/payjoin-directory/README.md +++ b/payjoin-directory/README.md @@ -1,6 +1,6 @@ # Payjoin Directory -[BIP 77](https://github.com/bitcoin/bips/pull/1483) Async Payjoin (v2) +[BIP 77](https://github.com/bitcoin/bips/blob/master/bip-0077.md) Async Payjoin (v2) peers store and forward HTTP client messages via a directory server in order to make asynchronous Payjoin transactions. This is a reference implementation of such a server diff --git a/payjoin-ffi/src/receive/mod.rs b/payjoin-ffi/src/receive/mod.rs index acec28ab0..7dcc5fef9 100644 --- a/payjoin-ffi/src/receive/mod.rs +++ b/payjoin-ffi/src/receive/mod.rs @@ -44,7 +44,7 @@ impl NewReceiver { /// A new instance of [`NewReceiver`]. /// /// # References - /// - [BIP 77: Payjoin Version 2: Serverless Payjoin](https://github.com/bitcoin/bips/pull/1483) + /// - [BIP 77: Payjoin Version 2: Serverless Payjoin](https://github.com/bitcoin/bips/blob/master/bip-0077.md) pub fn new( address: Address, directory: String, diff --git a/payjoin-ffi/src/receive/uni.rs b/payjoin-ffi/src/receive/uni.rs index 5bb2865db..997a0b375 100644 --- a/payjoin-ffi/src/receive/uni.rs +++ b/payjoin-ffi/src/receive/uni.rs @@ -35,7 +35,7 @@ impl NewReceiver { /// A new instance of [`NewReceiver`]. /// /// # References - /// - [BIP 77: Payjoin Version 2: Serverless Payjoin](https://github.com/bitcoin/bips/pull/1483) + /// - [BIP 77: Payjoin Version 2: Serverless Payjoin](https://github.com/bitcoin/bips/blob/master/bip-0077.md) #[uniffi::constructor] pub fn new( address: Arc
, diff --git a/payjoin/src/lib.rs b/payjoin/src/lib.rs index 98f9af199..10836459e 100644 --- a/payjoin/src/lib.rs +++ b/payjoin/src/lib.rs @@ -4,7 +4,7 @@ //! //! Supercharge payment batching to save you fees and preserve your privacy. //! -//! This library implements both [BIP 78 Payjoin V1](https://github.com/shesek/bips/blob/master/bip-0078.mediawiki) and [BIP 77 Payjoin V2](https://github.com/bitcoin/bips/pull/1483). +//! This library implements both [BIP 78 Payjoin V1](https://github.com/shesek/bips/blob/master/bip-0078.mediawiki) and [BIP 77 Payjoin V2](https://github.com/bitcoin/bips/blob/master/bip-0077.md). //! //! Only the latest BIP 77 Payjoin V2 is enabled by default. To use BIP 78 Payjoin V1, enable the `v1` feature. //! diff --git a/payjoin/src/receive/v2/mod.rs b/payjoin/src/receive/v2/mod.rs index ec109a11e..1477dc8f9 100644 --- a/payjoin/src/receive/v2/mod.rs +++ b/payjoin/src/receive/v2/mod.rs @@ -95,7 +95,7 @@ impl NewReceiver { /// A new instance of [`NewReceiver`]. /// /// # References - /// - [BIP 77: Payjoin Version 2: Serverless Payjoin](https://github.com/bitcoin/bips/pull/1483) + /// - [BIP 77: Payjoin Version 2: Serverless Payjoin](https://github.com/bitcoin/bips/blob/master/bip-0077.md) pub fn new( address: Address, directory: impl IntoUrl, diff --git a/payjoin/src/send/v2/mod.rs b/payjoin/src/send/v2/mod.rs index 9d7d6030c..20eb9ae26 100644 --- a/payjoin/src/send/v2/mod.rs +++ b/payjoin/src/send/v2/mod.rs @@ -1,7 +1,7 @@ //! Send BIP 77 Payjoin v2 //! //! This module contains types and methods used to implement sending via [BIP77 -//! Payjoin](https://github.com/bitcoin/bips/pull/1483). +//! Payjoin](https://github.com/bitcoin/bips/blob/master/bip-0077.md). //! //! Usage is pretty simple: //! From afcb9f38aa2a930e73980f0bab3de03e32ca49a3 Mon Sep 17 00:00:00 2001 From: spacebear Date: Tue, 3 Jun 2025 17:05:32 -0400 Subject: [PATCH 2/2] Update BIP78 link to reference bitcoin/bips repo --- payjoin/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/payjoin/src/lib.rs b/payjoin/src/lib.rs index 10836459e..6c2ca85d1 100644 --- a/payjoin/src/lib.rs +++ b/payjoin/src/lib.rs @@ -4,7 +4,7 @@ //! //! Supercharge payment batching to save you fees and preserve your privacy. //! -//! This library implements both [BIP 78 Payjoin V1](https://github.com/shesek/bips/blob/master/bip-0078.mediawiki) and [BIP 77 Payjoin V2](https://github.com/bitcoin/bips/blob/master/bip-0077.md). +//! This library implements both [BIP 78 Payjoin V1](https://github.com/bitcoin/bips/blob/master/bip-0078.mediawiki) and [BIP 77 Payjoin V2](https://github.com/bitcoin/bips/blob/master/bip-0077.md). //! //! Only the latest BIP 77 Payjoin V2 is enabled by default. To use BIP 78 Payjoin V1, enable the `v1` feature. //!