[DF] Fix contiguousness check, take #2

eguiraud · eguiraud · commit 941bd2fb5342 · 2020-06-07T13:29:30.000+02:00
diff --git a/tree/dataframe/inc/ROOT/RDF/RColumnValue.hxx b/tree/dataframe/inc/ROOT/RDF/RColumnValue.hxx
@@ -187,7 +187,7 @@ public:
             // We can decide since the array is long enough
             fStorageType = EStorageType::kContiguous;
             for (auto i = 0u; i < arrSize - 1; ++i) {
-               if ((char *)&readerArray[i + 1] - (char *)&readerArray[i] != sizeof(T)) {
+               if ((char *)&readerArray[i + 1] - (char *)&readerArray[i] != sizeof(typename U::value_type)) {
                   fStorageType = EStorageType::kSparse;
                   break;
                }

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ public:`
`187`	`187`	`// We can decide since the array is long enough`
`188`	`188`	`fStorageType = EStorageType::kContiguous;`
`189`	`189`	`for (auto i = 0u; i < arrSize - 1; ++i) {`
`190`		`- if ((char )&readerArray[i + 1] - (char )&readerArray[i] != sizeof(T)) {`
	`190`	`+ if ((char )&readerArray[i + 1] - (char )&readerArray[i] != sizeof(typename U::value_type)) {`
`191`	`191`	`fStorageType = EStorageType::kSparse;`
`192`	`192`	`break;`
`193`	`193`	`}`