Fix styling

Author: pedrosalpr

src/Commands/LaravelApiProblemCommand.php

@@ -23,7 +23,7 @@ protected function resolveStubPath(string $stub): string
     {
         return file_exists($customPath = $this->laravel->basePath(trim($stub, '/')))
             ? $customPath
-            : __DIR__ . $stub;
+            : __DIR__.$stub;
     }
 
     protected function getDefaultNamespace($rootNamespace): string

src/Commands/LaravelApiProblemExceptionCommand.php

@@ -24,7 +24,7 @@ protected function resolveStubPath(string $stub): string
     {
         return file_exists($customPath = $this->laravel->basePath(trim($stub, '/')))
             ? $customPath
-            : __DIR__ . $stub;
+            : __DIR__.$stub;
     }
 
     protected function getDefaultNamespace($rootNamespace): string
@@ -34,7 +34,7 @@ protected function getDefaultNamespace($rootNamespace): string
 
     protected function replaceClass($stub, $name)
     {
-        $class = str_replace($this->getNamespace($name) . '\\', '', $name);
+        $class = str_replace($this->getNamespace($name).'\\', '', $name);
 
         // Do string replacement
         return str_replace('{{ class }}', $class, $stub);

src/Http/LaravelHttpApiProblem.php

@@ -72,7 +72,7 @@ public function __construct(
         if ($this->statusCode < 400 || $this->statusCode > 599) {
             $this->statusCode = 400;
         }
-        if (!filter_var($this->type, FILTER_VALIDATE_URL) || empty($this->title)) {
+        if (! filter_var($this->type, FILTER_VALIDATE_URL) || empty($this->title)) {
             $this->title = $this->getTitleForStatusCode($this->statusCode);
             $this->type = self::TYPE_ABOUT_BLANK;
         }
@@ -118,7 +118,7 @@ public function toArray(): array
                 'title' => $this->title,
                 'detail' => $this->detail,
                 'instance' => $this->instance,
-                'timestamp' => $this->timestamp->toJSON()
+                'timestamp' => $this->timestamp->toJSON(),
             ],
             $this->extensions
         );

src/LaravelApiProblem.php

@@ -27,6 +27,7 @@ public function __construct(
         if ($exception instanceof LaravelApiProblemException) {
             $this->apiProblemException = $exception;
             $this->apiProblemException();
+
             return;
         }
         match (get_class($exception)) {
@@ -40,8 +41,6 @@ public function __construct(
 
     /**
      * Render the exception as an HTTP response.
-     *
-     * @return JsonResponse
      */
     public function render(): JsonResponse
     {
@@ -56,8 +55,6 @@ public function render(): JsonResponse
 
     /**
      * Debug the class in array to view more details, such as: api problem and exception
-     *
-     * @return array
      */
     public function toDebuggableArray(): array
     {
@@ -82,8 +79,6 @@ public function toDebuggableArray(): array
 
     /**
      * Transform any exception into an http api problem with status code
-     *
-     * @param null|int $statusCode
      */
     protected function default(?int $statusCode = null): void
     {
@@ -105,7 +100,7 @@ protected function validation(): void
         $extensions = [
             'errors' => ($this->exception instanceof ValidationException)
                 ? $this->exception->errors()
-                : null
+                : null,
         ];
         $this->apiProblem = new LaravelHttpApiProblem(
             Response::HTTP_UNPROCESSABLE_ENTITY,
@@ -132,8 +127,6 @@ protected function apiProblemException(): void
 
     /**
      * Get uri as instance
-     *
-     * @return string
      */
     protected function getUriInstance(): string
     {
@@ -142,30 +135,25 @@ protected function getUriInstance(): string
 
     /**
      * Get the context if it exists within the exception and return it as an extension
-     *
-     * @return array
      */
     protected function getContextExceptionAsExtensions(): array
     {
         $extensions = [];
-        if (!method_exists($this->exception, 'context')) {
+        if (! method_exists($this->exception, 'context')) {
             return $extensions;
         }
         $context = $this->exception->context();
         if (is_array($context)) {
             $extensions = $context;
-        } elseif (!empty($context)) {
+        } elseif (! empty($context)) {
             $extensions = [$context];
         }
+
         return $extensions;
     }
 
     /**
      * Gets the status code from the exception code, or from the HttpException Interface, otherwise it returns an Internal Server Error
-     *
-     * @param null|int $code
-     *
-     * @return int
      */
     protected function getStatusCode(?int $code): int
     {
@@ -177,17 +165,14 @@ protected function getStatusCode(?int $code): int
                 ? $this->exception->getStatusCode()
                 : Response::HTTP_INTERNAL_SERVER_ERROR;
         }
+
         return ($this->isStatusCodeInternalOrServerError($this->exception->getCode()))
         ? $this->exception->getCode()
         : Response::HTTP_INTERNAL_SERVER_ERROR;
     }
 
     /**
      * Checks if the status code is of the integer type and is in the range of Client and Server Errors
-     *
-     * @param null|int $statusCode
-     *
-     * @return bool
      */
     protected function isStatusCodeInternalOrServerError(?int $statusCode): bool
     {
@@ -196,10 +181,6 @@ protected function isStatusCodeInternalOrServerError(?int $statusCode): bool
 
     /**
      * Serialize the exception into an array
-     *
-     * @param \Throwable $throwable
-     *
-     * @return array
      */
     private function serializeException(\Throwable $throwable): array
     {

tests/Feature/ApiProblemTest.php

@@ -2,14 +2,16 @@
 
 declare(strict_types=1);
 
-use function Pest\Laravel\{getJson, postJson};
-use Illuminate\Auth\AuthenticationException;
 use Illuminate\Auth\Access\AuthorizationException;
+use Illuminate\Auth\AuthenticationException;
 use Illuminate\Http\Response;
 use Illuminate\Support\Facades\Route;
 use Pedrosalpr\LaravelApiProblem\Tests\Handlers\TestExceptionHandler;
 use Symfony\Component\HttpKernel\Exception\HttpException;
 
+use function Pest\Laravel\getJson;
+use function Pest\Laravel\postJson;
+
 // Antes de cada teste, substitua o manipulador de exceções do Laravel
 // pelo seu manipulador de exceções de teste.
 beforeEach(function () {
@@ -82,8 +84,6 @@
         ]);
 });
 
-
-
 test('method not allowed exception returns 405 problem json', function () {
     // Definir uma rota que só aceita POST
     Route::post('/api/only-post', fn () => ['message' => 'success']);
@@ -114,8 +114,6 @@
         ]);
 });
 
-
-
 test('http exception returns correct problem json', function () {
     Route::get('/api/custom-error', function () {
         throw new HttpException(Response::HTTP_UNAUTHORIZED, 'You do not have permission.');

tests/Handlers/TestExceptionHandler.php

@@ -4,10 +4,10 @@
 
 namespace Pedrosalpr\LaravelApiProblem\Tests\Handlers;
 
+use Illuminate\Auth\Access\AuthorizationException;
+use Illuminate\Auth\AuthenticationException;
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
 use Illuminate\Http\Response;
-use Illuminate\Auth\AuthenticationException;
-use Illuminate\Auth\Access\AuthorizationException;
 use Illuminate\Validation\ValidationException;
 use Pedrosalpr\LaravelApiProblem\Http\LaravelHttpApiProblem;
 use Throwable;
@@ -21,12 +21,14 @@ public function render($request, Throwable $e)
 
         if ($e instanceof AuthenticationException) {
             $problem = new LaravelHttpApiProblem(Response::HTTP_UNAUTHORIZED, $e->getMessage(), $instance);
+
             return response()->json($problem->toArray(), $problem->getStatusCode())
                 ->withHeaders(['Content-Type' => $problem->getHeaderProblemJson()]);
         }
 
         if ($e instanceof AuthorizationException) {
             $problem = new LaravelHttpApiProblem(Response::HTTP_FORBIDDEN, $e->getMessage(), $instance);
+
             return response()->json($problem->toArray(), $problem->getStatusCode())
                 ->withHeaders(['Content-Type' => $problem->getHeaderProblemJson()]);
         }
@@ -36,6 +38,7 @@ public function render($request, Throwable $e)
             $statusCode = $e->getStatusCode();
             $title = Response::$statusTexts[$statusCode] ?? 'Unknown Error';
             $problem = new LaravelHttpApiProblem($statusCode, $e->getMessage(), $instance, title: $title);
+
             return response()->json($problem->toArray(), $problem->getStatusCode())
                 ->withHeaders(['Content-Type' => $problem->getHeaderProblemJson()]);
         }
@@ -47,6 +50,7 @@ public function render($request, Throwable $e)
                 instance: $instance,
                 extensions: ['errors' => $e->errors()]
             );
+
             return response()->json($problem->toArray(), $problem->getStatusCode())
                 ->withHeaders(['Content-Type' => $problem->getHeaderProblemJson()]);
         }

tests/Unit/ApiProblemTest.php

@@ -3,8 +3,6 @@
 declare(strict_types=1);
 
 use Pedrosalpr\LaravelApiProblem\Http\LaravelHttpApiProblem;
-use Pedrosalpr\LaravelApiProblem\Tests\TestCase;
-use function Pest\Laravel\{getJson, postJson};
 
 test('it can be instantiated with required arguments', function () {
     $problem = new LaravelHttpApiProblem(
@@ -64,7 +62,7 @@
 test('it includes extensions in the problem detail', function () {
     $extensions = [
         'trace_id' => '1a2b3c4d5e',
-        'app_code' => 'AUTH-001'
+        'app_code' => 'AUTH-001',
     ];
 
     $problem = new LaravelHttpApiProblem(