Support for multi-parents ?

[Joxit]

I was working on this project and I saw this message :

model/Document.js

Lines 345 to 368 in 37c4330

	/**
	note: the rationale for setting this field as 'null' instead of 'undefined'
	is so that each of the fields 'line-up'.
	== if you add a parent property with no abbreviation, as such:
	addParent( 'region', 'foobar', '1' )
	doc:
	parent.region = [ 'foobar' ]
	parent.region_id = [ '1' ]
	parent.region_a = [ null ]
	== and then you add another parent property such as:
	addParent( 'region', 'bingobango', '2', 'bingo' )
	doc:
	parent.region = [ 'foobar', 'bingobango' ]
	parent.region_id = [ '1', '2' ]
	parent.region_a = [ null, 'bingo' ]
	== you can now be sure that the abbreviation 'bingo' belongs to '2' and not '1'.
	**/

I thought it was a pretty cool feature but when I saw this piece of code I thought it wasn't really going to work ...

model/Document.js

Lines 321 to 332 in 37c4330

	var add = function( prop, value ){
	// create new parent array if required
	if( !this.parent.hasOwnProperty( prop ) ){
	this.parent[ prop ] = [];
	}
	// add value to array if not already present
	if( -1 === this.parent[prop].indexOf(value) ){
	this.parent[prop].push(value);
	}
	}.bind(this);

This does not really work as expected. For example in this example, the second London and LD will not be added and this can be an wired 🤔. (osm:locality:4004 with no name)

  var doc = new Document( 'geoname', 'venue', 1003 )
      .setCentroid({ lon: 0.5, lat: 50.1 })
      .addParent( 'locality', 'London', '3003', 'LD', 'whosonfirst' )
      .addParent( 'locality', 'London', '4004', 'LD', 'osm' )