Merge pull request #153 from timlegge/master

Fixes #152 - Incorrect id set on messages from XML

Author: timlegge

lib/Net/SAML2/Protocol/Assertion.pm

@@ -176,6 +176,7 @@ sub new_from_xml {
     }
 
     my $self = $class->new(
+        id             => $xpath->findvalue('//saml:Assertion/@ID'),
         issuer         => $xpath->findvalue('//saml:Assertion/saml:Issuer'),
         destination    => $xpath->findvalue('/samlp:Response/@Destination'),
         attributes     => $attributes,

t/03-assertions.t

@@ -68,6 +68,10 @@ XML
 my $assertion = Net::SAML2::Protocol::Assertion->new_from_xml(xml => $xml);
 isa_ok($assertion, 'Net::SAML2::Protocol::Assertion');
 
+is($assertion->{id},
+    "s241001b6007d1700109a3e3bc4350ae5528ba9824",
+    "Assertion id is as expected");
+
 is($assertion->in_response_to, 'N3k95Hg41WCHdwc9mqXynLPhB');
 
 is(scalar keys %{ $assertion->attributes }, 2);
@@ -128,6 +132,10 @@ is($assertion->nameid_sp_provided_id,
     undef,
     "nameid_sp_provided_id undefined as expected");
 
+is($assertion->id,
+    "_61f377717caad87ce2af0e7946cb97b1",
+    "Assertion id is as expected");
+
 lives_ok(
     sub {
        my  $xml = path('t/data/eherkenning-assertion.xml')->slurp;

t/05-soap-binding.t

@@ -43,6 +43,7 @@ my $request
 
 isa_ok($request, "Net::SAML2::Protocol::LogoutRequest");
 my $request_xml = $request->as_xml;
+my $id = $request->{id};
 
 my $xp = get_xpath($request_xml);
 isa_ok($xp, "XML::LibXML::XPathContext");
@@ -67,6 +68,8 @@ my $soaped_request = Net::SAML2::Protocol::LogoutRequest->new_from_xml(
 );
 isa_ok($soaped_request, 'Net::SAML2::Protocol::LogoutRequest');
 
+is($soaped_request->{id}, $id,
+    "LogoutRequest ID is as expected");
 is($soaped_request->session, $request->session,
     "SOAP session equals request session");
 is($soaped_request->nameid, $request->nameid,