Skip to content

Commit 7243731

Browse files
committed
Note sub-optimal API design
See #115
1 parent 475ddfb commit 7243731

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

bitcoin/core/serialize.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,11 @@ def stream_deserialize(cls, f):
236236

237237
class VectorSerializer(Serializer):
238238
"""Base class for serializers of object vectors"""
239+
240+
# FIXME: stream_(de)serialize don't match the signatures of the base class
241+
# due to the inner_cls parameter. This probably isn't optimal API design
242+
# and should be rethought at some point.
243+
239244
@classmethod
240245
def stream_serialize(cls, inner_cls, objs, f):
241246
VarIntSerializer.stream_serialize(len(objs), f)

0 commit comments

Comments
 (0)