Miscellaneous code modernizations (shssoichiro#97)

* Remove `extern crate bitflags`

* Use `use` to rename dependency in examples

* Remove more useless `extern crate`

* delete empty file

* remove macro_use where possible

removing macro_export would be good too, but is breaking

* run cargo fmt after changes

* fix new clippy lint

* Make API exports more readable

* Enable too_many_arguments lint

add exception for old API

* Add TODO for safety docs

Author: FreezyLemon

examples/chapters.rs

@@ -1,4 +1,4 @@
-extern crate ffmpeg_the_third as ffmpeg;
+use ffmpeg_the_third as ffmpeg;
 
 use std::env;
 

examples/codec-info.rs

@@ -1,4 +1,4 @@
-extern crate ffmpeg_the_third as ffmpeg;
+use ffmpeg_the_third as ffmpeg;
 
 use std::env;
 

examples/dump-frames.rs

@@ -1,4 +1,4 @@
-extern crate ffmpeg_the_third as ffmpeg;
+use ffmpeg_the_third as ffmpeg;
 
 use crate::ffmpeg::format::{input, Pixel};
 use crate::ffmpeg::media::Type;

examples/metadata.rs

@@ -1,4 +1,4 @@
-extern crate ffmpeg_the_third as ffmpeg;
+use ffmpeg_the_third as ffmpeg;
 
 use std::env;
 

examples/remux.rs

@@ -1,4 +1,4 @@
-extern crate ffmpeg_the_third as ffmpeg;
+use ffmpeg_the_third as ffmpeg;
 
 use std::env;
 

examples/transcode-audio.rs

@@ -1,4 +1,4 @@
-extern crate ffmpeg_the_third as ffmpeg;
+use ffmpeg_the_third as ffmpeg;
 
 use std::env;
 use std::path::Path;

examples/transcode-x264.rs

@@ -15,7 +15,7 @@
 //   transcode-x264 input.flv output.mp4
 //   transcode-x264 input.mkv output.mkv 'preset=veryslow,crf=18'
 
-extern crate ffmpeg_the_third as ffmpeg;
+use ffmpeg_the_third as ffmpeg;
 
 use std::collections::HashMap;
 use std::env;

ffmpeg-sys-the-third/build.rs

@@ -1,8 +1,3 @@
-extern crate bindgen;
-extern crate cc;
-extern crate clang;
-extern crate pkg_config;
-
 use std::collections::HashMap;
 use std::env;
 use std::fmt::Write as FmtWrite;
@@ -634,7 +629,7 @@ fn rustc_link_extralibs(source_dir: &Path) {
         .map(|line| line.unwrap())
         .unwrap();
 
-    let linker_args = extra_libs.split('=').last().unwrap().split(' ');
+    let linker_args = extra_libs.split('=').next_back().unwrap().split(' ');
     let include_libs = linker_args
         .filter(|v| v.starts_with("-l"))
         .map(|flag| &flag[2..]);

ffmpeg-sys-the-third/src/avutil/pixfmt.rs

@@ -1,7 +1,7 @@
 use libc::c_int;
 
-use crate::{AVChromaLocation, AVPixelFormat};
 use crate::AVPixelFormat::*;
+use crate::{AVChromaLocation, AVPixelFormat};
 
 impl AVChromaLocation {
     pub fn from_c_int(n: c_int) -> Option<Self> {

ffmpeg-sys-the-third/src/lib.rs

@@ -7,8 +7,6 @@
 #![allow(clippy::too_many_arguments)]
 #![allow(clippy::type_complexity)]
 
-extern crate libc;
-
 include!(concat!(env!("OUT_DIR"), "/bindings.rs"));
 
 mod avutil;