fix code for phpstan

Author: gregor-j

src/Traits/ConfigTrait.php

@@ -70,6 +70,7 @@ private function getCommonConfig(IConfiguration $config): array
         if ($config->getLang() !== null) {
             $common['lang'] = $config->getLang();
         }
+        //mandatory configuration parameters
         $common['client'] = $config->getClient();
         $common['user'] = $config->getUser();
         $common['passwd'] = $config->getPasswd();
@@ -95,6 +96,7 @@ private function getTypeAConfig(IConfigTypeA $config): array
         if ($config->getGwserv() !== null) {
             $typeA['gwserv'] = $config->getGwserv();
         }
+        //mandatory configuration parameters
         $typeA['ashost'] = $config->getAshost();
         $typeA['sysnr']  = $config->getSysnr();
         return $typeA;
@@ -119,6 +121,7 @@ private function getTypeBConfig(IConfigTypeB $config): array
         if ($config->getGroup() !== null) {
             $typeB['group'] = $config->getGroup();
         }
+        //mandatory configuration parameter
         $typeB['mshost'] = $config->getMshost();
         return $typeB;
     }

src/Traits/ParamTrait.php

@@ -4,6 +4,9 @@
 
 namespace phpsap\saprfc\Traits;
 
+use phpsap\classes\Api\Struct;
+use phpsap\classes\Api\Table;
+use phpsap\classes\Api\Value;
 use phpsap\exceptions\FunctionCallException;
 use phpsap\interfaces\Api\IApiElement;
 use phpsap\interfaces\exceptions\IInvalidArgumentException;
@@ -79,6 +82,7 @@ private function getTableParams(array $tables, array $params): array
     private function castOutput(array $outputs, array $result): array
     {
         $return = [];
+        /** @var Value|Table|Struct $output */
         foreach ($outputs as $output) {
             $key = $output->getName();
             if (array_key_exists($key, $result)) {

tests/OutputTableTest.php

@@ -28,6 +28,9 @@ class OutputTableTest extends AbstractTestCase
 {
     use TestCaseTrait;
 
+    /**
+     * @var array
+     */
     public static array $apiRaw = [
         'ET_API_ANGEBOT_ADRESSE' => [
             'name' => 'ET_API_ANGEBOT_ADRESSE',
@@ -206,9 +209,9 @@ class OutputTableTest extends AbstractTestCase
         ]
     ];
     /**
-     * @var string
+     * @var array
      */
-    public static $apiJson = [
+    public static array $apiJson = [
         0 => [
             'type' => 'table',
             'name' => 'ET_API_ANGEBOT_ADRESSE',
@@ -343,7 +346,7 @@ class OutputTableTest extends AbstractTestCase
     /**
      * Mock the RFC_OUTPUT_TABLE function.
      */
-    public function mockRfcOutputTable()
+    public function mockRfcOutputTable(): void
     {
         //Use an object for connection flag and function name.
         $flags = new stdClass();
@@ -354,9 +357,9 @@ public function mockRfcOutputTable()
         $flags->response = self::$responseRaw;
         $expectedConfig = static::getSampleSapConfig();
         static::mock('\SAPNWRFC\Connection::__construct', static function (array $config, array $options) use ($flags, $expectedConfig) {
+            unset($options);
             if (
-                !is_array($config)
-                || !array_key_exists('ashost', $config)
+                !array_key_exists('ashost', $config)
                 || !array_key_exists('sysnr', $config)
                 || !array_key_exists('client', $config)
                 || !array_key_exists('user', $config)
@@ -373,7 +376,7 @@ public function mockRfcOutputTable()
             $flags->conn = true;
         });
         static::mock('\SAPNWRFC\Connection::close', static function () use ($flags) {
-            //calling \SAPNWRFC\Connection::close twice has to fail
+            //calling \SAPNWRFC\Connection::close() twice has to fail
             if ($flags->conn !== true) {
                 throw new ConnectionException('mock connection already closed!');
             }

tests/SapRfcIntegrationTest.php

@@ -786,7 +786,8 @@ protected function mockFailedRemoteFunctionCallWithParameters()
             }
             return new RemoteFunction($name);
         });
-        static::mock('\SAPNWRFC\RemoteFunction::invoke', static function (array $params, array $options) use ($flags) {
+        static::mock('\SAPNWRFC\RemoteFunction::invoke', static function (array $params, array $options) {
+            unset($params, $options);
             throw new FunctionCallException('mock function call exception!');
         });
     }

tests/helper/SAPNWRFC.php

@@ -178,7 +178,7 @@ public function ping(): bool
     /**
      * Lookup a RFC function and return a RemoteFunction object.
      *
-     * @param string $functionnName Name of the function.
+     * @param string $functionName Name of the function.
      * @param bool   $invalidateCache If true, invalidates the function desc cache.
      *
      * @return RemoteFunction A RemoteFunction class for the RFC function.