phpstan max

Author: AydinHassan

composer.json

@@ -15,10 +15,11 @@
         "php" : ">=7.2",
         "ext-pdo_sqlite": "*",
         "php-school/php-workshop": "dev-master",
-        "hoa/socket": "^1.0"
+        "hoa/socket": "^1.17.05",
+        "phpstan/phpstan": "^0.12.52"
     },
     "require-dev": {
-        "phpunit/phpunit": "^7.0 | ^8.0",
+        "phpunit/phpunit": "^7.0 | ^8.0 ",
         "squizlabs/php_codesniffer": "^3.5"
     },
     "autoload" : {
@@ -42,6 +43,7 @@
         "cs-fix" : [
             "phpcbf src --standard=PSR12 --encoding=UTF-8",
             "phpcbf test --standard=PSR12 --encoding=UTF-8"
-        ]
+        ],
+        "static": "phpstan --ansi analyse --level max src"
     }
 }

composer.lock

@@ -0,0 +1,6 @@
+<?php
+
+declare(strict_types=1);
+
+class_exists(\Hoa\Socket\Connection::class);
+class_exists(\Hoa\Exception::class);

phpstan-bootstrap.php

@@ -0,0 +1,3 @@
+parameters:
+	bootstrapFiles:
+		- phpstan-bootstrap.php

phpstan.neon

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
-<phpunit colors="true">
+<phpunit colors="true" bootstrap="test/bootstrap.php">
     <testsuite name="My PHP Workshop Test Suite">
         <directory>./test</directory>
     </testsuite>

phpunit.xml

@@ -55,7 +55,7 @@ public function getDescription(): string
     }
 
     /**
-     * @return array
+     * @return array<array<string>>
      */
     public function getArgs(): array
     {
@@ -73,12 +73,9 @@ public function getArgs(): array
             $files[] = $file;
         }
 
-        return $files;
+        return [$files];
     }
 
-    /**
-     * @return null
-     */
     public function tearDown(): void
     {
         $this->filesystem->remove($this->getTemporaryPath());
@@ -105,7 +102,7 @@ public function getBannedFunctions(): array
      */
     public function getType(): ExerciseType
     {
-        return ExerciseType::CLI();
+        return new ExerciseType(ExerciseType::CLI);
     }
 
     /**

src/Exercise/ArrayWeGo.php

@@ -28,25 +28,25 @@ public function getDescription(): string
     }
 
     /**
-     * @return array
+     * @return array<array<string>>
      */
     public function getArgs(): array
     {
         $numArgs = rand(0, 10);
 
         $args = [];
         for ($i = 0; $i < $numArgs; $i++) {
-            $args[] = rand(0, 100);
+            $args[] = (string) rand(0, 100);
         }
 
-        return $args;
+        return [$args];
     }
 
     /**
      * @return ExerciseType
      */
     public function getType(): ExerciseType
     {
-        return ExerciseType::CLI();
+        return new ExerciseType(ExerciseType::CLI);
     }
 }

src/Exercise/BabySteps.php

@@ -70,7 +70,7 @@ public function getDescription(): string
     }
 
     /**
-     * @return array
+     * @return array<array<string>>
      */
     public function getArgs(): array
     {
@@ -109,7 +109,7 @@ public function getArgs(): array
             $ext = pathinfo($files[$index], PATHINFO_EXTENSION);
         }
 
-        return [$folder, $ext];
+        return [[$folder, $ext]];
     }
 
     /**
@@ -120,9 +120,6 @@ public function getSolution(): SolutionInterface
         return DirectorySolution::fromDirectory(__DIR__ . '/../../exercises/concerned-about-separation/solution');
     }
 
-    /**
-     * @return null
-     */
     public function tearDown(): void
     {
         $this->filesystem->remove($this->getTemporaryPath());
@@ -134,7 +131,11 @@ public function tearDown(): void
      */
     public function check(Input $input): ResultInterface
     {
-        $statements = $this->parser->parse(file_get_contents($input->getArgument('program')));
+        $statements = $this->parser->parse((string) file_get_contents($input->getRequiredArgument('program')));
+
+        if (null === $statements) {
+            return Failure::fromNameAndReason($this->getName(), 'No code was found');
+        }
 
         $include = null;
         foreach ($statements as $statement) {
@@ -156,6 +157,6 @@ public function check(Input $input): ResultInterface
      */
     public function getType(): ExerciseType
     {
-        return ExerciseType::CLI();
+        return new ExerciseType(ExerciseType::CLI);
     }
 }

src/Exercise/ConcernedAboutSeparation.php

@@ -26,7 +26,7 @@ class DatabaseRead extends AbstractExercise implements ExerciseInterface, Databa
     private $faker;
 
     /**
-     * @var array
+     * @var array{id: int, name: string}
      */
     private $randomRecord;
 
@@ -55,11 +55,11 @@ public function getDescription(): string
     }
 
     /**
-     * @return array
+     * @return array<array<string>>
      */
     public function getArgs(): array
     {
-        return [$this->randomRecord['name']];
+        return [[$this->randomRecord['name']]];
     }
 
     /**
@@ -79,12 +79,11 @@ public function seed(PDO $db): void
             $gender = rand(0, 100) % 2 ? 'male' : 'female';
 
             $stmt->execute([':name' => $name, ':age' => $age, ':gender' => $gender]);
-            $id = $db->lastInsertId();
-            $names[$id] = $name;
+            $names[(int) $db->lastInsertId()] = $name;
         }
 
-        $randomId = array_rand($names);
-        $this->randomRecord = ['id' => $randomId, 'name' => $names[$randomId]];
+        $randomId = (int) array_rand($names);
+        $this->randomRecord = ['id' => $randomId, 'name' => (string) $names[$randomId]];
     }
 
     /**
@@ -107,7 +106,7 @@ public function verify(PDO $db): bool
      */
     public function getType(): ExerciseType
     {
-        return ExerciseType::CLI();
+        return new ExerciseType(ExerciseType::CLI);
     }
 
     /**

src/Exercise/DatabaseRead.php

@@ -91,7 +91,7 @@ private function newApiRequest(string $endpoint): RequestInterface
     }
 
     /**
-     * @return array
+     * @return array<string>
      */
     public function getRequiredPackages(): array
     {
@@ -106,7 +106,7 @@ public function getRequiredPackages(): array
      */
     public function getType(): ExerciseType
     {
-        return ExerciseType::CGI();
+        return new ExerciseType(ExerciseType::CGI);
     }
 
     /**