reflection: Check against the known string in is_closure_invoke()

TimWolla · TimWolla · commit 160dabf0451d · 2026-03-09T23:30:16.000+01:00
This can likely succeed by just comparing pointers in a majority of cases.
diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
@@ -195,7 +195,7 @@ static zend_always_inline uint32_t prop_get_flags(const property_reference *ref)
 
 static inline bool is_closure_invoke(const zend_class_entry *ce, const zend_string *lcname) {
 	return ce == zend_ce_closure
-		&& zend_string_equals_literal(lcname, ZEND_INVOKE_FUNC_NAME);
+		&& zend_string_equals(lcname, ZSTR_KNOWN(ZEND_STR_MAGIC_INVOKE));
 }
 
 static zend_function *_copy_function(zend_function *fptr) /* {{{ */

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ static zend_always_inline uint32_t prop_get_flags(const property_reference *ref)`
`195`	`195`
`196`	`196`	`static inline bool is_closure_invoke(const zend_class_entry ce, const zend_string lcname) {`
`197`	`197`	`return ce == zend_ce_closure`
`198`		`- && zend_string_equals_literal(lcname, ZEND_INVOKE_FUNC_NAME);`
	`198`	`+ && zend_string_equals(lcname, ZSTR_KNOWN(ZEND_STR_MAGIC_INVOKE));`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`static zend_function _copy_function(zend_function fptr) /* {{{ */`