perf: keep non-Windows compiler caches fresh

Author: NickSdot

.github/actions/ccache/action.yml

@@ -21,12 +21,12 @@ runs:
         major=$(cat ${{ inputs.php_directory }}/main/php_version.h | sed -En 's/^#define PHP_MAJOR_VERSION ([0-9]+)/\1/p')
         minor=$(cat ${{ inputs.php_directory }}/main/php_version.h | sed -En 's/^#define PHP_MINOR_VERSION ([0-9]+)/\1/p')
         release=$(cat ${{ inputs.php_directory }}/main/php_version.h | sed -En 's/^#define PHP_RELEASE_VERSION ([0-9]+)/\1/p')
-        week=$(date +"%Y-%W")
         prefix="${{ inputs.name }}-$major.$minor.$release"
-        echo "key=$prefix-$week" >> $GITHUB_OUTPUT
+        # GitHub cache entries are immutable, so each commit needs a new key.
+        echo "key=$prefix-$GITHUB_SHA" >> $GITHUB_OUTPUT
         echo "prefix=$prefix-" >> $GITHUB_OUTPUT
     - name: ccache
-      uses: hendrikmuhs/ccache-action@v1.2
+      uses: hendrikmuhs/ccache-action@d62db5f07c26379fc4b4e0916f098a92573c3b03 # v1.2.23
       with:
         key: "${{ steps.cache_key.outputs.key }}"
         append-timestamp: false

.github/matrix.php

@@ -8,6 +8,9 @@
     ['name' => 'PHP-8.2', 'ref' => 'PHP-8.2', 'version' => [8, 2]],
 ];
 
+// Temporary while profiling non-Windows CI builds. Remove after this work is complete.
+const SKIP_WINDOWS_CI = true;
+
 function get_branch_commit_cache_file_path(): string {
     return dirname(__DIR__) . '/branch-commit-cache.json';
 }
@@ -187,6 +190,9 @@ function select_jobs($repository, $trigger, $nightly, $labels, $php_version, $re
 foreach ($branches as &$branch) {
     $php_version = $branch['version'][0] . '.' . $branch['version'][1];
     $branch['jobs'] = select_jobs($repository, $trigger, $nightly, $labels, $php_version, $branch['ref'], $all_variations);
+    if (SKIP_WINDOWS_CI) {
+        unset($branch['jobs']['WINDOWS']);
+    }
     $branch['config']['ubuntu_version'] = version_compare($php_version, '8.5', '>=') ? '24.04' : '22.04';
 }
 

.github/workflows/unit-tests.yml

@@ -6,6 +6,7 @@ on:
       - 'main/io/**'
       - 'main/php_io.h'
       - 'tests/unit/**'
+      - '.github/actions/ccache/action.yml'
       - '.github/workflows/unit-tests.yml'
     branches:
       - master
@@ -15,6 +16,7 @@ on:
       - 'main/io/**'
       - 'main/php_io.h'
       - 'tests/unit/**'
+      - '.github/actions/ccache/action.yml'
       - '.github/workflows/unit-tests.yml'
     branches:
       - '**'
@@ -57,11 +59,9 @@ jobs:
             ccache
 
       - name: ccache
-        uses: hendrikmuhs/ccache-action@v1.2
+        uses: ./.github/actions/ccache
         with:
-          key: "unit-tests-${{hashFiles('main/php_version.h')}}"
-          append-timestamp: false
-          save: ${{ github.event_name != 'pull_request' }}
+          name: UNIT_TESTS_LINUX_X64
 
       - name: ./configure (minimal build)
         uses: ./.github/actions/configure-unit-tests
@@ -76,4 +76,3 @@ jobs:
           set -x
           cd tests/unit
           make test
-