Skip to content

Commit 5fd38ba

Browse files
committed
Merge branch 'PHP-8.3' into PHP-8.4
* PHP-8.3: CI: Enable JIT testing on Apple Silicon ZTS 8.6+
2 parents bdcf9ce + 0d24b90 commit 5fd38ba

2 files changed

Lines changed: 16 additions & 4 deletions

File tree

.github/matrix.php

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,19 @@ function select_jobs($repository, $trigger, $nightly, $labels, $php_version, $re
127127
$test_arm = version_compare($php_version, '8.4', '>=');
128128
$jobs['MACOS']['matrix'] = $all_variations
129129
? ['arch' => $test_arm ? ['X64', 'ARM64'] : ['X64'], 'debug' => [true, false], 'zts' => [true, false]]
130-
: ['include' => [['arch' => $test_arm ? 'ARM64' : 'X64', 'debug' => true, 'zts' => false]]];
130+
: ['include' => [['arch' => $test_arm ? 'ARM64' : 'X64', 'debug' => true, 'zts' => false, 'jit' => true]]];
131+
if ($all_variations) {
132+
// Set the jit variable on X64 jobs
133+
$jobs['MACOS']['matrix']['include'][] = ['arch' => 'X64', 'jit' => true];
134+
if ($test_arm) {
135+
// Set the jit variable on ARM64 NTS jobs
136+
$jobs['MACOS']['matrix']['include'][] = ['arch' => 'ARM64', 'zts' => false, 'jit' => true];
137+
// Set the jit variable on ARM64 ZTS jobs on 8.6+
138+
if (version_compare($php_version, '8.6', '>=')) {
139+
$jobs['MACOS']['matrix']['include'][] = ['arch' => 'ARM64', 'zts' => true, 'jit' => true];
140+
}
141+
}
142+
}
131143
$jobs['MACOS']['config']['arm64_version'] = version_compare($php_version, '8.4', '>=') ? '15' : '14';
132144
}
133145
if ($all_jobs || $test_msan) {

.github/workflows/test-suite.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -345,18 +345,18 @@ jobs:
345345
if: ${{ inputs.all_variations }}
346346
uses: ./.github/actions/test-macos
347347
- name: Test Tracing JIT
348-
if: ${{ matrix.arch == 'X64' || !matrix.zts }}
348+
if: ${{ matrix.jit }}
349349
uses: ./.github/actions/test-macos
350350
with:
351351
enableOpcache: true
352352
jitType: tracing
353353
- name: Test OpCache
354-
if: ${{ inputs.all_variations || (matrix.arch == 'ARM64' && matrix.zts) }}
354+
if: ${{ inputs.all_variations }}
355355
uses: ./.github/actions/test-macos
356356
with:
357357
enableOpcache: true
358358
- name: Test Function JIT
359-
if: ${{ inputs.all_variations && (matrix.arch == 'X64' || !matrix.zts) }}
359+
if: ${{ inputs.all_variations && matrix.jit }}
360360
uses: ./.github/actions/test-macos
361361
with:
362362
enableOpcache: true

0 commit comments

Comments
 (0)