Review

Author: arnaud-lb

Zend/zend_closures.c

@@ -54,7 +54,7 @@ static inline uint32_t zend_closure_flags(const zend_closure *closure)
 
 static inline bool zend_closure_is_fake(const zend_closure *closure)
 {
-	return (closure)->func.common.fn_flags & ZEND_ACC_FAKE_CLOSURE;
+	return closure->func.common.fn_flags & ZEND_ACC_FAKE_CLOSURE;
 }
 
 ZEND_METHOD(Closure, __invoke) /* {{{ */

Zend/zend_partial.c

@@ -742,7 +742,7 @@ static zend_op_array *zp_compile(zval *this_ptr, zend_function *function,
 	}
 
 	zval *tmp = zend_arena_alloc(&CG(ast_arena), zend_safe_address_guarded(new_argc, sizeof(zval), 0));
-	memcpy(tmp, argv, argc * sizeof(zval));
+	memcpy(tmp, argv, zend_safe_address_guarded(argc, sizeof(zval), 0));
 	argv = tmp;
 
 	/* Compute param positions and number of required args, add implicit

ext/opcache/ZendAccelerator.c

@@ -2031,7 +2031,8 @@ static zend_string *zend_accel_pfa_key(const zend_op *declaring_opline,
 	const size_t max_key_len = strlen(PFA_KEY_PREFIX) + (sizeof(uintptr_t)*2) + strlen(":") + (sizeof(uintptr_t)*2);
 	zend_string *key = zend_string_alloc(max_key_len, 0);
 
-	char *dest = zend_mempcpy(ZSTR_VAL(key), PFA_KEY_PREFIX, strlen(PFA_KEY_PREFIX));
+	char *dest = ZSTR_VAL(key);
+	dest = zend_mempcpy(dest, PFA_KEY_PREFIX, strlen(PFA_KEY_PREFIX));
 	dest = zend_accel_uintptr_hex(dest, (uintptr_t)declaring_opline);
 	*dest++ = ':';