async: drop separate Async API versioning; rely on ZEND_MODULE_API_NO

Author: EdmondDantes

Zend/zend_async_API.c

@@ -308,12 +308,6 @@ ZEND_API bool zend_async_scheduler_register(
 		return false;
 	}
 
-	if ((api->version >> 16) != ZEND_ASYNC_API_VERSION_MAJOR) {
-		zend_error(E_CORE_WARNING,
-				"Module %s was compiled against an incompatible Async API version", module);
-		return false;
-	}
-
 	/* A scheduler is registered once per process. */
 	if (scheduler_module_name != NULL) {
 		zend_error(E_CORE_WARNING,
@@ -400,15 +394,6 @@ ZEND_API const char *zend_async_get_scheduler_module(void)
 	return scheduler_module_name;
 }
 
-ZEND_API const char *zend_async_get_api_version(void)
-{
-	return ZEND_ASYNC_API;
-}
-
-ZEND_API int zend_async_get_api_version_number(void)
-{
-	return ZEND_ASYNC_API_VERSION_NUMBER;
-}
 
 ZEND_API void zend_async_scheduler_unregister(void)
 {

Zend/zend_async_API.h

@@ -26,14 +26,6 @@
  * provider's business; the core only offers the awaiting_info hook so
  * that the wait state can be inspected for diagnostics.
  */
-#define ZEND_ASYNC_API "AsyncCore ABI v0.1.0"
-#define ZEND_ASYNC_API_VERSION_MAJOR 0
-#define ZEND_ASYNC_API_VERSION_MINOR 1
-#define ZEND_ASYNC_API_VERSION_PATCH 0
-
-#define ZEND_ASYNC_API_VERSION_NUMBER \
-	((ZEND_ASYNC_API_VERSION_MAJOR << 16) | (ZEND_ASYNC_API_VERSION_MINOR << 8) \
-			| (ZEND_ASYNC_API_VERSION_PATCH))
 
 typedef struct _zend_coroutine_s zend_coroutine_t;
 typedef struct _zend_async_context_s zend_async_context_t;
@@ -357,12 +349,14 @@ typedef bool (*zend_async_gc_destructors_t)(zend_async_gc_run_dtors_fn run);
 typedef zend_coroutine_t *(*zend_async_intercept_fiber_t)(zend_fiber *fiber);
 
 /**
- * Versioned scheduler API bundle. A provider fills the struct and calls
+ * Scheduler API bundle. A provider fills the struct and calls
  * zend_async_scheduler_register(). New slots are appended at the end only;
  * `size` lets the core detect how much of the struct the provider knows.
+ * ABI compatibility rides on the standard PHP module API (ZEND_MODULE_API_NO),
+ * enforced when the provider extension is loaded — there is no separate
+ * Async API version.
  */
 typedef struct _zend_async_scheduler_api_s {
-	uint32_t version; /* ZEND_ASYNC_API_VERSION_NUMBER the provider was built against */
 	size_t size; /* sizeof(zend_async_scheduler_api_t) at provider build time */
 
 	zend_async_new_coroutine_t new_coroutine;
@@ -427,8 +421,6 @@ ZEND_API void zend_async_scheduler_unregister(void);
 ZEND_API bool zend_async_is_enabled(void);
 /* The module name of the registered scheduler, or NULL when none. */
 ZEND_API const char *zend_async_get_scheduler_module(void);
-ZEND_API const char *zend_async_get_api_version(void);
-ZEND_API int zend_async_get_api_version_number(void);
 
 END_EXTERN_C()
 

Zend/zend_scheduler_hook.c

@@ -395,7 +395,6 @@ static void php_async_handlers_reset(void)
 static void php_async_build_api(zend_async_scheduler_api_t *api)
 {
 	memset(api, 0, sizeof(*api));
-	api->version = ZEND_ASYNC_API_VERSION_NUMBER;
 	api->size = sizeof(*api);
 
 	if (PHP_ASYNC_HOOK(PHP_ASYNC_HOOK_LAUNCH)->set) {