feedback

devnexen · devnexen · commit 8e2989753b50 · 2026-04-18T13:32:01.000+01:00
diff --git a/ext/dom/php_dom.c b/ext/dom/php_dom.c
@@ -425,12 +425,8 @@ zval *dom_write_property(zend_object *object, zend_string *name, zval *value, vo
 		}
 
 		if (UNEXPECTED(!hnd->write_func)) {
-			if (prop && (prop->flags & ZEND_ACC_PPP_SET_MASK) &&
-			    !zend_asymmetric_property_has_set_access(prop)) {
-				zend_asymmetric_visibility_property_modification_error(prop, "modify");
-			} else {
-				zend_readonly_property_modification_error_ex(ZSTR_VAL(object->ce->name), ZSTR_VAL(name));
-			}
+			ZEND_ASSERT(prop && (prop->flags & ZEND_ACC_PPP_SET_MASK));
+			zend_asymmetric_visibility_property_modification_error(prop, "modify");
 			return &EG(error_zval);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -425,12 +425,8 @@ zval dom_write_property(zend_object object, zend_string name, zval value, vo`
`425`	`425`	`}`
`426`	`426`
`427`	`427`	`if (UNEXPECTED(!hnd->write_func)) {`
`428`		`- if (prop && (prop->flags & ZEND_ACC_PPP_SET_MASK) &&`
`429`		`- !zend_asymmetric_property_has_set_access(prop)) {`
`430`		`- zend_asymmetric_visibility_property_modification_error(prop, "modify");`
`431`		`- } else {`
`432`		`- zend_readonly_property_modification_error_ex(ZSTR_VAL(object->ce->name), ZSTR_VAL(name));`
`433`		`- }`
	`428`	`+ ZEND_ASSERT(prop && (prop->flags & ZEND_ACC_PPP_SET_MASK));`
	`429`	`+ zend_asymmetric_visibility_property_modification_error(prop, "modify");`
`434`	`430`	`return &EG(error_zval);`
`435`	`431`	`}`
`436`	`432`