review: replaced optional Filter dependency in concurrency parsing

NickSdot · NickSdot · commit 9fcd620d97d4 · 2026-07-30T22:58:23.000+07:00
diff --git a/run-tests.php b/run-tests.php
@@ -3377,13 +3377,13 @@ function parse_max_concurrency(string $text, string $file): int
 {
     // Strip comments
     $text = trim(preg_replace('/#.*/', '', $text));
-    $maxConcurrency = filter_var($text, FILTER_VALIDATE_INT, [
-        'options' => ['min_range' => 1],
-    ]);
-    if ($maxConcurrency === false) {
+    if (
+        preg_match('/^[1-9][0-9]*$/D', $text) !== 1
+        || (string) (int) $text !== $text
+    ) {
         error("Invalid positive integer in $file");
     }
-    return $maxConcurrency;
+    return (int) $text;
 }
 
 function show_result(

Original file line number	Diff line number	Diff line change
`@@ -3377,13 +3377,13 @@ function parse_max_concurrency(string $text, string $file): int`
`3377`	`3377`	`{`
`3378`	`3378`	`// Strip comments`
`3379`	`3379`	`$text = trim(preg_replace('/#.*/', '', $text));`
`3380`		`- $maxConcurrency = filter_var($text, FILTER_VALIDATE_INT, [`
`3381`		`- 'options' => ['min_range' => 1],`
`3382`		`- ]);`
`3383`		`- if ($maxConcurrency === false) {`
	`3380`	`+ if (`
	`3381`	`+ preg_match('/^[1-9][0-9]*$/D', $text) !== 1`
	`3382`	`+ \|\| (string) (int) $text !== $text`
	`3383`	`+ ) {`
`3384`	`3384`	`error("Invalid positive integer in $file");`
`3385`	`3385`	`}`
`3386`		`- return $maxConcurrency;`
	`3386`	`+ return (int) $text;`
`3387`	`3387`	`}`
`3388`	`3388`
`3389`	`3389`	`function show_result(`