Remove the mysqlnd_reverse_api feature

Author: kamil-tekiela

ext/mysqli/mysqli.c

@@ -393,8 +393,6 @@ PHP_MYSQLI_EXPORT(zend_object *) mysqli_objects_new(zend_class_entry *class_type
 }
 /* }}} */
 
-#include "ext/mysqlnd/mysqlnd_reverse_api.h"
-
 static PHP_INI_MH(OnUpdateDefaultPort)
 {
 	zend_long value = ZEND_ATOL(ZSTR_VAL(new_value));
@@ -517,8 +515,6 @@ PHP_MINIT_FUNCTION(mysqli)
 
 	register_mysqli_symbols(module_number);
 
-	mysqlnd_reverse_api_register_api(&mysqli_module_entry);
-
 	return SUCCESS;
 }
 /* }}} */

ext/mysqlnd/config.w32

@@ -15,7 +15,6 @@ if (PHP_MYSQLND != "no") {
 			"mysqlnd_driver.c " +
 			"mysqlnd_ext_plugin.c " +
 			"mysqlnd_loaddata.c " +
-			"mysqlnd_reverse_api.c " +
 			"mysqlnd_plugin.c " +
 			"mysqlnd_protocol_frame_codec.c " +
 			"mysqlnd_ps.c " +

ext/mysqlnd/config9.m4

@@ -54,7 +54,6 @@ if test "$PHP_MYSQLND" != "no" || test "$PHP_MYSQLND_ENABLED" = "yes"; then
     mysqlnd_read_buffer.c
     mysqlnd_result_meta.c
     mysqlnd_result.c
-    mysqlnd_reverse_api.c
     mysqlnd_statistics.c
     mysqlnd_vio.c
     mysqlnd_wireprotocol.c

ext/mysqlnd/mysqlnd_driver.c

@@ -24,7 +24,6 @@
 #include "mysqlnd_priv.h"
 #include "mysqlnd_statistics.h"
 #include "mysqlnd_debug.h"
-#include "mysqlnd_reverse_api.h"
 #include "mysqlnd_ext_plugin.h"
 
 static bool mysqlnd_library_initted = FALSE;
@@ -57,7 +56,6 @@ PHPAPI void mysqlnd_library_end(void)
 		mysqlnd_stats_end(mysqlnd_global_stats, 1);
 		mysqlnd_global_stats = NULL;
 		mysqlnd_library_initted = FALSE;
-		mysqlnd_reverse_api_end();
 	}
 }
 /* }}} */
@@ -84,8 +82,6 @@ PHPAPI void mysqlnd_library_init(void)
 		mysqlnd_debug_trace_plugin_register();
 		mysqlnd_register_builtin_authentication_plugins();
 
-		mysqlnd_reverse_api_init();
-
 #if MYSQLND_CHARSETS_SANITY_CHECK == 1
 		void mysqlnd_charsets_sanity_check(void);
 		mysqlnd_charsets_sanity_check();

ext/mysqlnd/mysqlnd_reverse_api.c

@@ -21,7 +21,6 @@
 #include "mysqlnd_priv.h"
 #include "mysqlnd_debug.h"
 #include "mysqlnd_statistics.h"
-#include "mysqlnd_reverse_api.h"
 #include "ext/standard/info.h"
 #include "zend_smart_str.h"
 
@@ -57,23 +56,6 @@ mysqlnd_minfo_dump_loaded_plugins(zval *el, void * buf)
 /* }}} */
 
 
-/* {{{ mysqlnd_minfo_dump_api_plugins */
-static void
-mysqlnd_minfo_dump_api_plugins(smart_str * buffer)
-{
-	HashTable *ht = mysqlnd_reverse_api_get_api_list();
-	zend_module_entry * ext;
-
-	ZEND_HASH_MAP_FOREACH_PTR(ht, ext) {
-		if (buffer->s) {
-			smart_str_appendc(buffer, ',');
-		}
-		smart_str_appends(buffer, ext->name);
-	} ZEND_HASH_FOREACH_END();
-}
-/* }}} */
-
-
 /* {{{ PHP_MINFO_FUNCTION */
 PHP_MINFO_FUNCTION(mysqlnd)
 {
@@ -118,11 +100,6 @@ PHP_MINFO_FUNCTION(mysqlnd)
 		smart_str_0(&tmp_str);
 		php_info_print_table_row(2, "Loaded plugins", tmp_str.s? ZSTR_VAL(tmp_str.s) : "");
 		smart_str_free(&tmp_str);
-
-		mysqlnd_minfo_dump_api_plugins(&tmp_str);
-		smart_str_0(&tmp_str);
-		php_info_print_table_row(2, "API Extensions", tmp_str.s? ZSTR_VAL(tmp_str.s) : "");
-		smart_str_free(&tmp_str);
 	}
 
 	php_info_print_table_end();

ext/mysqlnd/mysqlnd_reverse_api.h

@@ -57,10 +57,6 @@ ZEND_DECLARE_MODULE_GLOBALS(pdo_mysql)
 # endif
 #endif
 
-#ifdef PDO_USE_MYSQLND
-#include "ext/mysqlnd/mysqlnd_reverse_api.h"
-#endif
-
 /* Returns the number of SQL warnings during the execution of the last statement */
 PHP_METHOD(Pdo_Mysql, getWarningCount)
 {
@@ -125,10 +121,6 @@ static PHP_MINIT_FUNCTION(pdo_mysql)
 	REGISTER_PDO_MYSQL_CLASS_CONST_LONG_DEPRECATED_ALIAS_85("ATTR_LOCAL_INFILE_DIRECTORY", (zend_long)PDO_MYSQL_ATTR_LOCAL_INFILE_DIRECTORY);
 #endif
 
-#ifdef PDO_USE_MYSQLND
-	mysqlnd_reverse_api_register_api(&pdo_mysql_module_entry);
-#endif
-
 	pdo_mysql_ce = register_class_Pdo_Mysql(pdo_dbh_ce);
 	pdo_mysql_ce->create_object = pdo_dbh_new;