MSVC: Fix warning C4244 in zend_get_gc_buffer_use

wmamrak · wmamrak · commit ba99fecdefa3 · 2025-12-16T18:30:51.000+01:00
This PR addresses a compilation warning of the form:
warning C4244: '=': conversion from '__int64' to 'int', possible loss of data
The expression gc_buffer-&gt;cur - gc_buffer-&gt;start produces a temporary of type ptrdiff_t, which is then assigned to an int. It causes said compilation warning if these types do not match.
diff --git a/Zend/zend_gc.h b/Zend/zend_gc.h
@@ -167,7 +167,7 @@ static zend_always_inline void zend_get_gc_buffer_add_ptr(
 static zend_always_inline void zend_get_gc_buffer_use(
 		zend_get_gc_buffer *gc_buffer, zval **table, int *n) {
 	*table = gc_buffer->start;
-	*n = gc_buffer->cur - gc_buffer->start;
+	*n = (int)(gc_buffer->cur - gc_buffer->start);
 }
 
 END_EXTERN_C()

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ static zend_always_inline void zend_get_gc_buffer_add_ptr(`
`167`	`167`	`static zend_always_inline void zend_get_gc_buffer_use(`
`168`	`168`	`zend_get_gc_buffer gc_buffer, zval table, int n) {`
`169`	`169`	`*table = gc_buffer->start;`
`170`		`- *n = gc_buffer->cur - gc_buffer->start;`
	`170`	`+ *n = (int)(gc_buffer->cur - gc_buffer->start);`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`END_EXTERN_C()`