run-tests.phpt `-s` option is broken

[ndossche]

Description

Run:

./sapi/cli/php ./run-tests.php -s foobar ext/openssl/tests/gh13860.phpt

Notice how foobar is not created.
This is because of the following early return which is hit:

php-src/run-tests.php

Lines 909 to 911 in 146b535

	if (getenv('NO_INTERACTION')) {
	return;
	}

because the same code path that calls save_results:

php-src/run-tests.php

Line 704 in 146b535

putenv('NO_INTERACTION=1');

But I have no idea why

PHP Version

8.4+

Operating System

No response

[iluuu1994]

diff --git a/run-tests.php b/run-tests.php
index d7cd07f7c66..5fe553cecf0 100755
--- a/run-tests.php
+++ b/run-tests.php
@@ -701,6 +701,8 @@ function main(): void
     write_information($user_tests, $phpdbg);
 
     if ($test_cnt) {
+        $exts_tested = [];
+        $exts_skipped = [];
         putenv('NO_INTERACTION=1');
         usort($test_files, "test_sort");
         $start_time = hrtime(true);
@@ -780,7 +782,7 @@ function main(): void
         show_end($start_timestamp, $start_time, $end_time);
         show_summary();
 
-        save_results($output_file, /* prompt_to_save_results: */ true);
+        save_results($output_file, /* prompt_to_save_results: */ !$just_save_results);
     }
 
     $junit->saveXML();
@@ -906,7 +908,7 @@ function save_results(string $output_file, bool $prompt_to_save_results): void
 {
     global $sum_results, $failed_test_summary, $PHP_FAILED_TESTS, $php;
 
-    if (getenv('NO_INTERACTION')) {
+    if (getenv('NO_INTERACTION') && $prompt_to_save_results) {
         return;
     }

Something like this should work.

[ndossche]

Ah I suppose that makes sense, the NO_INTERACTION must indeed be there for the prompting... Feel free to PR this and I'll approve, it looks right.