From ffb1b65223723e3df38aca140c93cf6626f18b75 Mon Sep 17 00:00:00 2001 From: Jarne Clauw <67628242+JarneClauw@users.noreply.github.com> Date: Wed, 6 May 2026 16:58:46 +0200 Subject: [PATCH 1/2] Fixing memory leak --- ext/openssl/openssl_backend_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ext/openssl/openssl_backend_common.c b/ext/openssl/openssl_backend_common.c index b1440e57b2f2..442de644d260 100644 --- a/ext/openssl/openssl_backend_common.c +++ b/ext/openssl/openssl_backend_common.c @@ -599,6 +599,7 @@ zend_string* php_openssl_x509_fingerprint(X509 *peer, const char *method, bool r } else if (!X509_digest(peer, mdtype, md, &n)) { php_openssl_store_errors(); php_error_docref(NULL, E_ERROR, "Could not generate signature"); + php_openssl_release_evp_md(mdtype); return NULL; } @@ -610,6 +611,7 @@ zend_string* php_openssl_x509_fingerprint(X509 *peer, const char *method, bool r ZSTR_VAL(ret)[n * 2] = '\0'; } + php_openssl_release_evp_md(mdtype); return ret; } From 191f8e7c0ac463c0b02e1b14f230733515c96b55 Mon Sep 17 00:00:00 2001 From: Jarne Clauw <67628242+JarneClauw@users.noreply.github.com> Date: Wed, 6 May 2026 17:09:16 +0200 Subject: [PATCH 2/2] fix order --- ext/openssl/openssl_backend_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/openssl/openssl_backend_common.c b/ext/openssl/openssl_backend_common.c index 442de644d260..95aabefbbba7 100644 --- a/ext/openssl/openssl_backend_common.c +++ b/ext/openssl/openssl_backend_common.c @@ -597,9 +597,9 @@ zend_string* php_openssl_x509_fingerprint(X509 *peer, const char *method, bool r php_error_docref(NULL, E_WARNING, "Unknown digest algorithm"); return NULL; } else if (!X509_digest(peer, mdtype, md, &n)) { + php_openssl_release_evp_md(mdtype); php_openssl_store_errors(); php_error_docref(NULL, E_ERROR, "Could not generate signature"); - php_openssl_release_evp_md(mdtype); return NULL; }